Skip to content

Replace ign with gz in installation tutorial#382

Merged
iche033 merged 3 commits intogz-sensors8from
update_installation
Sep 13, 2023
Merged

Replace ign with gz in installation tutorial#382
iche033 merged 3 commits intogz-sensors8from
update_installation

Conversation

@iche033
Copy link
Contributor

@iche033 iche033 commented Sep 12, 2023

🦟 Bug fix

gazebosim/gazebo_test_cases#179

Summary

ign/ignition -> gz

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 12, 2023
```

4. Before `gz-rendering` becomes available on conda-forge, we need to build it from source and specify the path containing `gz-rendering-config.cmake` in `CMAKE_PREFIX_PATH`, for cmake to find `gz-rendering`. That path could be `gz-rendering-install-path\lib\cmake\gz-rendering4`, for example.
4. Before `gz-rendering` becomes available on conda-forge, we need to build it from source and specify the path containing `gz-rendering-config.cmake` in `CMAKE_PREFIX_PATH`, for cmake to find `gz-rendering`. That path could be `gz-rendering-install-path\lib\cmake\gz-rendering8`, for example.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjcarroll the windows instructions are probably out of date? Is it possible to just do
conda install libgz-sensors<#> / conda install libgz-rendering<#>?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is correct:

https://prefix.dev/channels/conda-forge/packages/gz-sensors7
https://prefix.dev/channels/conda-forge/packages/gz-rendering7

The harmonic versions will come when we have official tags, according to @traversaro

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, conda-forge does not do prerelease in general, see https://conda-forge.org/docs/maintainer/knowledge_base.html#pre-release-builds .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated windows instructions in f975133

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #382 (610092b) into gz-sensors8 (cb20312) will not change coverage.
Report is 3 commits behind head on gz-sensors8.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-sensors8     #382   +/-   ##
============================================
  Coverage        72.76%   72.76%           
============================================
  Files               36       36           
  Lines             4968     4968           
============================================
  Hits              3615     3615           
  Misses            1353     1353           

Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit 11bf731 into gz-sensors8 Sep 13, 2023
@iche033 iche033 deleted the update_installation branch September 13, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants