Skip to content

Port frame_id fixes from #444#446

Merged
iche033 merged 1 commit intogz-sensors8from
backport_frame_fixes
Jul 10, 2024
Merged

Port frame_id fixes from #444#446
iche033 merged 1 commit intogz-sensors8from
backport_frame_fixes

Conversation

@iche033
Copy link
Contributor

@iche033 iche033 commented Jul 9, 2024

🦟 Bug fix

Summary

Partial backport of #444. Ported changes that fix missing / incorrect DVL and GpuLidar frame_ids

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jul 9, 2024
@iche033 iche033 merged commit d49310b into gz-sensors8 Jul 10, 2024
@iche033 iche033 deleted the backport_frame_fixes branch July 10, 2024 16:24
iche033 added a commit that referenced this pull request Jul 15, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033 added a commit that referenced this pull request Jul 15, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033 added a commit that referenced this pull request Jul 15, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033 added a commit that referenced this pull request Jul 15, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033 added a commit that referenced this pull request Aug 7, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants