Add list of supported sensors with API and SDF links to README#511
Conversation
iche033
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
It's looking good. I made some comments inline. Here are a few more comments:
- For the
SDF speccolumn, I see that it's pointing to the respective SDF element in the spec page. Can you change each row's text to the actual SDF element string? e.g.SDF Air Pressure-><air_pressure>? - Can you remove the
Examplecolumn for now? They are pointing to test source code, which may not be the best examples for users to look at. - Add Segmentation camera sensor to the table
README.md
Outdated
| | **Air Pressure Sensor** | [AirPressureSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1AirPressureSensor.html) | [SDF Air Pressure](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_air_pressure) | [air_pressure.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/air_pressure.cc) | Measures atmospheric pressure | | ||
| | **Air Speed Sensor** | [AirSpeedSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1AirSpeedSensor.html) | [SDF Air Speed](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_air_speed) | [air_speed.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/air_speed.cc) | Measures the speed of air relative to the sensor | | ||
| | **Altimeter** | [AltimeterSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1AltimeterSensor.html) | [SDF Altimeter](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_altimeter) | [altimeter.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/altimeter.cc) | Measures altitude above a reference point | | ||
| | **Bounding Box Camera** | [BoundingBoxCameraSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1BoundingBoxCameraSensor.html) | [SDF Bounding Box Camera](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_boundingbox_camera) | [boundingbox_camera.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/boundingbox_camera.cc) | Captures images with bounding box annotations | |
There was a problem hiding this comment.
for the SDF Spec column, I noticed that not all links are not valid, e.g. http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_boundingbox_camera. That's because there may not be a dedicated SDF element for that sensor.
For boundingbox camera, segmentation camera, thermal camera, and wide angle camera types, you can point to <camera>: http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_camera
README.md
Outdated
| | **Sensor Name** | **API Link** | **SDF Spec** | **Example** | **Notes** | | ||
| |---------------------------|-------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------|----------------------------------------------------| | ||
| | **Air Pressure Sensor** | [AirPressureSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1AirPressureSensor.html) | [SDF Air Pressure](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_air_pressure) | [air_pressure.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/air_pressure.cc) | Measures atmospheric pressure | | ||
| | **Air Speed Sensor** | [AirSpeedSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1AirSpeedSensor.html) | [SDF Air Speed](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_air_speed) | [air_speed.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/air_speed.cc) | Measures the speed of air relative to the sensor | |
There was a problem hiding this comment.
air speed sensor is not available in sdf spec 1.9. Can you update all the SDF links to point to the latest 1.12 spec?
README.md
Outdated
| | **Depth Camera** | [DepthCameraSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1DepthCameraSensor.html) | [SDF Depth Camera](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_depth_camera) | [depth_camera.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/depth_camera.cc) | Captures depth information | | ||
| | **Doppler Velocity Log** | [DopplerVelocityLog](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1DopplerVelocityLog.html) | [SDF DVL](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_dvl) | [dvl.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/dvl.cc) | Measures velocity relative to a water body | | ||
| | **Force-Torque** | [ForceTorqueSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1ForceTorqueSensor.html) | [SDF Force-Torque](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_force_torque) | [force_torque.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/force_torque.cc) | Measures forces and torques on a joint | | ||
| | **GPU Lidar** | [GpuLidarSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1GpuLidarSensor.html) | [SDF GPU Lidar](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_gpu_lidar) | [gpu_lidar_sensor.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/gpu_lidar_sensor.cc) | Simulates a 3D laser scanner using GPU acceleration| |
There was a problem hiding this comment.
update link:
| | **GPU Lidar** | [GpuLidarSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1GpuLidarSensor.html) | [SDF GPU Lidar](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_gpu_lidar) | [gpu_lidar_sensor.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/gpu_lidar_sensor.cc) | Simulates a 3D laser scanner using GPU acceleration| | |
| | **GPU Lidar** | [GpuLidarSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1GpuLidarSensor.html) | [SDF GPU Lidar](http://sdformat.org/spec?ver=1.9&elem=sensor#sensor_lidar) | [gpu_lidar_sensor.cc](https://github.com/gazebosim/gz-sensors/blob/main/test/integration/gpu_lidar_sensor.cc) | Simulates a 3D laser scanner using GPU acceleration| |
Co-authored-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Shyam Ganatra <shyam2010ganatra@gmail.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Shyam Ganatra <shyam2010ganatra@gmail.com>
…s: added Segmentation Camera
updated SDF links for Air Speed Sensor, Doppler Velocity Log, RGBD Camera Signed-off-by: Shyam Ganatra <shyam2010ganatra@gmail.com>
|
Thank you, @iche033 , for all the suggestions. I have made edits and updated the README. However, I was unable to find the SDF element links for the Air Speed Sensor, Doppler Velocity Log, and RGBD Camera. For now, I've marked them as "Not in SDF 1.12." Please let me know if any changes are needed. |
iche033
left a comment
There was a problem hiding this comment.
just a couple minor comments, otherwise looks good!
README.md
Outdated
| | **Logical Camera** | [LogicalCameraSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1LogicalCameraSensor.html) | [`<logical_camera>`](http://sdformat.org/spec?ver=1.12&elem=sensor#sensor_logical_camera) | Detects models within a specified volume | | ||
| | **Magnetometer** | [MagnetometerSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1MagnetometerSensor.html) | [`<magnetometer>`](http://sdformat.org/spec?ver=1.12&elem=sensor#sensor_magnetometer) | Measures magnetic field strength and direction | | ||
| | **NavSat (GPS)** | [NavSatSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1NavSatSensor.html) | [`<navsat>`](http://sdformat.org/spec?ver=1.12&elem=sensor#sensor_navsat) | Simulates GPS-like positioning sensor | | ||
| | **RGBD Camera** | [RGBDCameraSensor](https://gazebosim.org/api/sensors/7/classgz_1_1sensors_1_1RgbdCameraSensor.html) | (Not in SDF 1.12) | Captures RGB + Depth streams | |
There was a problem hiding this comment.
for RGBD camera, can you also link to <camera>?
README.md
Outdated
| | **Sensor Name** | **API Link** | **SDF Element** | **Notes** | | ||
| |---------------------------|-------------------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------------------------------------|----------------------------------------------------| | ||
| | **Air Pressure Sensor** | [AirPressureSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1AirPressureSensor.html) | [`<air_pressure>`](http://sdformat.org/spec?ver=1.12&elem=sensor#sensor_air_pressure) | Measures atmospheric pressure | | ||
| | **Air Speed Sensor** | [AirSpeedSensor](https://gazebosim.org/api/sensors/9/classgz_1_1sensors_1_1AirSpeedSensor.html) | *(Not in SDF 1.12)* | Measures the speed of air relative to the sensor | |
There was a problem hiding this comment.
can you put N/A instead of (Not in SDF 1.12) for this entry and also DVL?
Signed-off-by: Shyam Ganatra <shyam2010ganatra@gmail.com>
|
Ok, I just made an update. |
Signed-off-by: Ian Chen <ichen@openrobotics.org>
|
thanks for the contribution! |
|
@ganatrask Thanks so much! |
🎉 New feature
Closes #103
Summary
This PR adds a new section to the
README.mdthat lists all supported sensors in thegz-sensorslibrary.The list includes:
This improves discoverability for new users visiting the repository or the Gazebo Sim sensor docs page.
Test it
You can view the updated
README.mdand verify the new "Supported Sensors" section is rendered properly in Markdown preview mode.Checklist
README.md)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.