Skip to content

Added invalid point checking to RGBD and Depth Camera plugins to set is_dense flag accordingly (backport #575)#579

Merged
ahcorde merged 1 commit intogz-sensors9from
mergify/bp/gz-sensors9/pr-575
Jan 7, 2026
Merged

Added invalid point checking to RGBD and Depth Camera plugins to set is_dense flag accordingly (backport #575)#579
ahcorde merged 1 commit intogz-sensors9from
mergify/bp/gz-sensors9/pr-575

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jan 7, 2026

🦟 Bug fix

Fixes #574

Summary

Fix similar to #180. Added gz::math::isnan and std::isinf checks to depth/coordinates in all FillMsg methods in PointUtil.cc
, which RGBD Camera and Depth Camera depend on.

Reproducibility steps described in #574.
New output should look the same, except for the is_dense flag, which should be set to false.

(maybe another test/world should be done where the point cloud only contains valid points, to check if is_dense is correctly set to true)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #575 done by Mergify.

…is_dense flag accordingly (#575)

Signed-off-by: Dyst-0 <69257845+Dyst-0@users.noreply.github.com>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit e1c5bd6)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 7, 2026
@ahcorde ahcorde merged commit d810175 into gz-sensors9 Jan 7, 2026
16 checks passed
@ahcorde ahcorde deleted the mergify/bp/gz-sensors9/pr-575 branch January 7, 2026 09:46
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants