👩🌾 Suggestions on addressing Windows warnings#59
Merged
chapulina merged 4 commits intoahcorde/windows/warningsfrom Nov 11, 2020
Merged
👩🌾 Suggestions on addressing Windows warnings#59chapulina merged 4 commits intoahcorde/windows/warningsfrom
chapulina merged 4 commits intoahcorde/windows/warningsfrom
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ahcorde/windows/warnings #59 +/- ##
=========================================================
Coverage 76.33% 76.33%
=========================================================
Files 23 23
Lines 2320 2320
=========================================================
Hits 1771 1771
Misses 549 549
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
iche033
reviewed
Nov 11, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
iche033
approved these changes
Nov 11, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ahcorde opened #58 as I was working on the same thing 😅
I started from the fixes in #38, but also made some additional changes to make sure we're only suppressing what we need to.
I was also targeting Citadel, but I rebased on top of #58 so we can get that one in, and we can backport everything afterwards.
The main updates here are:
ign-rendering's warnings the same way as in 👩🌾 Disable more tests known to fail on macOS and Windows gz-gui#112, with a note to remove the suppression here once they're fixed upstream.#include <ignition/rendering.hh>to include only what we use (and reduce warnings in the process)