Merged
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-sensors3 #86 +/- ##
================================================
- Coverage 77.54% 77.39% -0.15%
================================================
Files 23 23
Lines 2298 2305 +7
================================================
+ Hits 1782 1784 +2
- Misses 516 521 +5
Continue to review full report at Codecov.
|
iche033
reviewed
Jan 28, 2021
Signed-off-by: Nate Koenig <nate@openrobotics.org>
iche033
reviewed
Feb 4, 2021
src/Lidar.cc
Outdated
| { | ||
| for (unsigned int i = 0; i < this->RayCount(); ++i) | ||
| { | ||
| int index = j * this->RangeCount() + i; |
Contributor
There was a problem hiding this comment.
one more this->RangeCount() to this->RayCount() here
Signed-off-by: Nate Koenig <nate@openrobotics.org>
iche033
approved these changes
Feb 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noise was not applied to the point cloud generated by the GpuLidarSensor. This change applies noise to the
laserBuffer, which then used by both thescanandpoint cloudtopics.Signed-off-by: Nate Koenig nate@openrobotics.org