Let derived sensors call Sensor::Update#187
Merged
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This was referenced Jan 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 70.31% 70.31%
=======================================
Files 28 28
Lines 2975 2975
=======================================
Hits 2092 2092
Misses 883 883
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Jan 12, 2022
Contributor
Author
|
The warning on Jenkins is not introduced by this PR and should be solved when #188 is merged forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Ignition Gazebo calls update directly on non-rendering sensors, but it's easy to call the "wrong" function if one is not careful. There are 2
Updatefunctions on the base class:public: bool Update(const std::chrono::steady_clock::duration &_now, const bool _force);public: virtual bool Update(const std::chrono::steady_clock::duration &_now) = 0;Most (all?) of the time, one would want to call
1., which calls2.under the hood and performs extra steps. But since2.is also public, and easier to call, we often call2.directly by mistake.This PR solves one of the issues by making it easier to call the base class's function. The test changes in this PR wouldn't be possible without the
usinglines, for example. Also see theign-gazeboPR:We should consider also making the virtual function private, which will require a tick-tock cycle.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸