-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[public-api] Extend k8s definitions with a service #9362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fd83c28
to
583ff4e
Compare
42d7c9e
to
0bee99d
Compare
0bee99d
to
c32e218
Compare
15819ff
to
875bef7
Compare
875bef7
to
09d6121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍 Can hit the service from a pod.
(@andrew-farries please assign yourself as soon as you start reviewing so we avoid double work. Thx! 🙏 ) |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-papi-service-def.8 |
/unhold |
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-papi-service-def.9 |
Description
Add a k8s service for existing
public-api
deployment. This will allow the service to be exposed in the Caddy proxy config such that we can route traffic to the deployment (accessible, but still unused), only in preview builds for now.Related Issue(s)
How to test
kubectl get service
and observepublic-api-service
Release Notes
Documentation
NONE
/hold