Skip to content

[public-api] Extend k8s definitions with a service #9362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 16, 2022

Description

Add a k8s service for existing public-api deployment. This will allow the service to be exposed in the Caddy proxy config such that we can route traffic to the deployment (accessible, but still unused), only in preview builds for now.

Related Issue(s)

How to test

  1. Start a workspace from this branch
  2. List k8s services with kubectl get service and observe public-api-service
  3. Hit the service:
kubectl exec mysql-0 -it -- /bin/bash

$ curl http://public-api-server:9000
hello world\n

Release Notes

NONE

Documentation

NONE

/hold

@easyCZ easyCZ force-pushed the mp/papi-service-def branch from 875bef7 to 09d6121 Compare April 20, 2022 09:36
@roboquat roboquat added size/M and removed size/L labels Apr 20, 2022
@easyCZ easyCZ marked this pull request as ready for review April 20, 2022 09:37
@easyCZ easyCZ requested a review from a team April 20, 2022 09:37
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 20, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Can hit the service from a pod.

@geropl
Copy link
Member

geropl commented Apr 20, 2022

(@andrew-farries please assign yourself as soon as you start reviewing so we avoid double work. Thx! 🙏 )

@easyCZ
Copy link
Member Author

easyCZ commented Apr 20, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-papi-service-def.8

@easyCZ
Copy link
Member Author

easyCZ commented Apr 20, 2022

/unhold

@easyCZ
Copy link
Member Author

easyCZ commented Apr 20, 2022

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-papi-service-def.9

@roboquat roboquat merged commit 660b593 into main Apr 20, 2022
@roboquat roboquat deleted the mp/papi-service-def branch April 20, 2022 11:01
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants