[public-api] Route api.<domain> to public api service & deployment #9363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
easyCZ
force-pushed
the
mp/papi-service-def
branch
from
875bef7 to
09d6121
Compare
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-papi-caddy.4 |
|
/werft run with-clean-slate-deployment=true 👍 started the job as gitpod-build-mp-papi-caddy.5 |
andrew-farries
approved these changes
Apr 20, 2022
Comment on lines
+25
to
+28
| if err := register(srv); err != nil { | ||
| logger.WithError(err).Fatal("Failed to register services.") | ||
| } | ||
|
|
There was a problem hiding this comment.
Was this change necessary to set up the routing or just overlooked in earlier PRs?
There was a problem hiding this comment.
Overlooked from other PRs.
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
How to test
Navigate to preview build. Prepend
api.to the URL and you should seehello worldhttps://api.mp-papi-caddy.staging.gitpod-dev.com
In prod, we haven't configured the DNS record to point to our loadbalancer so it won't work, yet. This is fine, we can iterate in preview for now.
Release Notes
Documentation
NONE
/hold