Skip to content

[public-api] Set config in installer #9740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

[public-api] Set config in installer #9740

merged 1 commit into from
May 4, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 3, 2022

Description

Set config for public API explicitly instead of relying on defaults, ensures easier debugging when issues arise, also parametrizes gitpod API url

Related Issue(s)

How to test

Unit tests

Release Notes

NONE

Documentation

NONE

/hold

@easyCZ easyCZ force-pushed the mp/papi-config branch from 1591a1a to 1367bc5 Compare May 4, 2022 09:21
Base automatically changed from mp/papi-config to main May 4, 2022 09:27
@roboquat roboquat added size/L and removed size/M labels May 4, 2022
@easyCZ easyCZ force-pushed the mp/papi-config-installer branch from 40da564 to c5ecccc Compare May 4, 2022 10:09
@roboquat roboquat added size/M and removed size/L labels May 4, 2022
@easyCZ easyCZ force-pushed the mp/papi-config-installer branch from c5ecccc to ccf5d74 Compare May 4, 2022 10:20
@easyCZ easyCZ marked this pull request as ready for review May 4, 2022 10:20
@easyCZ easyCZ requested a review from a team May 4, 2022 10:20
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 4, 2022
@easyCZ easyCZ force-pushed the mp/papi-config-installer branch 2 times, most recently from e9063d8 to 57e0a41 Compare May 4, 2022 11:04
@easyCZ
Copy link
Member Author

easyCZ commented May 4, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-mp-papi-config-installer.7
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/papi-config-installer branch from c3f8c39 to e154849 Compare May 4, 2022 14:26
@easyCZ
Copy link
Member Author

easyCZ commented May 4, 2022

/unhold

@easyCZ easyCZ force-pushed the mp/papi-config-installer branch from e154849 to ec2f5a4 Compare May 4, 2022 14:28
@roboquat roboquat merged commit 9e84038 into main May 4, 2022
@roboquat roboquat deleted the mp/papi-config-installer branch May 4, 2022 14:35
@roboquat roboquat added the deployed: webapp Meta team change is running in production label May 5, 2022
@roboquat roboquat added the deployed Change is completely running in production label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @andrew-farries @roboquat