Skip to content

feat: return time of last usage for public keys and access tokens in the api #34323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 1, 2025

Conversation

tobiasbp
Copy link
Contributor

@tobiasbp tobiasbp commented Apr 30, 2025

In the Gitea GUI, the user can see the time that AccessTokens and PublicKeys were last used. This information is not returned by the /users/{username}/tokens and /user/keys endpoints in the API. This PR adds the missing data.

The time of last usage for for tokens & keys seem to be stored in the Updated field of the structs internally. For consistency, I have used the name updated_at for the new field returned by the API. However, for the API user, I don't think that name reflects the data returned, as I believe it is the time of last usage. I propose that we use the name last_used_at instead. Let's hear reviewers opinion on that.

  • PublicKey
    1. last_used_at: string($date-time)
  • AccessToken
    1. created_at: string($date-time) (for parity with public keys)
    2. last_used_at: string($date-time)

Fix #34313

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 30, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 30, 2025
@delvh
Copy link
Member

delvh commented Apr 30, 2025

Please run make generate-swagger

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 30, 2025
@lunny lunny added the backport/v1.24 This PR should be backported to Gitea 1.24 label Apr 30, 2025
@lunny lunny added this to the 1.25.0 milestone Apr 30, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 1, 2025
@lafriks lafriks merged commit 3e49fba into go-gitea:main May 1, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 1, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 1, 2025
…the api (go-gitea#34323)

In the Gitea GUI, the user can see the time that _AccessTokens_ and
_PublicKeys_ were last used. This information is not returned by the
_/users/{username}/tokens_ and _/user/keys_ endpoints in the API. This
PR adds the missing data.

The time of last usage for for _tokens_ & _keys_ seem to be stored in
the _Updated_ field of the structs internally. For consistency, I have
used the name _updated_at_ for the new field returned by the _API_.
However, for the _API_ user, I don't think that name reflects the data
returned, as I believe it is the time of last usage. I propose that we
use the name _last_used_at_ instead. Let's hear reviewers opinion on
that.

* PublicKey
  1. _last_used_at_: string($date-time)
* AccessToken
  1. _created_at_: string($date-time) (for parity with public keys)
  2. _last_used_at_: string($date-time)

Fix go-gitea#34313
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label May 1, 2025
lunny pushed a commit that referenced this pull request May 1, 2025
…the api (#34323) (#34339)

Backport #34323 by @tobiasbp

In the Gitea GUI, the user can see the time that _AccessTokens_ and
_PublicKeys_ were last used. This information is not returned by the
_/users/{username}/tokens_ and _/user/keys_ endpoints in the API. This
PR adds the missing data.

The time of last usage for for _tokens_ & _keys_ seem to be stored in
the _Updated_ field of the structs internally. For consistency, I have
used the name _updated_at_ for the new field returned by the _API_.
However, for the _API_ user, I don't think that name reflects the data
returned, as I believe it is the time of last usage. I propose that we
use the name _last_used_at_ instead. Let's hear reviewers opinion on
that.

* PublicKey
  1. _last_used_at_: string($date-time)
* AccessToken
  1. _created_at_: string($date-time) (for parity with public keys)
  2. _last_used_at_: string($date-time)

Fix #34313

Co-authored-by: Tobias Balle-Petersen <[email protected]>
lunny pushed a commit that referenced this pull request May 5, 2025
This PR adds me as a _maintainer_ as suggested by @techknowlogick. 

A couple of my recent PRs:
* #34324
* #34323
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2025
* giteaofficial/main:
  Fix only text/* being viewable in web UI (go-gitea#34374)
  add maintainer tobiasbp (go-gitea#34372)
  [skip ci] Updated translations via Crowdin
  Use lfs label for lfs file rather than a long description (go-gitea#34363)
  Fix bug when API get pull changed files for deleted head repository (go-gitea#34333)
  Fix bug when visiting comparation page (go-gitea#34334)
  Fix LFS files being editable in web UI (go-gitea#34356)
  Bump `@github/relative-time-element` to v4.4.6 (go-gitea#34352)
  Fix repo search input height (go-gitea#34330)
  feat: return time of last usage for public keys and access tokens in the api (go-gitea#34323)
  fix: do not return archive download URLs in API if downloads are disabled (go-gitea#34324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done All backports for this PR have been created backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return time of last usage for SSH public keys and tokens in API
5 participants