-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
fix: do not return archive download URLs in API if downloads are disabled #34324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lunny
merged 1 commit into
go-gitea:main
from
tobiasbp:do-not-return-repo-archive-links-in-api-when-disabled
Apr 30, 2025
Merged
fix: do not return archive download URLs in API if downloads are disabled #34324
lunny
merged 1 commit into
go-gitea:main
from
tobiasbp:do-not-return-repo-archive-links-in-api-when-disabled
Apr 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Apr 30, 2025
lunny
approved these changes
Apr 30, 2025
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 1, 2025
…bled (go-gitea#34324) If archive downloads are are disabled using _DISABLE_DOWNLOAD_SOURCE_ARCHIVES_, archive links are still returned by the API. This PR changes the data returned, so the fields _zipball_url_ and _tarball_url_ are omitted if archive downloads have been disabled. Resolve go-gitea#32159
lunny
pushed a commit
that referenced
this pull request
May 1, 2025
…bled (#34324) (#34338) Backport #34324 by @tobiasbp If archive downloads are are disabled using _DISABLE_DOWNLOAD_SOURCE_ARCHIVES_, archive links are still returned by the API. This PR changes the data returned, so the fields _zipball_url_ and _tarball_url_ are omitted if archive downloads have been disabled. Resolve #32159 Co-authored-by: Tobias Balle-Petersen <[email protected]>
lunny
pushed a commit
that referenced
this pull request
May 5, 2025
This PR adds me as a _maintainer_ as suggested by @techknowlogick. A couple of my recent PRs: * #34324 * #34323
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 6, 2025
* giteaofficial/main: Fix only text/* being viewable in web UI (go-gitea#34374) add maintainer tobiasbp (go-gitea#34372) [skip ci] Updated translations via Crowdin Use lfs label for lfs file rather than a long description (go-gitea#34363) Fix bug when API get pull changed files for deleted head repository (go-gitea#34333) Fix bug when visiting comparation page (go-gitea#34334) Fix LFS files being editable in web UI (go-gitea#34356) Bump `@github/relative-time-element` to v4.4.6 (go-gitea#34352) Fix repo search input height (go-gitea#34330) feat: return time of last usage for public keys and access tokens in the api (go-gitea#34323) fix: do not return archive download URLs in API if downloads are disabled (go-gitea#34324)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/done
All backports for this PR have been created
backport/v1.24
This PR should be backported to Gitea 1.24
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If archive downloads are are disabled using DISABLE_DOWNLOAD_SOURCE_ARCHIVES, archive links are still returned by the API.
This PR changes the data returned, so the fields zipball_url and tarball_url are omitted if archive downloads have been disabled.
Resolve #32159