Skip to content

Fix bug when visiting comparation page #34334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented May 1, 2025

The ci.HeadGitRepo was opened and closed in the function ParseCompareInfo but reused in the function PrepareCompareDiff.

@lunny lunny added type/bug backport/v1.23 This PR should be backported to Gitea 1.23 backport/v1.24 This PR should be backported to Gitea 1.24 labels May 1, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 1, 2025
@wxiaoguang

This comment was marked as resolved.

@lunny
Copy link
Member Author

lunny commented May 1, 2025

You do not need these "defer" tricks anymore, just use our "RequestContext"

Did you mean use RepositoryFromRequestContextOrOpen to open the repository so we don't need the defer?

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2025
@lunny lunny enabled auto-merge (squash) May 4, 2025 18:15
@lunny lunny merged commit 41f3d06 into go-gitea:main May 4, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone May 4, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2025
@lunny lunny deleted the lunny/fix_compare_bug branch May 4, 2025 19:04
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 4, 2025
The `ci.HeadGitRepo` was opened and closed in the function
`ParseCompareInfo` but reused in the function `PrepareCompareDiff`.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 4, 2025
The `ci.HeadGitRepo` was opened and closed in the function
`ParseCompareInfo` but reused in the function `PrepareCompareDiff`.
lunny added a commit that referenced this pull request May 4, 2025
Backport #34334 by @lunny

The `ci.HeadGitRepo` was opened and closed in the function
`ParseCompareInfo` but reused in the function `PrepareCompareDiff`.

---------

Co-authored-by: Lunny Xiao <[email protected]>
lunny added a commit that referenced this pull request May 4, 2025
Backport #34334 by @lunny

The `ci.HeadGitRepo` was opened and closed in the function
`ParseCompareInfo` but reused in the function `PrepareCompareDiff`.

Co-authored-by: Lunny Xiao <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2025
* giteaofficial/main:
  Fix only text/* being viewable in web UI (go-gitea#34374)
  add maintainer tobiasbp (go-gitea#34372)
  [skip ci] Updated translations via Crowdin
  Use lfs label for lfs file rather than a long description (go-gitea#34363)
  Fix bug when API get pull changed files for deleted head repository (go-gitea#34333)
  Fix bug when visiting comparation page (go-gitea#34334)
  Fix LFS files being editable in web UI (go-gitea#34356)
  Bump `@github/relative-time-element` to v4.4.6 (go-gitea#34352)
  Fix repo search input height (go-gitea#34330)
  feat: return time of last usage for public keys and access tokens in the api (go-gitea#34323)
  fix: do not return archive download URLs in API if downloads are disabled (go-gitea#34324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.23 This PR should be backported to Gitea 1.23 backport/v1.24 This PR should be backported to Gitea 1.24 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants