Dict or attr default resolver #638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just found graphql-python/graphql-core#103 which looks related. Not sure where the best place to solve this is? @syrusakbary @jhgg |
|
@syrusakbary I'd appreciate a decision on this PR. If you don't don't want it as part of graphene then I'll close it. |
|
Ping @syrusakbary Any feedback would be welcome |
jkimbo
force-pushed
the
default-resolver
branch
from
759e36e to
f69d221
Compare
|
This looks fine to me. |
ProjectCheshire
approved these changes
Mar 10, 2019
ekampf
approved these changes
Mar 11, 2019
dan98765
pushed a commit
to dan98765/graphene
that referenced
this pull request
Mar 12, 2019
* Add dict_or_attr resolver and set it as default * Add some tests * Dry up code * Updated formatting
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a
dict_or_attr_resolverso that you can pass dicts or objects to object types.I've also set it as the default resolver since I can't think of a downside but let me know if you don't think thats a good idea.