Skip to content

Add dict support for the default resolver #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Add dict support for the default resolver #174

merged 1 commit into from
Mar 12, 2019

Conversation

caseywebdev
Copy link
Contributor

Closes #103 and graphql-python/graphene#638

graphql-js handles this case as expected and now using the python port for work I was surprised to see the default resolver lacked this feature. Using dict literals in resolvers is much more convenient than creating a namedtuple for everything.

@syrusakbary please consider merging this, from the linked issues it seems I'm not alone in this feeling.

@caseywebdev
Copy link
Contributor Author

@syrusakbary ping, I'd love to see this released as it helps simplify resolvers.

@caseywebdev
Copy link
Contributor Author

@syrusakbary ping, is this project still actively maintained? I'll fix the build again but I'd like to know if this PR can be merged. Thanks!

@wojcikstefan
Copy link

@syrusakbary (or anyone on the @graphql-python team) could you please take a look at this PR? Thanks! :)

@Cito
Copy link
Member

Cito commented Nov 27, 2018

Just as a side note, it's implemented in graphql-core-next already.

@anlauren
Copy link

anlauren commented Feb 12, 2019

Any news on that issue @syrusakbary ? It would be quite a time saver

@dan98765
Copy link
Collaborator

@caseywebdev pre-commit is failing because this repo now uses the black formatter. Could you please pull master in your branch, run the hooks on it to reformat it, and put out a new commit? Then it should be good to merge.

@caseywebdev
Copy link
Contributor Author

@dan98765 I fixed the formatting. It seems there's a failing test in master which is why the build is still red.

@dan98765
Copy link
Collaborator

dan98765 commented Mar 12, 2019

@caseywebdev ah you're right. I'll try and fix that real quick, merge it in, make sure your build is happy, then we can merge.
edit actually since I can repro the error and see it has nothing to do with your change let's just go ahead and merge yours in now.

@dan98765 dan98765 merged commit 1760eaf into graphql-python:master Mar 12, 2019
dan98765 pushed a commit to dan98765/graphql-core that referenced this pull request Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants