-
Notifications
You must be signed in to change notification settings - Fork 181
Add dict support for the default resolver #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dict support for the default resolver #174
Conversation
b1f26c1
to
a7ce75e
Compare
@syrusakbary ping, I'd love to see this released as it helps simplify resolvers. |
@syrusakbary ping, is this project still actively maintained? I'll fix the build again but I'd like to know if this PR can be merged. Thanks! |
@syrusakbary (or anyone on the @graphql-python team) could you please take a look at this PR? Thanks! :) |
Just as a side note, it's implemented in graphql-core-next already. |
Any news on that issue @syrusakbary ? It would be quite a time saver |
@caseywebdev pre-commit is failing because this repo now uses the |
@dan98765 I fixed the formatting. It seems there's a failing test in master which is why the build is still red. |
@caseywebdev ah you're right. I'll try and fix that real quick, merge it in, make sure your build is happy, then we can merge. |
Closes #103 and graphql-python/graphene#638
graphql-js
handles this case as expected and now using the python port for work I was surprised to see the default resolver lacked this feature. Using dict literals in resolvers is much more convenient than creating a namedtuple for everything.@syrusakbary please consider merging this, from the linked issues it seems I'm not alone in this feeling.