Default resolve uses dict key if source value is dict #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| property = None | ||
| if hasattr(source, name): | ||
| property = getattr(source, name) | ||
| elif type(source) is dict: |
There was a problem hiding this comment.
You may instead want to use isintance(source, dict) in this conditional to support subclasses of dict.
|
Oh hey @tgriesser 😉 Updated PR at #174 |
syrusakbary
force-pushed
the
master
branch
3 times, most recently
from
b1f26c1 to
a7ce75e
Compare
|
Since graphql-python/graphql-core#174 seems to be the same thing, let's close this PR out and focus on fixing and merging that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source value is a
dictit seemed like this would make sense as the default behavior, and I was actually surprised it wasn't the default. So I figured I'd open it up for discussion, at least to figure out if this was an oversight or if this was intentionally excluded.