Skip to content

Sorted reverse #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2018
Merged

Sorted reverse #102

merged 2 commits into from
Oct 8, 2018
+29 −8

Conversation

alanjds
Copy link

@alanjds alanjds commented Oct 6, 2018

Rebased google#162 over #82

@alanjds alanjds requested review from cclauss and corona10 October 6, 2018 18:02
@alanjds
Copy link
Author

alanjds commented Oct 6, 2018

@MirkoDziadzka: Is this good to merge, in your opinion?

@alanjds alanjds added the waiting feedback Waiting confirmation of changes or fixes label Oct 6, 2018
corona10
corona10 approved these changes Oct 7, 2018
View reviewed changes
Copy link

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanjds alanjds merged commit 75d62da into grumpyhome:master Oct 8, 2018
@alanjds alanjds deleted the sorted-reverse branch October 23, 2018 21:24
@alanjds alanjds removed the waiting feedback Waiting confirmation of changes or fixes label Oct 23, 2018
This was referenced Oct 29, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@cclauss cclauss Awaiting requested review from cclauss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanjds @corona10 @MirkoDziadzka