Fix #82: Implement the 'reverse' option for sorted() #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I could not see any difference from already merged #102 , and I saw its code merged into master ... but this branch has no conflicts... What's happening? Maybe it is because I'm from phone, and web-mobile github version doesn't show me some important details? |
|
You are right. I was cleaning the open branches and found this one. Forgot that the feature was already merged. Sorry and thanks for pointing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the companion PR of #82: Implement the 'reverse' option for sorted()
See comments on #82, if any
Original:
google#162 opened on Jan 18, 2017 by @MirkoDziadzka
Add the 'reverse' option to 'sorted()'
I'm not sure if this violates the 'stable sort definition in Python.
On the other hand, this is probably only relevant when key or cmp gets implemented.