Skip to content

Fix SQL leak [API-1409]#795

Merged
yuce merged 5 commits intohazelcast:masterfrom
yuce:fix-sql-leak
Jun 21, 2022
Merged

Fix SQL leak [API-1409]#795
yuce merged 5 commits intohazelcast:masterfrom
yuce:fix-sql-leak

Conversation

@yuce
Copy link
Copy Markdown
Collaborator

@yuce yuce commented Jun 21, 2022

Fixes #794

Copy link
Copy Markdown
Contributor

@utku-caglayan utku-caglayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

Copy link
Copy Markdown
Contributor

@nevzatseferoglu nevzatseferoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuce yuce merged commit c10fdf4 into hazelcast:master Jun 21, 2022
@yuce yuce deleted the fix-sql-leak branch June 21, 2022 14:45
utku-caglayan pushed a commit to utku-caglayan/hazelcast-go-client that referenced this pull request Jul 5, 2022
* Fixes SQL goroutine leak.

(cherry picked from commit c10fdf4)
utku-caglayan added a commit that referenced this pull request Jul 5, 2022
* Fix all partitions being assigned to one node (#775)

Fix all partitions getting mapped to one node

(cherry picked from commit ec11592)

* Fix go tools version so that it works with go 1.15 (#792)

(cherry picked from commit dc17db9)

* [Backports] Fixes SQL driver test to work with SSL

* Fix SQL leak (#795)

* Fixes SQL goroutine leak.

(cherry picked from commit c10fdf4)

* Fix Failover SSL (#797)

Fixes the connection manager not using failover cluster settings for SSL

(cherry picked from commit 989e683)

* [Backports] Fix uptime gauge [API-1382] (#808)

* Fix Invocation Service group lost handling (#816)

Fixed invocation service's group lost event handling

(cherry picked from commit a5c2607)

* Remove MakeSubscriptionID method (#815)

Removed MakeSubscriptionID method

(cherry picked from commit d5fc815)

* Renamed proto.EntrySizeInBytes and removed dead code (#814)

(cherry picked from commit f06827c)

* add missing API usage (#776)

(cherry picked from commit c5e35ff)

* update client version

* fix for client version test

Co-authored-by: Alex Barkan <aleckz@gmail.com>
Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com>
Co-authored-by: Yüce Tekol <yuce.tekol@hazelcast.com>
@yuce yuce added this to the 1.3.0 milestone Jul 7, 2022
@degerhz degerhz changed the title Fix SQL leak Fix SQL leak [API-1409] Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL Query leaks goroutines if not closed explicitly [API-1409]

3 participants