Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 77.17% 77.22% +0.04%
==========================================
Files 329 329
Lines 15522 15533 +11
==========================================
+ Hits 11979 11995 +16
+ Misses 2701 2698 -3
+ Partials 842 840 -2
Continue to review full report at Codecov.
|
nevzatseferoglu
previously approved these changes
Jun 24, 2022
Contributor
nevzatseferoglu
left a comment
nevzatseferoglu
left a comment
There was a problem hiding this comment.
Thanks, looks good to me!
Collaborator
Author
|
Report coverage test failed with the following log: original log at: https://github.com/hazelcast/hazelcast-go-client/runs/7040780669?check_suite_focus=true Line 780 corresponds to: So the client couldn't connect. I believe this is an RC-related problem. |
utku-caglayan
approved these changes
Jun 24, 2022
nevzatseferoglu
approved these changes
Jun 24, 2022
utku-caglayan
pushed a commit
to utku-caglayan/hazelcast-go-client
that referenced
this pull request
Jul 5, 2022
Fixes the connection manager not using failover cluster settings for SSL (cherry picked from commit 989e683)
utku-caglayan
added a commit
that referenced
this pull request
Jul 5, 2022
* Fix all partitions being assigned to one node (#775) Fix all partitions getting mapped to one node (cherry picked from commit ec11592) * Fix go tools version so that it works with go 1.15 (#792) (cherry picked from commit dc17db9) * [Backports] Fixes SQL driver test to work with SSL * Fix SQL leak (#795) * Fixes SQL goroutine leak. (cherry picked from commit c10fdf4) * Fix Failover SSL (#797) Fixes the connection manager not using failover cluster settings for SSL (cherry picked from commit 989e683) * [Backports] Fix uptime gauge [API-1382] (#808) * Fix Invocation Service group lost handling (#816) Fixed invocation service's group lost event handling (cherry picked from commit a5c2607) * Remove MakeSubscriptionID method (#815) Removed MakeSubscriptionID method (cherry picked from commit d5fc815) * Renamed proto.EntrySizeInBytes and removed dead code (#814) (cherry picked from commit f06827c) * add missing API usage (#776) (cherry picked from commit c5e35ff) * update client version * fix for client version test Co-authored-by: Alex Barkan <aleckz@gmail.com> Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com> Co-authored-by: Yüce Tekol <yuce.tekol@hazelcast.com>
yuce
added a commit
that referenced
this pull request
Dec 26, 2022
Fixes the connection manager not using failover cluster settings for SSL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.