Remove MakeSubscriptionID method#815
Merged
yuce merged 3 commits intohazelcast:masterfrom Jul 5, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #815 +/- ##
==========================================
- Coverage 77.12% 77.12% -0.01%
==========================================
Files 329 328 -1
Lines 15556 15548 -8
==========================================
- Hits 11998 11991 -7
Misses 2711 2711
+ Partials 847 846 -1
Continue to review full report at Codecov.
|
Collaborator
Author
|
@utku-caglayan Discovered bugs in the group lost event handling in the Invocation Service. One of the test tasks events fail because of that. Could you check out #816 before this one? |
srknzl
approved these changes
Jul 5, 2022
utku-caglayan
pushed a commit
to utku-caglayan/hazelcast-go-client
that referenced
this pull request
Jul 5, 2022
Removed MakeSubscriptionID method (cherry picked from commit d5fc815)
utku-caglayan
added a commit
that referenced
this pull request
Jul 5, 2022
* Fix all partitions being assigned to one node (#775) Fix all partitions getting mapped to one node (cherry picked from commit ec11592) * Fix go tools version so that it works with go 1.15 (#792) (cherry picked from commit dc17db9) * [Backports] Fixes SQL driver test to work with SSL * Fix SQL leak (#795) * Fixes SQL goroutine leak. (cherry picked from commit c10fdf4) * Fix Failover SSL (#797) Fixes the connection manager not using failover cluster settings for SSL (cherry picked from commit 989e683) * [Backports] Fix uptime gauge [API-1382] (#808) * Fix Invocation Service group lost handling (#816) Fixed invocation service's group lost event handling (cherry picked from commit a5c2607) * Remove MakeSubscriptionID method (#815) Removed MakeSubscriptionID method (cherry picked from commit d5fc815) * Renamed proto.EntrySizeInBytes and removed dead code (#814) (cherry picked from commit f06827c) * add missing API usage (#776) (cherry picked from commit c5e35ff) * update client version * fix for client version test Co-authored-by: Alex Barkan <aleckz@gmail.com> Co-authored-by: Serkan Özel <serkan.ozel@hazelcast.com> Co-authored-by: Yüce Tekol <yuce.tekol@hazelcast.com>
yuce
added a commit
that referenced
this pull request
Dec 26, 2022
Removed MakeSubscriptionID method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
event.MakeSubscriptionIDmethod from the few places it was used.event.MakeSubscriptionIDreturned an automatic subscription ID based on the function pointer. That kind of usage is problematic with the release of Go 1.17, see: https://go.dev/doc/go1.17#compiler