Add Fast Image Processor for Donut #37081

rootonchair · 2025-03-28T15:26:37Z

What does this PR do?

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline,
Pull Request section?
Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

github-actions · 2025-03-28T15:26:51Z

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

src/transformers/models/donut/image_processing_donut_fast.py

Rocketknight1 · 2025-03-31T13:12:08Z

cc @qubvel @yonigozlan

yonigozlan

Hi @rootonchair, this one also looks great thanks a lot! Only some little changes to be made and tests to be modified. It would also be great to have an equivalence test between fast and slow with do_align_long_axis set to True

src/transformers/models/donut/image_processing_donut_fast.py

tests/models/donut/test_image_processing_donut.py

Co-authored-by: Parteek <[email protected]>

…ransformers into donut_fast_image_processor

rootonchair · 2025-04-01T08:08:55Z

@yonigozlan When adding test for do_align_long_axis, I observe failure cases coming from the slow processor so I have to update its preprocessing to convert all images to rgb and determine rotation axis base on input format, as align_long_axis is using (0,1) as their default rotation axis in np.rot

src/transformers/models/donut/image_processing_donut_fast.py

yonigozlan

Great thanks for fixing the issue with rot_axes! Overall LGTM after the last changes I suggested, and after running make style, make quality and make fix-copies as there are some formatting/styling issues

yonigozlan · 2025-04-07T18:37:22Z

src/transformers/models/donut/image_processing_donut.py

+        if input_data_format == ChannelDimension.LAST:
+            rot_axes = (0, 1)
+        elif input_data_format == ChannelDimension.FIRST:
+            rot_axes = (1, 2)
+        else:
+            raise ValueError(f"Unsupported data format: {input_data_format}")
+


Great, thanks for fixing!

src/transformers/models/donut/image_processing_donut_fast.py

Co-authored-by: Yoni Gozlan <[email protected]>

yonigozlan

Hey @rootonchair! Thanks for iterating , some tests are failing which need some little changes. Also you'll need to merge your branch with main and resolve some conflicts

yonigozlan · 2025-04-11T18:44:34Z

src/transformers/models/nougat/image_processing_nougat.py

+        if input_data_format == ChannelDimension.LAST:
+            rot_axes = (0, 1)
+        elif input_data_format == ChannelDimension.FIRST:
+            rot_axes = (1, 2)
+        else:
+            raise ValueError(f"Unsupported data format: {input_data_format}")
+


Looks like this broke some tests. input_data_format can be None, so if it is, input_data_format should be inferred before this with: input_data_format = infer_channel_dimension_format(images[0]) (it's done after now).
Same for donut in the slow processor.

Ah I see. Let me fix this part. Hope that it would pass this time

…ransformers into donut_fast_image_processor

yonigozlan

Great! Waiting to see if all tests pass then LGTM

HuggingFaceDocBuilderDev · 2025-04-14T14:14:24Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

* add donut fast image processor support * run make style * Update src/transformers/models/donut/image_processing_donut_fast.py Co-authored-by: Parteek <[email protected]> * update test, remove none default values * add do_align_axis = True test, fix bug in slow image processor * run make style * remove np usage * make style * Apply suggestions from code review * Update src/transformers/models/donut/image_processing_donut_fast.py Co-authored-by: Yoni Gozlan <[email protected]> * add size revert in preprocess * make style * fix copies * add test for preprocess with kwargs * make style * handle None input_data_format in align_long_axis --------- Co-authored-by: Parteek <[email protected]> Co-authored-by: Yoni Gozlan <[email protected]>

rootonchair added 2 commits March 28, 2025 22:23

add donut fast image processor support

b74aa2c

run make style

1930152

github-actions bot marked this pull request as draft March 28, 2025 15:26

rootonchair marked this pull request as ready for review March 28, 2025 15:28

github-actions bot requested review from ydshieh and yonigozlan March 28, 2025 15:29

keetrap reviewed Mar 30, 2025

View reviewed changes

src/transformers/models/donut/image_processing_donut_fast.py Show resolved Hide resolved

yonigozlan reviewed Mar 31, 2025

View reviewed changes

src/transformers/models/donut/image_processing_donut_fast.py Outdated Show resolved Hide resolved

tests/models/donut/test_image_processing_donut.py Show resolved Hide resolved

yonigozlan mentioned this pull request Mar 31, 2025

[Contributions Welcome] Add Fast Image Processors #36978

Closed

81 tasks

rootonchair and others added 7 commits April 1, 2025 14:09

Update src/transformers/models/donut/image_processing_donut_fast.py

4f3b18b

Co-authored-by: Parteek <[email protected]>

update test, remove none default values

d38bfd0

Merge branch 'donut_fast_image_processor' of github.com:rootonchair/t…

357bd0e

…ransformers into donut_fast_image_processor

add do_align_axis = True test, fix bug in slow image processor

07ee506

run make style

b14edcb

remove np usage

c58ddb5

make style

22dbfec

rootonchair commented Apr 2, 2025

View reviewed changes

Apply suggestions from code review

fc66a32

yonigozlan reviewed Apr 7, 2025

View reviewed changes

yonigozlan and others added 7 commits April 7, 2025 14:46

Merge branch 'main' into donut_fast_image_processor

d91ae7c

Update src/transformers/models/donut/image_processing_donut_fast.py

0406e55

Co-authored-by: Yoni Gozlan <[email protected]>

add size revert in preprocess

5443306

make style

92d2f64

fix copies

98588ad

add test for preprocess with kwargs

73c901c

make style

6aafa0c

rootonchair requested a review from yonigozlan April 9, 2025 14:28

Merge branch 'main' into donut_fast_image_processor

f2cfc94

yonigozlan reviewed Apr 11, 2025

View reviewed changes

rootonchair added 3 commits April 12, 2025 02:39

handle None input_data_format in align_long_axis

01fc2ff

Merge branch 'main' into donut_fast_image_processor

93bcc22

Merge branch 'donut_fast_image_processor' of github.com:rootonchair/t…

dba0096

…ransformers into donut_fast_image_processor

yonigozlan approved these changes Apr 14, 2025

View reviewed changes

Merge branch 'main' into donut_fast_image_processor

79d9198

yonigozlan merged commit 7cc9e61 into huggingface:main Apr 14, 2025
20 checks passed

rootonchair deleted the donut_fast_image_processor branch April 15, 2025 18:01

Add Fast Image Processor for Donut #37081

Add Fast Image Processor for Donut #37081

Uh oh!

Conversation

rootonchair commented Mar 28, 2025

What does this PR do?

Before submitting

Who can review?

Uh oh!

github-actions bot commented Mar 28, 2025

Uh oh!

Uh oh!

Rocketknight1 commented Mar 31, 2025

Uh oh!

yonigozlan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rootonchair commented Apr 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yonigozlan left a comment

Choose a reason for hiding this comment

Uh oh!

yonigozlan Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yonigozlan left a comment

Choose a reason for hiding this comment

Uh oh!

yonigozlan Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

rootonchair Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

yonigozlan left a comment

Choose a reason for hiding this comment

Uh oh!

HuggingFaceDocBuilderDev commented Apr 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants