Replace the formDialog by a toggle button for CameraSettings#717
Merged
martinRenou merged 5 commits intojupytercad:mainfrom Apr 24, 2025
Conversation
HaudinFlorence
force-pushed
the
replace_the_dialog_form_by_a_toggle_button_for_perspectice_choice
branch
from
0f51a7d to
d6ac54e
Compare
Contributor
|
Preview PR at appsharing.space |
Contributor
|
Integration tests report: appsharing.space |
martinRenou
requested changes
Apr 22, 2025
Member
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Thanks! I have a couple of suggestions
HaudinFlorence
force-pushed
the
replace_the_dialog_form_by_a_toggle_button_for_perspectice_choice
branch
4 times, most recently
from
c0e4654 to
0592963
Compare
… a formDialog. Replace the camera icon by a video camera one.
HaudinFlorence
force-pushed
the
replace_the_dialog_form_by_a_toggle_button_for_perspectice_choice
branch
from
0592963 to
a08e221
Compare
Collaborator
Author
|
@martinRenou Thanks for your comments. They have been taken into account. |
SylvainCorlay
approved these changes
Apr 23, 2025
martinRenou
reviewed
Apr 23, 2025
HaudinFlorence
force-pushed
the
replace_the_dialog_form_by_a_toggle_button_for_perspectice_choice
branch
from
e56f532 to
9977556
Compare
…ter and setter, and update updateCameraSettings command accordingly.
HaudinFlorence
force-pushed
the
replace_the_dialog_form_by_a_toggle_button_for_perspectice_choice
branch
from
9977556 to
d32b25f
Compare
martinRenou
reviewed
Apr 24, 2025
Co-authored-by: martinRenou <martin.renou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify updateCameraSettings command to use a toogle button instead of a formDialog.
Replace the camera icon by a video camera one.