fix: replace xtrim with xdel to support older redis version #8515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
akshay-97
force-pushed
the
fix/xdel-drainer
branch
from
99af0b6 to
867c304
Compare
akshay-97
force-pushed
the
fix/xdel-drainer
branch
from
44ec7c4 to
98221ed
Compare
jarnura
previously approved these changes
Jul 18, 2025
| @@ -10,7 +10,7 @@ license.workspace = true | |||
| default = ["dummy_connector", "frm", "payouts"] | |||
| dummy_connector = [] | |||
| v1 = ["hyperswitch_domain_models/v1", "api_models/v1", "common_utils/v1"] | |||
| v2 = ["api_models/v2", "common_utils/v2", "hyperswitch_domain_models/v2"] | |||
| v2 = ["api_models/v2", "common_utils/v2", "hyperswitch_domain_models/v2", "hyperswitch_domain_models/revenue_recovery", "api_models/revenue_recovery"] | |||
There was a problem hiding this comment.
was checking drainer crate with cargo check --feature v2. removed this
akshay-97
changed the title
hrithikesh026
approved these changes
Jul 21, 2025
2 tasks
jarnura
approved these changes
Jul 22, 2025
2 tasks
pixincreate
added a commit
that referenced
this pull request
Aug 1, 2025
…rver * 'main' of github.com:juspay/hyperswitch: (25 commits) chore: `xof` currency to cybersource cards (#8799) chore(version): 2025.08.01.0 feat(core): Implement UCS based upi for paytm and phonepe (#8732) feat(connector): [katapult]add template code for katapult (#8783) feat(router): introduce `feature` and `feature_data` to gsm (#7771) feat(connector): [cybersource] add changes for field CybersourceConsumerAuthInformation (#8768) feat(authentication): added authentication sync api (#8596) feat(connector): [facilitapay] fix refunds, add webhook and void support (#8778) feat(connector): [payload] add recurring payments (#8597) chore(version): 2025.07.31.0 feat(connector): [Flexiti]Add support for flexiti connector (#8743) chore(router): events enhancement for kafka (#8780) ci(cypress): Making a mandate payment with large customer user agents (#8790) fix(openapi): update create_platform endpoint in api-reference docs (#8782) chore(version): 2025.07.30.0 fix(connector): [GLOBALPAY] Added Tokenization Flow for CITs (#8568) feat(routing): Add api-refs for new decision engine endpoints (#8709) fix: replace xtrim with xdel to support older redis version (#8515) fix(connector): [Worldpay] handle multiple ddc submission for CompleteAuthorize (#8741) feat(connector): [Adyen] receive incoming webhooks for pix expiry (#8720) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added support for xdel if redis client uses legacy version
#8389
Additional Changes
Motivation and Context
How did you test it?
Checked if the code compiled.
Cannot be tested at runtime. without setting up a legacy and non legacy redis versions.
Checklist
cargo +nightly fmt --allcargo clippy