fix(connector): [Worldpay] handle multiple ddc submission for CompleteAuthorize #8741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze flow and handle multiple ddc submission on client side
|
Review changes with Changed Files
|
2 tasks
kashif-m
changed the title
sai-harsha-vardhan
previously approved these changes
Jul 24, 2025
AkshayaFoiger
previously approved these changes
Jul 24, 2025
jagan-jaya
previously approved these changes
Jul 24, 2025
pixincreate
reviewed
Jul 24, 2025
cypress-tests/cypress/e2e/spec/Payment/00030-DDCRaceCondition.cy.js
Outdated
Show resolved
Hide resolved
pixincreate
reviewed
Jul 24, 2025
kashif-m
dismissed stale reviews from jagan-jaya, AkshayaFoiger, and sai-harsha-vardhan
via
e774368
pixincreate
reviewed
Jul 25, 2025
cypress-tests/cypress/e2e/spec/Payment/00030-DDCRaceCondition.cy.js
Outdated
Show resolved
Hide resolved
pixincreate
approved these changes
Jul 28, 2025
| }, | ||
| }, | ||
| }), | ||
| DDCConfig: { |
There was a problem hiding this comment.
nit: these can be imported from commons?
There was a problem hiding this comment.
As per the discussions - the script for DDC is usually very different for different connectors.
Keeping them in Worldpay instead to ensure changing Commons does not affect this connector.
jagan-jaya
approved these changes
Jul 28, 2025
sai-harsha-vardhan
approved these changes
Jul 28, 2025
deepanshu-iiitu
approved these changes
Jul 28, 2025
likhinbopanna
deleted the
8733-bug-worldpay-ddc-submission-race-conditions
branch
pixincreate
added a commit
that referenced
this pull request
Jul 29, 2025
…acilitapay-webhooks * 'main' of github.com:juspay/hyperswitch: fix(connector): [Worldpay] handle multiple ddc submission for CompleteAuthorize (#8741) feat(connector): [Adyen] receive incoming webhooks for pix expiry (#8720) feat(connector): [FISERV] Added GooglePay Payment Method - Connector Decryption Flow (#8658) feat(connector): [BLUECODE] Added Template Code (#8756) chore(version): 2025.07.29.0
pixincreate
added a commit
that referenced
this pull request
Aug 1, 2025
…rver * 'main' of github.com:juspay/hyperswitch: (25 commits) chore: `xof` currency to cybersource cards (#8799) chore(version): 2025.08.01.0 feat(core): Implement UCS based upi for paytm and phonepe (#8732) feat(connector): [katapult]add template code for katapult (#8783) feat(router): introduce `feature` and `feature_data` to gsm (#7771) feat(connector): [cybersource] add changes for field CybersourceConsumerAuthInformation (#8768) feat(authentication): added authentication sync api (#8596) feat(connector): [facilitapay] fix refunds, add webhook and void support (#8778) feat(connector): [payload] add recurring payments (#8597) chore(version): 2025.07.31.0 feat(connector): [Flexiti]Add support for flexiti connector (#8743) chore(router): events enhancement for kafka (#8780) ci(cypress): Making a mandate payment with large customer user agents (#8790) fix(openapi): update create_platform endpoint in api-reference docs (#8782) chore(version): 2025.07.30.0 fix(connector): [GLOBALPAY] Added Tokenization Flow for CITs (#8568) feat(routing): Add api-refs for new decision engine endpoints (#8709) fix: replace xtrim with xdel to support older redis version (#8515) fix(connector): [Worldpay] handle multiple ddc submission for CompleteAuthorize (#8741) feat(connector): [Adyen] receive incoming webhooks for pix expiry (#8720) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fixes race condition in Worldpay 3DS Device Data Collection (DDC) flow causing
bodyDoesNotMatchSchemaerrors.Changes made:
ddcProcessedflag to prevent duplicate submissions on client-sidecollectionReferencesubmissions when payment is inAuthenticationPendingstate@media (max-width: 600px))Additional Changes
Motivation and Context
Race condition caused intermittent 3DS payment failures when DDC took > 8 seconds.
How did you test it?
1. DDC race case in isolation
2. All test cases for Worldpay
Note
Checklist
cargo +nightly fmt --allcargo clippy