fix(connector): [GLOBALPAY] Added Tokenization Flow for CITs #8568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsayak03
changed the title
deepanshu-iiitu
requested changes
Jul 7, 2025
deepanshu-iiitu
previously approved these changes
Jul 7, 2025
deepanshu-iiitu
previously approved these changes
Jul 7, 2025
bsayak03
changed the title
deepanshu-iiitu
previously approved these changes
Jul 7, 2025
Chethan-rao
previously approved these changes
Jul 7, 2025
bsayak03
dismissed stale reviews from Chethan-rao and deepanshu-iiitu
via
3f3ed11
deepanshu-iiitu
previously approved these changes
Jul 9, 2025
bsayak03
added
C-bug
Which typo are you referring to particularly? @pixincreate |
deepanshu-iiitu
previously approved these changes
Jul 11, 2025
|
14 tasks
deepanshu-iiitu
requested changes
Jul 23, 2025
crates/hyperswitch_connectors/src/connectors/globalpay/response.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/globalpay/transformers.rs
Outdated
Show resolved
Hide resolved
Comment on lines
402
to
412
| impl From<GlobalpayPaymentMethodStatus> for common_enums::PaymentMethodStatus { | ||
| fn from(item: GlobalpayPaymentMethodStatus) -> Self { | ||
| match item { | ||
| GlobalpayPaymentMethodStatus::Active => Self::Active, | ||
| GlobalpayPaymentMethodStatus::Inactive | GlobalpayPaymentMethodStatus::Delete => { | ||
| Self::Inactive | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove unused function
crates/hyperswitch_connectors/src/connectors/globalpay/transformers.rs
Outdated
Show resolved
Hide resolved
Comment on lines
603
to
611
| let connector_mandate_request_reference_id = | ||
| item.request.mandate_id.as_ref().and_then(|mandate_ids| { | ||
| match &mandate_ids.mandate_reference_id { | ||
| Some(api_models::payments::MandateReferenceId::ConnectorMandateId( | ||
| connector_mandate_ids, | ||
| )) => connector_mandate_ids.get_connector_mandate_request_reference_id(), | ||
| _ => None, | ||
| } | ||
| }); |
Comment on lines
587
to
592
| type MandateDetails = ( | ||
| Option<Initiator>, | ||
| Option<StoredCredential>, | ||
| Option<String>, | ||
| Option<String>, | ||
| ); |
There was a problem hiding this comment.
No need for the function get_mandate_details
move entire logic to GlobalpayPaymentsRequest try_from
| Some(api_models::payments::MandateReferenceId::ConnectorMandateId( | ||
| connector_mandate_ids, | ||
| )) => connector_mandate_ids.get_connector_mandate_id(), | ||
| _ => None, | ||
| } | ||
| }); | ||
| let connector_mandate_request_reference_id = |
There was a problem hiding this comment.
Test the payment_method_id flow for globalpay mandates.
There was a problem hiding this comment.
Tested, the curls in description working fine.
deepanshu-iiitu
approved these changes
Jul 25, 2025
AnuthaDev
approved these changes
Jul 25, 2025
jagan-jaya
approved these changes
Jul 25, 2025
jarnura
approved these changes
Jul 25, 2025
likhinbopanna
approved these changes
Jul 29, 2025
pixincreate
added a commit
that referenced
this pull request
Aug 1, 2025
…rver * 'main' of github.com:juspay/hyperswitch: (25 commits) chore: `xof` currency to cybersource cards (#8799) chore(version): 2025.08.01.0 feat(core): Implement UCS based upi for paytm and phonepe (#8732) feat(connector): [katapult]add template code for katapult (#8783) feat(router): introduce `feature` and `feature_data` to gsm (#7771) feat(connector): [cybersource] add changes for field CybersourceConsumerAuthInformation (#8768) feat(authentication): added authentication sync api (#8596) feat(connector): [facilitapay] fix refunds, add webhook and void support (#8778) feat(connector): [payload] add recurring payments (#8597) chore(version): 2025.07.31.0 feat(connector): [Flexiti]Add support for flexiti connector (#8743) chore(router): events enhancement for kafka (#8780) ci(cypress): Making a mandate payment with large customer user agents (#8790) fix(openapi): update create_platform endpoint in api-reference docs (#8782) chore(version): 2025.07.30.0 fix(connector): [GLOBALPAY] Added Tokenization Flow for CITs (#8568) feat(routing): Add api-refs for new decision engine endpoints (#8709) fix: replace xtrim with xdel to support older redis version (#8515) fix(connector): [Worldpay] handle multiple ddc submission for CompleteAuthorize (#8741) feat(connector): [Adyen] receive incoming webhooks for pix expiry (#8720) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
In One-off payments, we donot need to create the token. Just passing raw cards would be enough.
In CITs, we need to create a token and store it in
connector_mandate_idfor future MITs but while executing the CIT, raw cards need to be passed.In MITs, we need to use that previously stored token in CIT and no more need to hit the tokenization endpoint at connector.
Additional Changes
Motivation and Context
How did you test it?
cURL:
Response:
mandate_idRequest:
Response:
mandate_idRequest:
Response:
payment_method_idcURL:
Response:
payment_method_idcURL:
Response:
Cypress test
Globalpay
Checklist
cargo +nightly fmt --allcargo clippy