Add back in the session manager feature that was removed as well as fix for issue which caused removal#3628
Conversation
|
Hi @BernardMC. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-vsphere-csi-driver-build |
|
@BernardMC the issue with |
plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return 7aaffd0
chethanv28
left a comment
There was a problem hiding this comment.
Fixes related to login issue post VPXD restart, looks good to me.
/approve
Initiated the pipeline to run sanity e2e tests. Will merge this after the pipeline passes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BernardMC, chethanv28 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Combination of 2 commits which were removed from master (kubernetes-sigs#3628) plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return
Combination of 2 commits which were removed from master (kubernetes-sigs#3628) plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return
Combination of 2 commits which were removed from master (kubernetes-sigs#3628) plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return
Combination of 2 commits which were removed from master (kubernetes-sigs#3628) plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return
Combination of 2 commits which were removed from master (kubernetes-sigs#3628) plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return
Combination of 2 commits which were removed from master (kubernetes-sigs#3628) plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return
What this PR does / why we need it:
Re-adding session manager support that was removed from main due to a bug
Implement session manager client on CSI (#3419)
Refactor tag manager rest client (#3412)
The fix for the bug was to add back in an early return in the vcenter class so that if calls to either
sessionMgr.UserSessionor
vc.RestClient.Sessionwe will fail immediately and try full re authentication flow laterTesting done:
Manually tested the previous issue has been resolved. Test Steps:
Detailed results shared with maintainers
Special notes for your reviewer:
Release note: