Skip to content

Add back in the session manager feature that was removed as well as fix for issue which caused removal#3628

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-3.6from
BernardMC:release-3.6
Oct 7, 2025
Merged

Add back in the session manager feature that was removed as well as fix for issue which caused removal#3628
k8s-ci-robot merged 1 commit into
kubernetes-sigs:release-3.6from
BernardMC:release-3.6

Conversation

@BernardMC
Copy link
Copy Markdown
Contributor

@BernardMC BernardMC commented Sep 30, 2025

What this PR does / why we need it:
Re-adding session manager support that was removed from main due to a bug

Implement session manager client on CSI (#3419)
Refactor tag manager rest client (#3412)

The fix for the bug was to add back in an early return in the vcenter class so that if calls to either sessionMgr.UserSession
or vc.RestClient.Session we will fail immediately and try full re authentication flow later

Testing done:
Manually tested the previous issue has been resolved. Test Steps:

  1. Create Volume
  2. Restart VPXD (login to VC, & run vmon-cli -r vpxd)
  3. Delete the volume (Operation should succeed)
  4. Create a new volume (Operation should succeed)
    Detailed results shared with maintainers
Will run 1 of 1099 specs
Running in parallel across 4 processes
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
• [638.948 seconds]
Improved CSI Idempotency Tests [csi-block-vanilla][csi-file-vanilla][csi-guest][csi-supervisor][pq-vanilla-file][pq-vanilla-block][pq-vks][pq-vks-n1][pq-vks-n2] create volume when VPXD goes down - idempotency [p0, disruptive, block, file, windows, wcp, tkg, vanilla, vc70]
/home/worker/workspace/vanilla-instapp-e2e-pre-checkin/Results/160/vsphere-csi-driver/tests/e2e/improved_csi_idempotency.go:242

  Captured StdOut/StdErr Output >>
  10240Mi
  << Captured StdOut/StdErr Output

  Timeline >>
  STEP: Creating a kubernetes client @ 10/07/25 04:47:57.318
  I1007 04:47:57.318868 100155 util.go:454] >>> kubeConfig: /home/worker/workspace/vanilla-instapp-e2e-pre-checkin/Results/160/gc-kubeconfig.yaml
  STEP: Building a namespace api object, basename idempotency-csi @ 10/07/25 04:47:57.32
  I1007 04:47:57.373500 100155 framework.go:275] Skipping waiting for service account
  I1007 04:47:57.374021 100155 connection.go:72] Creating new VC session
  I1007 04:47:57.580466 100155 improved_csi_idempotency.go:94] VOLUME_OPS_SCALE is set to 5
  STEP: Invoking Test for create volume when vpxd goes down @ 10/07/25 04:47:57.588
  STEP: CNS_TEST: Running for vanilla k8s setup @ 10/07/25 04:47:57.588
  STEP: Creating StorageClass idempotency175981247766 with scParameters: map[StoragePolicyName:Management Storage Policy - Regular] and allowedTopologies: [] and ReclaimPolicy:  and allowVolumeExpansion: false @ 10/07/25 04:47:57.588
  STEP: Creating PVCs using the Storage Class @ 10/07/25 04:47:57.633
  I1007 04:47:57.633851 100155 improved_csi_idempotency.go:533] VOLUME_OPS_SCALE is set to 5
  I1007 04:47:57.633870 100155 improved_csi_idempotency.go:535] Creating pvc0
  STEP: Creating PVC using the Storage Class idempotency175981247766 with disk size  and labels: map[] accessMode: ReadWriteOnce @ 10/07/25 04:47:57.633
  I1007 04:47:57.654378 100155 util.go:908] PVC created: pvc-gh62t in namespace: idempotency-csi-4628
  I1007 04:47:57.654412 100155 improved_csi_idempotency.go:535] Creating pvc1
  STEP: Creating PVC using the Storage Class idempotency175981247766 with disk size  and labels: map[] accessMode: ReadWriteOnce @ 10/07/25 04:47:57.654
  I1007 04:47:57.666643 100155 util.go:908] PVC created: pvc-9tvzr in namespace: idempotency-csi-4628
  I1007 04:47:57.666671 100155 improved_csi_idempotency.go:535] Creating pvc2
  STEP: Creating PVC using the Storage Class idempotency175981247766 with disk size  and labels: map[] accessMode: ReadWriteOnce @ 10/07/25 04:47:57.666
  I1007 04:47:57.677185 100155 util.go:908] PVC created: pvc-g6db7 in namespace: idempotency-csi-4628
  I1007 04:47:57.677218 100155 improved_csi_idempotency.go:535] Creating pvc3
  STEP: Creating PVC using the Storage Class idempotency175981247766 with disk size  and labels: map[] accessMode: ReadWriteOnce @ 10/07/25 04:47:57.677
  I1007 04:47:57.692518 100155 util.go:908] PVC created: pvc-9ftqd in namespace: idempotency-csi-4628
  I1007 04:47:57.692558 100155 improved_csi_idempotency.go:535] Creating pvc4
  STEP: Creating PVC using the Storage Class idempotency175981247766 with disk size  and labels: map[] accessMode: ReadWriteOnce @ 10/07/25 04:47:57.692
  I1007 04:47:57.709764 100155 util.go:908] PVC created: pvc-v4wwx in namespace: idempotency-csi-4628
  STEP: Stopping vpxd on the vCenter host @ 10/07/25 04:47:57.709
  I1007 04:47:57.709830 100155 util.go:1438] Invoking command service-control --stop vpxd on vCenter host 127.0.0.1:48761
  I1007 04:47:59.721919 100155 util.go:1459] Invoking command service-control --status vpxd on vCenter host 127.0.0.1:48761
  I1007 04:48:01.331802 100155 ssh.go:363] ssh root@127.0.0.1:48761: command:   service-control --status vpxd
  I1007 04:48:01.331879 100155 ssh.go:364] ssh root@127.0.0.1:48761: stdout:    "Stopped:\n vpxd\n"
  I1007 04:48:01.331883 100155 ssh.go:365] ssh root@127.0.0.1:48761: stderr:    ""
  I1007 04:48:01.331887 100155 ssh.go:366] ssh root@127.0.0.1:48761: exit code: 0
  I1007 04:48:01.331891 100155 util.go:1468] Found service vpxd in Stopped state
  STEP: Sleeping for 5+1 min for default provisioner timeout @ 10/07/25 04:48:01.331
  STEP: Starting vpxd on the vCenter host @ 10/07/25 04:54:01.332
  I1007 04:54:01.332546 100155 util.go:1438] Invoking command service-control --start vpxd on vCenter host 127.0.0.1:48761
  I1007 04:54:22.221042 100155 util.go:1459] Invoking command service-control --status vpxd on vCenter host 127.0.0.1:48761
  I1007 04:54:23.728933 100155 ssh.go:363] ssh root@127.0.0.1:48761: command:   service-control --status vpxd
  I1007 04:54:23.728976 100155 ssh.go:364] ssh root@127.0.0.1:48761: stdout:    "Running:\n vpxd\n"
  I1007 04:54:23.728980 100155 ssh.go:365] ssh root@127.0.0.1:48761: stderr:    ""
  I1007 04:54:23.728983 100155 ssh.go:366] ssh root@127.0.0.1:48761: exit code: 0
  I1007 04:54:23.728987 100155 util.go:1468] Found service vpxd in Running state
  STEP: Sleeping for full sync interval @ 10/07/25 04:54:23.729
  I1007 04:54:23.729164 100155 connection.go:72] Creating new VC session
  STEP: Waiting for all claims to be in bound state @ 10/07/25 04:54:23.922
  I1007 04:54:23.922139 100155 pv.go:790] Waiting up to timeout=10m0s for PersistentVolumeClaims [pvc-gh62t] to have phase Bound
  I1007 04:54:23.976699 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:25.986532 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:28.003198 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:30.011721 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:32.020485 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:34.028569 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:36.036628 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:38.048993 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:40.057458 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:42.066324 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:44.074515 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:46.082528 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:48.090381 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:50.099024 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:52.107760 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:54.115281 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:56.124379 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:54:58.137013 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:00.151042 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:02.161329 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:04.171106 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:06.179057 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:08.189669 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:10.199764 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:12.213611 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:14.232829 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:16.241793 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:18.251720 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:20.272364 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:22.284164 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:24.300950 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:26.308974 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:28.318303 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:30.327697 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:32.336030 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:34.345122 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:36.354895 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:38.368486 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:40.378025 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:42.388400 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:44.399595 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:46.410715 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:48.420078 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:50.430271 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:52.470004 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:54.478609 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:56.488370 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:55:58.497817 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:00.506874 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:02.521411 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:04.535519 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:06.545359 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:08.556221 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:10.565582 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:12.575433 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:14.584773 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:16.594298 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:18.603991 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:20.613536 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:22.623823 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:24.633288 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:26.643434 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:28.652514 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:30.662236 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:32.674480 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:34.683526 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:36.693323 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:38.701815 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:40.711287 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:42.731665 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:44.742676 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:46.752820 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:48.762228 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:50.771280 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:52.782101 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:54.796202 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:56.805299 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:56:58.815427 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:00.826202 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:02.834659 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:04.844073 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:06.853089 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:08.863282 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:10.873334 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:12.883601 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:14.892403 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:16.902027 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:18.909937 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:20.918075 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:22.927037 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:24.935539 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:26.944078 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:28.952226 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:30.961684 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:32.971135 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:34.979033 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:36.987226 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:38.996453 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:41.005210 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:43.013460 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:45.022746 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:47.031555 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:49.040424 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:51.049940 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:53.058603 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:55.066837 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:57.076015 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:57:59.100191 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:01.116898 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:03.126144 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:05.136013 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:07.144641 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:09.154075 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:11.164330 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:13.174403 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:15.182961 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:17.191165 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:19.198840 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:21.207237 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:23.227059 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:25.236071 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:27.244770 100155 pv.go:806] PersistentVolumeClaim pvc-gh62t found but phase is Pending instead of Bound.
  I1007 04:58:29.264167 100155 pv.go:801] PersistentVolumeClaim pvc-gh62t found and phase=Bound (4m5.341989744s)
  I1007 04:58:29.292817 100155 pv.go:790] Waiting up to timeout=10m0s for PersistentVolumeClaims [pvc-9tvzr] to have phase Bound
  I1007 04:58:29.301683 100155 pv.go:801] PersistentVolumeClaim pvc-9tvzr found and phase=Bound (8.832486ms)
  I1007 04:58:29.322433 100155 pv.go:790] Waiting up to timeout=10m0s for PersistentVolumeClaims [pvc-g6db7] to have phase Bound
  I1007 04:58:29.330224 100155 pv.go:806] PersistentVolumeClaim pvc-g6db7 found but phase is Pending instead of Bound.
  I1007 04:58:31.345517 100155 pv.go:801] PersistentVolumeClaim pvc-g6db7 found and phase=Bound (2.023050589s)
  I1007 04:58:31.359218 100155 pv.go:790] Waiting up to timeout=10m0s for PersistentVolumeClaims [pvc-9ftqd] to have phase Bound
  I1007 04:58:31.406653 100155 pv.go:801] PersistentVolumeClaim pvc-9ftqd found and phase=Bound (47.399484ms)
  I1007 04:58:31.466007 100155 pv.go:790] Waiting up to timeout=10m0s for PersistentVolumeClaims [pvc-v4wwx] to have phase Bound
  I1007 04:58:31.472668 100155 pv.go:801] PersistentVolumeClaim pvc-v4wwx found and phase=Bound (6.623779ms)
  I1007 04:58:31.487148 100155 pv.go:205] Deleting PersistentVolumeClaim "pvc-gh62t"
  I1007 04:58:31.571444 100155 pv.go:205] Deleting PersistentVolumeClaim "pvc-9tvzr"
  I1007 04:58:31.671554 100155 pv.go:205] Deleting PersistentVolumeClaim "pvc-g6db7"
  I1007 04:58:31.774317 100155 pv.go:205] Deleting PersistentVolumeClaim "pvc-9ftqd"
  I1007 04:58:31.871007 100155 pv.go:205] Deleting PersistentVolumeClaim "pvc-v4wwx"
  STEP: Verify PVs, volumes are deleted from CNS @ 10/07/25 04:58:31.973
  I1007 04:58:31.973343 100155 pv.go:863] Waiting up to 5m0s for PersistentVolume pvc-4e72d67d-085f-431d-b3dc-aa9fb9e11f11 to get deleted
  I1007 04:58:31.980991 100155 pv.go:867] PersistentVolume pvc-4e72d67d-085f-431d-b3dc-aa9fb9e11f11 found and phase=Released (7.576743ms)
  I1007 04:58:33.989635 100155 pv.go:871] PersistentVolume pvc-4e72d67d-085f-431d-b3dc-aa9fb9e11f11 was removed
  I1007 04:58:34.018769 100155 vsphere.go:478] volume "b287c379-be46-4fa4-abc3-edabc737b509" has successfully deleted
  I1007 04:58:34.018811 100155 pv.go:863] Waiting up to 5m0s for PersistentVolume pvc-8cd76403-2b5d-438b-bc51-2ca6a1497fe2 to get deleted
  I1007 04:58:34.026658 100155 pv.go:871] PersistentVolume pvc-8cd76403-2b5d-438b-bc51-2ca6a1497fe2 was removed
  I1007 04:58:34.079769 100155 vsphere.go:478] volume "ee86fac1-8f0a-4108-bd58-d21f48877059" has successfully deleted
  I1007 04:58:34.079838 100155 pv.go:863] Waiting up to 5m0s for PersistentVolume pvc-22990d3b-03bd-49e5-a206-57c434f5a296 to get deleted
  I1007 04:58:34.087899 100155 pv.go:867] PersistentVolume pvc-22990d3b-03bd-49e5-a206-57c434f5a296 found and phase=Released (8.042724ms)
  I1007 04:58:36.097714 100155 pv.go:871] PersistentVolume pvc-22990d3b-03bd-49e5-a206-57c434f5a296 was removed
  I1007 04:58:36.115025 100155 vsphere.go:478] volume "28a79310-e427-48b6-b6ce-988dceb35fec" has successfully deleted
  I1007 04:58:36.115072 100155 pv.go:863] Waiting up to 5m0s for PersistentVolume pvc-b6e76552-fef5-4ad1-a461-6ce54ae19f4a to get deleted
  I1007 04:58:36.122880 100155 pv.go:871] PersistentVolume pvc-b6e76552-fef5-4ad1-a461-6ce54ae19f4a was removed
  I1007 04:58:36.139360 100155 vsphere.go:478] volume "d5819d97-f9bf-4b16-a7ba-70bbd5dcc42f" has successfully deleted
  I1007 04:58:36.139416 100155 pv.go:863] Waiting up to 5m0s for PersistentVolume pvc-b9a3b2e6-e3a7-4a7d-8f65-645c92367b3b to get deleted
  I1007 04:58:36.147102 100155 pv.go:871] PersistentVolume pvc-b9a3b2e6-e3a7-4a7d-8f65-645c92367b3b was removed
  I1007 04:58:36.202184 100155 vsphere.go:478] volume "3d6288ed-dfc5-4a1a-a0b7-6729b80a16de" has successfully deleted
  STEP: Resetting provisioner time interval to 300 sec @ 10/07/25 04:58:36.221
  I1007 04:58:36.247681 100155 util.go:1174] Provisioner Timeout value is already set to expected value, hence return
  STEP: Destroying namespace "idempotency-csi-4628" for this suite. @ 10/07/25 04:58:36.249
  << Timeline
------------------------------
SSSSSSSSSSS
------------------------------
[ReportAfterSuite] PASSED [0.069 seconds]
[ReportAfterSuite] Autogenerated ReportAfterSuite for --junit-report
autogenerated by Ginkgo
------------------------------

Ran 1 of 1099 Specs in 639.043 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 1098 Skipped

Special notes for your reviewer:

Release note:

Added support for shared sessions

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 30, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @BernardMC. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 30, 2025
Copy link
Copy Markdown
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2025
@chethanv28 chethanv28 changed the title [WIP] Add back in the session manager feature that was removed as well as fix for issue which caused removal Add back in the session manager feature that was removed as well as fix for issue which caused removal Oct 1, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2025
@chethanv28
Copy link
Copy Markdown
Collaborator

/test pull-vsphere-csi-driver-build

@kolluria
Copy link
Copy Markdown
Contributor

kolluria commented Oct 2, 2025

@BernardMC the issue with build job was fixed in #3614. Please rebase and retry.

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
7aaffd0
Copy link
Copy Markdown
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes related to login issue post VPXD restart, looks good to me.
/approve

Initiated the pipeline to run sanity e2e tests. Will merge this after the pipeline passes.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BernardMC, chethanv28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2025
@chethanv28
Copy link
Copy Markdown
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2b457e8 into kubernetes-sigs:release-3.6 Oct 7, 2025
10 checks passed
BernardMC added a commit to BernardMC/vsphere-csi-driver that referenced this pull request May 5, 2026
Combination of 2 commits which were removed from master (kubernetes-sigs#3628)

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
BernardMC added a commit to BernardMC/vsphere-csi-driver that referenced this pull request May 12, 2026
Combination of 2 commits which were removed from master (kubernetes-sigs#3628)

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
BernardMC added a commit to BernardMC/vsphere-csi-driver that referenced this pull request May 22, 2026
Combination of 2 commits which were removed from master (kubernetes-sigs#3628)

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
BernardMC added a commit to BernardMC/vsphere-csi-driver that referenced this pull request May 22, 2026
Combination of 2 commits which were removed from master (kubernetes-sigs#3628)

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
BernardMC added a commit to BernardMC/vsphere-csi-driver that referenced this pull request May 22, 2026
Combination of 2 commits which were removed from master (kubernetes-sigs#3628)

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
BernardMC added a commit to BernardMC/vsphere-csi-driver that referenced this pull request May 22, 2026
Combination of 2 commits which were removed from master (kubernetes-sigs#3628)

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants