Skip to content

[WIP] Porting this PR which was only merged to release 3.6 branch to master#4031

Open
BernardMC wants to merge 1 commit into
kubernetes-sigs:masterfrom
BernardMC:add-session-manager-to-master
Open

[WIP] Porting this PR which was only merged to release 3.6 branch to master#4031
BernardMC wants to merge 1 commit into
kubernetes-sigs:masterfrom
BernardMC:add-session-manager-to-master

Conversation

@BernardMC
Copy link
Copy Markdown
Contributor

@BernardMC BernardMC commented May 12, 2026

What this PR does / why we need it:
This PR was only merged to 3.6 branch and never made it into master
#3628
As a result the latest 3.7 release does not support the session manager
This PR adds the functionality back to main and can then be merged to the 3.7 release branch

Which issue this PR fixes *
#4019

Testing done:
A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged.
The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc.
For new features, new tests should be done, in addition to regression tests.
If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject.
The review cycle will start, only after "[WIP]" is removed from the PR subject.

Special notes for your reviewer:

Release note:

Adding back in session manager support

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BernardMC
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 12, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @BernardMC. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 12, 2026
@BernardMC BernardMC force-pushed the add-session-manager-to-master branch 3 times, most recently from a762638 to 89ec6f1 Compare May 22, 2026 13:01
Combination of 2 commits which were removed from master (kubernetes-sigs#3628)

plus a fix for the issue which caused removal

Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal

Force re-login of rest session in case of expired session
5041208

Implement session manager client on CSI (kubernetes-sigs#3419)

* Implement session manager client on CSI

* Fix broken unittest
 0ec9586

Add back early return
@BernardMC BernardMC force-pushed the add-session-manager-to-master branch from 89ec6f1 to 04dea57 Compare May 22, 2026 13:46
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants