[WIP] Porting this PR which was only merged to release 3.6 branch to master#4031
[WIP] Porting this PR which was only merged to release 3.6 branch to master#4031BernardMC wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BernardMC The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @BernardMC. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a762638 to
89ec6f1
Compare
Combination of 2 commits which were removed from master (kubernetes-sigs#3628) plus a fix for the issue which caused removal Refactor tag manager rest client (kubernetes-sigs#3412) - Adding back in after removal Force re-login of rest session in case of expired session 5041208 Implement session manager client on CSI (kubernetes-sigs#3419) * Implement session manager client on CSI * Fix broken unittest 0ec9586 Add back early return
89ec6f1 to
04dea57
Compare
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR was only merged to 3.6 branch and never made it into master
#3628
As a result the latest 3.7 release does not support the session manager
This PR adds the functionality back to main and can then be merged to the 3.7 release branch
Which issue this PR fixes *
#4019
Testing done:
A PR must be marked "[WIP]", if no test result is provided. A WIP PR won't be reviewed, nor merged.
The requester can determine a sufficient test, e.g. build for a cosmetic change, E2E test in a predeployed setup, etc.
For new features, new tests should be done, in addition to regression tests.
If jtest is used to trigger precheckin tests, paste the result after jtest completes and remove [WIP] in the PR subject.
The review cycle will start, only after "[WIP]" is removed from the PR subject.
Special notes for your reviewer:
Release note: