Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

#5115 Add ViewModels section to 2.2 dev-guide #5147

Merged
merged 10 commits into from
Aug 26, 2019
Merged

#5115 Add ViewModels section to 2.2 dev-guide #5147

merged 10 commits into from
Aug 26, 2019

Conversation

diazwatson
Copy link
Contributor

@diazwatson diazwatson commented Aug 9, 2019 •
edited by jeff-matthews
Loading

Purpose of this pull request

#5115 This pull request (PR) adds an extra section to the PHP Developer Guide under Component development to explain how to use viewModels.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added a new topic about view models.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@diazwatson
Copy link
Contributor Author

Q. How can I add this new topic to the Component development section?

@osrecio osrecio self-assigned this Aug 9, 2019
@osrecio osrecio added New Topic A major update published as an entirely new document Technical Updates to the code or processes that alter the technical content of the doc and removed Progress: review labels Aug 9, 2019
@diazwatson
Copy link
Contributor Author

diazwatson commented Aug 15, 2019 •
edited
Loading

Hi guys, is there any update on this?

thanks

@diazwatson
Copy link
Contributor Author

Ups 🤦‍♂
Thanks @dobooth

osrecio
osrecio approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@osrecio osrecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From technical part is cool for me! Good job @diazwatson ! 👍

@osrecio
Copy link
Member

osrecio commented Aug 20, 2019

Now is valid for me. @dobooth what do you think?

@jeff-matthews
Copy link
Contributor

Hey @diazwatson & @osrecio, sorry for the delay on this. @dobooth is on holiday. I can help finish processing this for you.

@diazwatson, to add this to the navigation, add an entry to the devdocs/_data/toc/php-developer-guide.yml file.

In the meantime, I'll do an editorial review.

jeff-matthews
jeff-matthews suggested changes Aug 23, 2019
View reviewed changes
@jeff-matthews jeff-matthews added 2.2.x 2.3.x Magento 2.3 related changes and removed Technical Updates to the code or processes that alter the technical content of the doc labels Aug 23, 2019
@jeff-matthews
Copy link
Contributor

@diazwatson, you need to add a symlink to the 2.2 file in the 2.3 directory for this to apply to both versions.

@diazwatson
#5115 editorial changes view models
2e90867
@diazwatson
Merge remote-tracking branch 'upstream/master' into 5115_viewModels
89bd5db 
* upstream/master: (42 commits)
  Update Magento 2.3.0 Open Source release notes (#5267)
  changed "change" to "remove" per Anthony chico
  Small changes (#5264)
  changed column name to ital instead of code
  magento/devdocs#: Fix release notice info about STATIC_CONTENT_THREADS and change info on the appropriate pages (#5263)
  Updated instructions for reviewing cron configuration (#5239)
  Add GSC meta tag (#5258)
  updated code language
  Add GTM tag in order to verify site in GSC (#5254)
  Added note for 404 errors
  MAGEDOC-4061: Added Q3 Commerce releases (#5236)
  Change wording
  Removed legacy Cloud infrastructure info (#5125)
  Removed the unused files
  Fix style violations
  Updated What's New for documentation updates since Aug 9, 2019 (#5212)
  Update debug.md (#5134)
  Link to new marketing PDF from release info page (#5223)
  Debug logging options should match sentence context (#5219)
  Remove spaces inside link text
  ...
@diazwatson
#5115 add symlink to 2.3
b09ed15
@diazwatson
Copy link
Contributor Author

@jeff-matthews thanks for taking the time to process this.
The requested changes are now done, please review and let me know if there is any.

Thanks

keharper
keharper reviewed Aug 24, 2019
View reviewed changes
@diazwatson
Copy link
Contributor Author

@keharper requested changes are added.

jeff-matthews
jeff-matthews approved these changes Aug 26, 2019
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @diazwatson!

@jeff-matthews
Copy link
Contributor

running tests

@jeff-matthews jeff-matthews merged commit 2afa6b4 into magento:master Aug 26, 2019
@ghost
Copy link

ghost commented Aug 26, 2019

Hi @diazwatson, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@osrecio osrecio osrecio approved these changes

@keharper keharper keharper left review comments

@jeff-matthews jeff-matthews jeff-matthews approved these changes

Assignees

@diazwatson diazwatson

@osrecio osrecio

@keharper keharper

@jeff-matthews jeff-matthews

Labels
2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Space 48 partners-contribution PR created by Magento partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@diazwatson @devops-devdocs @osrecio @jeff-matthews @keharper @magento-engcom-team @dobooth