-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixes for #15393 #15687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for #15393 #15687
Conversation
Updated tests
@@ -217,7 +217,7 @@ public function testGetAttributeTextArray() | |||
$expected = [ | |||
'Option 2', | |||
'Option 3', | |||
'Option 4 "!@#$%^&*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to cover more cases with the test. Possibly combinations of plain/html setting for attribue
Hi @simonjanguapa Thank you for contribution. |
|
@ishakhsuvarov It looks like this PR has 3 successful checks. Any idea of when this might get pulled into the project? My team is also looking for this change. Thank you for your help! |
Hi @simonjanguapa. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Issue fix for: #15393