Skip to content

[Forwardport] "Multiple Select" product attributes do not render HTML tags on the storefront view #17808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

nmalevanec
Copy link
Contributor

Original Pull Request

#15687

Issue fix for: #15393

  1. Fixed the check for allowed HTML tags OR wysiwyg for textarea attribute types.
  2. Fix for options so that they can be rendered as HTML as well.

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ishakhsuvarov
Copy link
Contributor

Hi @nmalevanec
Original Pull request seems to include updates to the test which are not part in this port. Could you please make sure that test coverage isn't decreased?

Thanks

@ishakhsuvarov ishakhsuvarov self-assigned this Aug 27, 2018
@nmalevanec nmalevanec changed the title "Multiple Select" product attributes do not render HTML tags on the storefront view [Forwardport] "Multiple Select" product attributes do not render HTML tags on the storefront view Aug 27, 2018
@nmalevanec
Copy link
Contributor Author

@ishakhsuvarov these test changes already exist in 2.3-develop.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2887 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Sep 3, 2018

Hi @nmalevanec , we cannot reproduce this issue on 2.3-develop.

Manual testing scenario:

  1. Create a dropdown / multiselect attribute
  2. One or more of the values contain html tags (test value)
  3. "allow HTML on frontend" and "use in product listing" are set to "Yes"
  4. Add this new attribute to an attribute set
  5. Create a product based on this attribute set and select at least one of the values containing HTML tags
  6. Open Product Page on the frontend.

Result
Attribute option didn't contain HTML tags and is displayed as test value

17808

I'm closing this PR as not relevant.
Thank you for the contribution!

@sidolov sidolov closed this Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants