MCACE-136 - Catalog API call assignProduct does not pass $identifierType...#18
Closed
tim-reynolds wants to merge 1 commit intomagento:masterfrom
Closed
MCACE-136 - Catalog API call assignProduct does not pass $identifierType...#18tim-reynolds wants to merge 1 commit intomagento:masterfrom
tim-reynolds wants to merge 1 commit intomagento:masterfrom
Conversation
…ype to _getProductId Fixed to match MCA-CE rev 153941
Contributor
|
Thank you for locating and fixing the issue! Since the Magento 2 team uses Github repository as a public read-only copy of the development repo only, the fix has been implemented in the internal repo along with the tests for it. So, closing the pull request, the fix will be available on the Github upon the next publication. Please keep in mind, that all pull requests should supply tests for all implemented changes/fixes. |
Closed
magento-team
pushed a commit
that referenced
this pull request
Jan 9, 2015
[GoInc] Bug Fixes & Improve Change Risk Analysis and Predictions Metric
Closed
Closed
Closed
ghost
mentioned this pull request
5 tasks
Closed
5 tasks
5 tasks
5 tasks
This was referenced Feb 17, 2023
5 tasks
5 tasks
Closed
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
ghost
mentioned this pull request
5 tasks
5 tasks
5 tasks
5 tasks
Closed
5 tasks
5 tasks
Closed
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... to _getProductId
Fixed to match MCA-CE rev 153941