Skip to content

[FZ Editor] Move "Duplicate" and "Delete" buttons to the Edit dialog.#9272

Merged
SeraphimaZykova merged 3 commits intomicrosoft:users/niels9001/fz-editorUXoverhaulfrom
SeraphimaZykova:editor/remove_context_menu
Jan 25, 2021
Merged

[FZ Editor] Move "Duplicate" and "Delete" buttons to the Edit dialog.#9272
SeraphimaZykova merged 3 commits intomicrosoft:users/niels9001/fz-editorUXoverhaulfrom
SeraphimaZykova:editor/remove_context_menu

Conversation

@SeraphimaZykova
Copy link
Copy Markdown
Contributor

@SeraphimaZykova SeraphimaZykova commented Jan 25, 2021

Summary of the Pull Request

What is this about:

  • Removed context menu
  • Added "Duplicate" ("Create custom layout" for templates) and "Delete" buttons to the Edit dialog.

image

image

What is include in the PR:

How does someone test / validate:

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@enricogior
Copy link
Copy Markdown
Contributor

enricogior commented Jan 25, 2021

It looks great!

@enricogior
Copy link
Copy Markdown
Contributor

enricogior commented Jan 25, 2021

@SeraphimaZ
I'm wondering if we should make the Create custom layout button wider and rename it to Create custom layout from this template.
But it's not urgent, we can change it later on if we decide so.

image

@niels9001
Copy link
Copy Markdown
Collaborator

niels9001 commented Jan 25, 2021

Nice work @SeraphimaZ !

Minor nit: shouldn't we hide the Name TextBox for templates if it cannot be changed? Now it seems that it could be changed, but some setting is required to do so?

@niels9001
Copy link
Copy Markdown
Collaborator

niels9001 commented Jan 25, 2021

@SeraphimaZ
I'm wondering if we should make the Create custom layout button wider and rename it to Create custom layout from this template.
But it's not urgent, we can change it later on if we decide so.

image

I'd put in a descriptive text under the Create new layout button explaining that this layout will be duplicated. But yeah, we can do that later if needed :).

@enricogior
Copy link
Copy Markdown
Contributor

enricogior commented Jan 25, 2021

@niels9001

shouldn't we hide the Name TextBox for templates if it cannot be changed?

For now let's keep it. We need to focus on getting this in, minor UI polish can be done later.

@enricogior
Copy link
Copy Markdown
Contributor

enricogior commented Jan 25, 2021 •
edited
Loading

@niels9001

I'd put in a descriptive text under the Create new layout button explaining that this layout will be duplicated.

Sounds good, and we can do it later.

@htcfreek
Copy link
Copy Markdown
Collaborator

htcfreek commented Jan 25, 2021

@niels9001

I'd put in a descriptive text under the Create new layout button explaining that this layout will be duplicated.

Sounds good, and we can do it later.

In addition I would optimize the structure/order in the dialogue later to clarify some dependencies (e. g. Enable space and Space value). And to avoid some misunderstanding (E. g. The title in template dialog looks like temporary disabled. I would youse a simple text string.)

@SeraphimaZykova
Copy link
Copy Markdown
Contributor Author

SeraphimaZykova commented Jan 25, 2021

Nice work @SeraphimaZ!

Minor nit: shouldn't we hide the Name TextBox for templates if it cannot be changed? Now it seems that it could be changed, but some setting is required to do so?

Thanks!
I agree with you. Probably it could be worth leaving the layout name in a simple text instead of the TextBox to identify which layout is editing at the moment. :)

@SeraphimaZykova SeraphimaZykova merged commit ef933cc into microsoft:users/niels9001/fz-editorUXoverhaul Jan 25, 2021
@SeraphimaZykova SeraphimaZykova deleted the editor/remove_context_menu branch January 25, 2021 12:41
@htcfreek
Copy link
Copy Markdown
Collaborator

htcfreek commented Jan 25, 2021

@SeraphimaZ
I'm wondering if we should make the Create custom layout button wider and rename it to Create custom layout from this template.
But it's not urgent, we can change it later on if we decide so.

image

I'd put in a descriptive text under the Create new layout button explaining that this layout will be duplicated. But yeah, we can do that later if needed :).

We could change the button later to "Duplicate as custom layout".

@enricogior
Copy link
Copy Markdown
Contributor

enricogior commented Jan 25, 2021

@htcfreek

"Duplicate as custom layout"

It's not a duplication, using that term would cause confusion.

@htcfreek
Copy link
Copy Markdown
Collaborator

htcfreek commented Jan 25, 2021

@htcfreek

"Duplicate as custom layout"

It's not a duplication, using that term would cause confusion.

okay.

SeraphimaZykova added a commit that referenced this pull request Jan 27, 2021
@SeraphimaZykova
[FZ Editor] Move "Duplicate" and "Delete" buttons to the Edit dialog. (…
b3e09e9 
…#9272)
enricogior pushed a commit that referenced this pull request Jan 27, 2021
@SeraphimaZykova @niels9001
[FancyZones Editor] New UX for the FZ editor. (#9325)
646d61b 
* Removed MetroWindow, added theming support and modernWPF

* Rmoved MahApps refs

* Removed MahApps

* Updated canvas zones

* Updated GridEditor

* Fixes

* UI updates

* New layout type selection dialog

* New editor UI

* Updates

* Fix

* UI enhancements

* Updated UI

* Added styles to layoutpreview

* Accesibility improvements

* Accesibility and styling improvements

* Fix

* Cleaned up brushes

* Updated UX

* Updated UI

* Added no layouts description

* Fix

* UI fixes

* [FZ Editor] Serialize/deserialize settings (#8615)

* conflicts fix

* [FZ Editor] Parse json file instead of command line args (#8649)

* [FZ Editor] Serialize/deserialize settings fix (#8707)

* [FZ Editor] Hide unsupported settings in custom layouts flyouts (#8716)

* [FZ Editor] Duplicate custom layouts (#8718)

* [FZ Editor] Duplicate layout behavior (#8720)

* New UX proposal

* Updated spacing

* Switching to toggleswitches

* Revert toggleswitch

* Updated colorbrush

* Updated string for saving label

* Updated UI

* Dark theme color fixes

* Removed space

* [FZ Editor] Bind dialog properties (#9199)

* Resize editor window to fit the content in single-monitor mode (#9203)

* Editor opening fix (#9207)

* Disable "Create" button if the Name textbox is empty (#9212)

* [FZ Editor] Changed edit dialog for template layouts. (#9233)

* [FZ Editor] Small fixes and refactoring. (#9236)

* new layout creation refactoring
* "Save and apply" applies the layout
* number of zones header hide

* [FZ Editor] Empty layout template. (#9237)

* [FZ Editor] Move "Duplicate" and "Delete" buttons to the Edit dialog. (#9272)

* [FZ Editor] Preview the applied layout after editing another layout. (#9278)

* Fixed "Save and apply" button behavior (#9286)

* [FZ Editor] Save template layouts in the settings. (#9283)

* Added default custom layout name (#9291)

* close dialog before opening zones editor (#9302)

* Pressing Esc closes dialogs (#9301)

* [FZ Editor] Reset applied layout to "No layout" if it was deleted. (#9315)

* [FZ Editor] Dark theme colors (#9317)

* "Number of zones" buttons colors. (#9321)

* rebase fix

* added ModernWpf.dll

* address PR comments: updated colors

* added comments, replaced magic numbers

* refactoring

* merge zones crash fix

* removed redundant using directive

Co-authored-by: Niels Laute <niels9001@hotmail.com>
Co-authored-by: Niels Laute <niels.laute@live.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@enricogior enricogior enricogior approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SeraphimaZykova @enricogior @niels9001 @htcfreek