-
Notifications
You must be signed in to change notification settings - Fork 69
no linting in ci #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
no linting in ci #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 23, 2025
Merged
Draft
Draft
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 025f8f8 in 29 seconds. Click for details.
- Reviewed
29
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci.yml:39
- Draft comment:
Temporary disable of ESLint in CI is acceptable, but add a TODO to re-enable when lint issues are resolved. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold70%
None
Workflow ID: wflow_WhMulEoUsGulFd14
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
RLesser
approved these changes
May 23, 2025
This was referenced May 26, 2025
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove requirement for linting in CI, because we don't pass all the lint rules in this repo yet.
Important
Remove linting requirement from CI workflow due to existing lint rule failures.
.github/workflows/ci.yml
.This description was created by
for 025f8f8. You can customize this summary. It will automatically update as commits are pushed.