Skip to content

no linting in ci #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

no linting in ci #194

merged 1 commit into from
May 26, 2025

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented May 23, 2025

Remove requirement for linting in CI, because we don't pass all the lint rules in this repo yet.


Important

Remove linting requirement from CI workflow due to existing lint rule failures.

  • CI Workflow:
    • Commented out the ESLint linting step in .github/workflows/ci.yml.
    • Linting is not required in CI due to existing lint rule failures.
    • TypeScript checking and test execution steps remain active.

This description was created by Ellipsis for 025f8f8. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Collaborator Author

bmschmidt commented May 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bmschmidt bmschmidt mentioned this pull request May 23, 2025
6 tasks
@bmschmidt bmschmidt marked this pull request as ready for review May 23, 2025 18:47
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 025f8f8 in 29 seconds. Click for details.
  • Reviewed 29 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci.yml:39
  • Draft comment:
    Temporary disable of ESLint in CI is acceptable, but add a TODO to re-enable when lint issues are resolved.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 70% None

Workflow ID: wflow_WhMulEoUsGulFd14

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Collaborator Author

bmschmidt commented May 26, 2025

Merge activity

  • May 26, 4:18 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 26, 4:18 PM UTC: @bmschmidt merged this pull request with Graphite.

@bmschmidt bmschmidt merged commit 787011f into main May 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants