Skip to content

Allow resizing deepscatter canvas #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow resizing deepscatter canvas #81

wants to merge 1 commit into from

Conversation

bmschmidt
Copy link
Collaborator

@bmschmidt bmschmidt commented Jun 12, 2023

This PR starts implementing resizing a deepscatter plot by calling plot.resize(width, height).

  • resize all WebGL buffers
  • resize all DOM elements
  • adjust bbox of d3.zoom
  • ensure scale, get_current_corners() understand the new bbox
  • maintain center of viewport on resize, not upper-left.
  • Don't drop background color

Copy link
Collaborator Author

bmschmidt commented May 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

RLesser commented May 23, 2025

Is this ready @bmschmidt ? would be nice to have

@bmschmidt bmschmidt changed the base branch from 05-23-no_linting_in_ci to graphite-base/81 May 26, 2025 16:18
@graphite-app graphite-app bot changed the base branch from graphite-base/81 to main May 26, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants