Skip to content

Make aruco board ids field accessible from python #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2021

Conversation

rogday
Copy link
Member

@rogday rogday commented Jun 11, 2021

Fixing opencv/opencv-python#451.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday changed the base branch from master to 3.4 June 11, 2021 13:11
@alalek
Copy link
Member

alalek commented Jun 11, 2021

BTW, it makes sense to create a simple test for this functionality (use modules/aruco/mics/python/test_aruco.py file, see other modules for reference)

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thank you 👍

@opencv-pushbot opencv-pushbot merged commit 2bef7d7 into opencv:3.4 Jun 19, 2021
@alalek alalek mentioned this pull request Jun 19, 2021
@rogday rogday deleted the aruco_ids_rw branch October 7, 2021 13:21
@alalek alalek mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants