Skip to content

Restore removed code #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Restore removed code #3051

merged 1 commit into from
Oct 4, 2021

Conversation

sturkmen72
Copy link
Contributor

@sturkmen72 sturkmen72 commented Oct 2, 2021 •
edited by alalek
Loading

resolves #2524

relates #2020

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72 sturkmen72 mentioned this pull request Oct 2, 2021
Closed
@sturkmen72 sturkmen72 force-pushed the restore-removed-code branch from dd371a7 to 6d40472 Compare October 3, 2021 09:35
@sturkmen72
Copy link
Contributor Author

note: reverting #2254 needs extra care about changes opencv/opencv#19894 and opencv/opencv#16594 (seems overwhelming me)

alalek
alalek approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit d78296c into opencv:3.4 Oct 4, 2021
@sturkmen72 sturkmen72 deleted the restore-removed-code branch October 4, 2021 17:30
@alalek alalek mentioned this pull request Oct 4, 2021
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels
category: line_descriptor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sturkmen72 @alalek @opencv-pushbot