Skip to content

ximgproc: tolerate the rounding error #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

tomoaki0705
Copy link
Contributor

  • edge drawing is NOT bit-exact

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

On some platforms such as Jetson Nano or Rapsberry Pi 3/4, this test ximgproc_ED.ManySmallCircles fails with following message

[ RUN      ] ximgproc_ED.ManySmallCircles
/opencv_contrib/modules/ximgproc/test/test_fld.cpp:295: Failure
Expected equality of these values:
  lines.size()
    Which is: 6266
  lines_size
    Which is: 6264
[  FAILED  ] ximgproc_ED.ManySmallCircles (486 ms)

This is caused due to the rounding error

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

  * edge drawing is NOT bit-exact
@opencv-pushbot opencv-pushbot merged commit 3ef73fc into opencv:3.4 Oct 11, 2021
@tomoaki0705 tomoaki0705 deleted the fixManySmallCircles branch October 11, 2021 21:12
This was referenced Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants