-
Notifications
You must be signed in to change notification settings - Fork 5.8k
ChArUco pre460 pattern support via switch #3305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChArUco pre460 pattern support via switch #3305
Conversation
c1eb8d1
to
5abd393
Compare
Also fixed issue Function interpolateCornersCharuco misplace corners #3301 |
d7d9013
to
358b432
Compare
Patch updated to resolve latest 4.x development conflicts. @AleksandrPanov, please review. |
1ad7393
to
2d508c2
Compare
2d508c2
to
3bc1090
Compare
@AleksandrPanov , @asmorkalov any feedback on this pull-request? Can you please review, approve, merge? I'd be also sufficiently happy with "false by default". |
Hello, I use post-4.6.0 version of ChaRuCo printed patterns. I noticed that interpolateCornersCharuco misplace corners. The markers are detected correctly but so of the corners as you can see in the attached image are misplaced. This did not happen in version 4.4. When will the fix for this be available? |
@AleksandrPanov Please take a look on the issue with corners. |
I am
Also, here's the image showing the markers being detected correctly. |
@apurvazaveri, although related, this patch will (most likely) not fix this issue. Probably best if you raise a new issue, adding some more details on how to reproduce it, e.g. dictionary and board creation parameters etc. |
Sure, I will do it. |
Fixed in main branch by opencv/opencv#23153 for next OpenCV release 4.8.0. |
Thanks, I will test it and get back to you! |
Support pre- and post-4.6.0 ChaRuCo patterns (even rows) via a "legacy" flag. Default is set to "true" for best backwards compatibility as discussed in #3291.
Patch to opencv_extra has the same branch name.