move aruco from contrib to objdetect in main repository #3325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
5 times, most recently
from
78fe8ac to
1fc06f9
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
3 times, most recently
from
78e66a7 to
b407cf8
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
4 times, most recently
from
ba5a77f to
0bbb7d2
Compare
6 tasks
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
4 times, most recently
from
2da1ee3 to
801229c
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
801229c to
4d96b1f
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
9 times, most recently
from
e477da5 to
f15b0b7
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
3 times, most recently
from
210dd99 to
b1af7a0
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
b1af7a0 to
52c0566
Compare
added 2 commits
November 28, 2022 23:59
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
9cd3be2 to
dddc5d7
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
dddc5d7 to
38b0a77
Compare
asmorkalov
approved these changes
Dec 7, 2022
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
2174e9b to
6001973
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
6001973 to
e28f18c
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
3 times, most recently
from
81753ec to
e9b7e12
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
e9b7e12 to
7b1f751
Compare
AleksandrPanov
force-pushed
the
move_contrib_aruco_to_main_objdetect
branch
from
eb231ea to
ef510ad
Compare
asmorkalov
pushed a commit
to opencv/opencv
that referenced
this pull request
Dec 16, 2022
…ain_objdetect Megre together with opencv/opencv_contrib#3325 1. Move aruco_detector, aruco_board, aruco_dictionary, aruco_utils to objdetect 1.1 add virtual Board::draw(), virtual ~Board() 1.2 move `testCharucoCornersCollinear` to Board classes (and rename to `checkCharucoCornersCollinear`) 1.3 add wrappers to keep the old api working 3. Reduce inludes 4. Fix java tests (add objdetect import) 5. Refactoring ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake ``` **WIP** force_builders=linux,win64,docs,Linux x64 Debug,Custom Xbuild_contrib:Docs=OFF build_image:Custom=ubuntu:22.04 build_worker:Custom=linux-1 ```
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…o_to_main_objdetect Megre together with opencv/opencv_contrib#3325 1. Move aruco_detector, aruco_board, aruco_dictionary, aruco_utils to objdetect 1.1 add virtual Board::draw(), virtual ~Board() 1.2 move `testCharucoCornersCollinear` to Board classes (and rename to `checkCharucoCornersCollinear`) 1.3 add wrappers to keep the old api working 3. Reduce inludes 4. Fix java tests (add objdetect import) 5. Refactoring ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake ``` **WIP** force_builders=linux,win64,docs,Linux x64 Debug,Custom Xbuild_contrib:Docs=OFF build_image:Custom=ubuntu:22.04 build_worker:Custom=linux-1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge with opencv/opencv#22368
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.