Skip to content

Update xfeatures2d.hpp #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Update xfeatures2d.hpp #3357

merged 2 commits into from
Sep 23, 2022

Conversation

berak
Copy link
Contributor

@berak berak commented Sep 16, 2022

add missing CV_WRAP to MSDDetector::create()

resolves: #3356

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Contributor

Could you add small python test that detector is created correctly and minimally functional (returns non-zero features or something like this).

@asmorkalov asmorkalov self-requested a review September 20, 2022 13:33
@asmorkalov asmorkalov self-assigned this Sep 20, 2022
@asmorkalov asmorkalov merged commit 18b98a5 into opencv:3.4 Sep 23, 2022
@berak berak deleted the patch-2 branch September 23, 2022 12:08
@alalek alalek mentioned this pull request Oct 15, 2022
@alalek alalek mentioned this pull request Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants