Skip to content

node:http: take the Connection and Upgrade dispatch bits from llhttp's grammar - #43327

Closed
robobun wants to merge 5 commits into
mainfrom
robobun/b211d620/node-http-upgrade-dispatch
Closed

robobun wants to merge 5 commits into
mainfrom
robobun/b211d620/node-http-upgrade-dispatch

Conversation

@robobun

@robobun robobun commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • node:http emits 'upgrade' for requests that Node does not treat as upgrades: an empty Upgrade value, Connection: upgrade-x, Connection: foo upgrade. Node dispatches those to 'request' with req.upgrade === false. For the same reason Connection: close-x closes the connection in Bun and not in Node.
  • The cause is assignHeadersFromUWebSocketsForCall in src/jsc/bindings/NodeHTTP.cpp. It sets kDispatchHasUpgrade for any Upgrade field, also an empty one. It sets kDispatchConnUpgrade and kDispatchConnClose with svValueHasToken, a \W boundary scan that matches upgrade inside upgrade-x.

Fix

  • HttpRequest::hasConnectionClose() in packages/bun-uws/src/HttpParser.h becomes hasConnectionToken(item). It splits the list on ,, ignores OWS around each item, and compares the whole item. hasConnectionClose() calls it with close.
  • NodeHTTP.cpp takes kDispatchConnClose and kDispatchConnUpgrade from that walk, and sets kDispatchHasUpgrade only for a non-empty value. svValueHasToken stays for Expect: 100-continue, where Node uses a regex.
  • This is llhttp's grammar. F_UPGRADE needs a non-whitespace Upgrade value. F_CONNECTION_UPGRADE and F_CONNECTION_CLOSE need the word as a whole list item, with SP or HTAB around it (llhttp >= 9.4.2, fix: Correctly handle tab after connection-close header value. nodejs/llhttp#866).
  • Verified: two new tests in test/js/node/http/node-http.test.ts (14 raw-socket cases, stock bun fails 8). Also the rest of that file and request-smuggling.test.ts.

Background

  • node:http builds a dispatch bitfield per request in C++ and _http_server.ts reads it. 'upgrade' fires only when both DISPATCH_HAS_UPGRADE and DISPATCH_CONN_UPGRADE are set. DISPATCH_CONN_CLOSE decides res.shouldKeepAlive.
  • Node gets these verdicts from llhttp flags, not from the JS layer. The \W regexes in Node's JS only apply to Expect and to outgoing headers.
  • The uWS parser already has the item walk for its own keep-alive decision. node:http now uses the same walk, so the parser and the JS layer agree on Connection: close.
Notes
  • The Connection grammar in llhttp 9.4.1 allowed only SP after an item, so Connection: Upgrade<HTAB> was not an upgrade. llhttp 9.4.2 (fix: Correctly handle tab after connection-close header value. nodejs/llhttp#866, a HackerOne report) allows HTAB too. Node's deps/llhttp is at 9.4.3. The tests pin the 9.4.2 grammar. The non-HTAB rows are verified against Node v26.3.0 (llhttp 9.4.1), where the two grammars agree.
  • Self-reviewed: the first cut derived only the upgrade verdict, from the raw value in getHeaders, to see the HTAB that the parser trims. The review found the 9.4.2 change (which makes the trimmed value enough) and that close stayed on the \W scan. This cut fixes both bits with the existing walk.
  • The issue's repro script, under this branch, prints the same five lines as Node.
  • Suites run: test/js/node/http/node-http.test.ts (165 pass), test/js/bun/http/request-smuggling.test.ts, test/js/node/http/node-http-connect.test.ts (one 5 s timeout on a subprocess test that takes 5.4 s under the debug build here, same on main).

[human-review] gate passed · iteration 0 · 3 files touched

fails on main (without fix)
ASAN without fix: 2 failed, 1 skipped
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/http/node-http.test.ts
bun test v1.4.3 (b52d51348)

test/js/node/http/node-http.test.ts:
(pass) node:http > createServer > hello world [780.10ms]
(pass) node:http > createServer > is not marked encrypted (#5867) [117.49ms]
(pass) node:http > createServer > request & response body streaming (large) [208.22ms]
(pass) node:http > createServer > request & response body streaming (small) [115.77ms]
(pass) node:http > createServer > listen should return server [25.65ms]
(pass) node:http > createServer > listen callback should be bound to server [55.92ms]
(pass) node:http > createServer > emits 'listening' on the next tick, before the event loop polls [46.86ms]
(pass) node:http > createServer > emits a listen() error on the next tick, before the event loop polls [45.95ms]
(pass) node:http > createServer > calls the listen() callback after a retry from the EADDRINUSE 'error' handler [56.87ms]
(pass) node:http > createServer > http: closing a server listened from 'beforeExit' > re-emits 'beforeExit' [1991.57ms]
(pass) node:http > cr
... (truncated)

release without fix: 1 skipped
bun test v1.4.3-canary.1 (a04c7b6a6)

test/js/node/http/node-http.test.ts:
(pass) node:http > createServer > hello world [12.12ms]
(pass) node:http > createServer > is not marked encrypted (#5867) [2.58ms]
(pass) node:http > createServer > request & response body streaming (large) [3.70ms]
(pass) node:http > createServer > request & response body streaming (small) [1.69ms]
(pass) node:http > createServer > listen should return server [1.30ms]
(pass) node:http > createServer > listen callback should be bound to server [1.59ms]
(pass) node:http > createServer > emits 'listening' on the next tick, before the event loop polls [2.35ms]
(pass) node:http > createServer > emits a listen() error on the next tick, before the event loop polls [1.81ms]
(pass) node:http > createServer > calls the listen() callback after a retry from the EADDRINUSE 'error' handler [3.71ms]
(pass) node:http > createServer > http: closing a server listened from 'beforeExit' > re-emits 'beforeExit' [20.63ms]
(pass) node:http > createServer > https: closing a server listened from 'beforeExit' > re-emits 'beforeExit' [31.31ms]
(pass) node:http > createServer > should use the provided port [1.68ms]
(pa
... (truncated)
passes on PR (with fix)
ASAN with fix: 1 skipped
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/http/node-http.test.ts
bun test v1.4.3 (b52d51348)

test/js/node/http/node-http.test.ts:
(pass) node:http > createServer > hello world [437.27ms]
(pass) node:http > createServer > is not marked encrypted (#5867) [75.79ms]
(pass) node:http > createServer > request & response body streaming (large) [104.43ms]
(pass) node:http > createServer > request & response body streaming (small) [65.95ms]
(pass) node:http > createServer > listen should return server [20.92ms]
(pass) node:http > createServer > listen callback should be bound to server [22.96ms]
(pass) node:http > createServer > emits 'listening' on the next tick, before the event loop polls [37.15ms]
(pass) node:http > createServer > emits a listen() error on the next tick, before the event loop polls [41.77ms]
(pass) node:http > createServer > calls the listen() callback after a retry from the EADDRINUSE 'error' handler [43.90ms]
(pass) node:http > createServer > http: closing a server listened from 'beforeExit' > re-emits 'beforeExit' [2001.21ms]
(pass) node:http > crea
... (truncated)

release with fix: 1 skipped
$ bun scripts/build.ts --profile=release
[configured] bun-profile → bun (stripped) in 1050ms (unchanged)
ninja: Entering directory `/workspace/bun/build/release'
[1/15] cxx obj/unified/UnifiedSource-src_uws_sys-0.cpp.o
[2/15] cxx obj/unified/UnifiedSource-src_jsc_bindings_node-0.cpp.o
[3/15] cxx obj/unified/UnifiedSource-src_jsc_bindings-1.cpp.o
[4/15] cxx obj/src/jsc/bindings/bindings.cpp.o
[5/15] cxx obj/unified/UnifiedSource-src_jsc_bindings-4.cpp.o
[6/15] cxx obj/unified/UnifiedSource-src_jsc_bindings-0.cpp.o
[7/15] cxx obj/unified/UnifiedSource-src_jsc_bindings-5.cpp.o
[8/15] cxx obj/unified/UnifiedSource-src_jsc_bindings-3.cpp.o
[9/15] gen cpp.rs (cppbind)
[10/14] link bun-profile
ld.lld: warning: Linking two modules of different target triples: 'obj/unified/UnifiedSource-src_jsc_bindings-0.cpp.o' is 'x86_64-pc-linux-gnu' whereas '../../../../root/.bun/build-cache/webkit-000c48997255272c-lto/lib/libJavaScriptCore.a(Parser.cpp.o at 128806534)' is 'x86_64-unknown-linux-gnu'


ld.lld: warning: Linking two modules of different target triples: 'obj/vendor/mimalloc/src/static.c.o' is 'x86_64-pc-linux-gnu' whereas '../../../../root/.bun/build-cache/webkit-000c48997
... (truncated)
diff hotspot
packages/bun-uws/src/HttpParser.h   |  12 ++++-
 src/jsc/bindings/NodeHTTP.cpp       |  22 ++++----
 test/js/node/http/node-http.test.ts | 104 ++++++++++++++++++++++++++++++++++++
 3 files changed, 124 insertions(+), 14 deletions(-)

gate history · 2 passed · 0 rejected · iteration 0

evidence per changed file
file                                 reads  edits  tests
packages/bun-uws/src/HttpParser.h        6      6     13
src/jsc/bindings/NodeHTTP.cpp            4     11     13
test/js/node/http/node-http.test.ts      3      5     13

root cause · written by the author bot

The 'upgrade' event fired spuriously because the native dispatcher in NodeHTTP.cpp set the upgrade bits on its own loose criteria: any Upgrade field, even with an empty value, and a Connection value matched by a \W-boundary substring search that accepted "upgrade" inside items like "upgrade-x" or "foo upgrade", while the header parser had already trimmed the trailing tab that makes llhttp ignore the token. The fix moves both verdicts to the uWS parser's whole-item Connection walk (hasConnectionClose and a new hasConnectionToken), so "upgrade" and "close" count only as complete list items, a…

…s grammar

'upgrade' fired for any request with an Upgrade header and a Connection
value that contained the word upgrade at a \W boundary, and Connection:
close-x closed the connection. llhttp sets F_UPGRADE only for a non-empty
Upgrade value, and F_CONNECTION_UPGRADE / F_CONNECTION_CLOSE only when the
word is a whole item of the Connection list.

The parser's Connection list walk (hasConnectionClose) now takes the item
as a parameter, and NodeHTTP.cpp reads both Connection bits from it. The
\W scan stays for Expect: 100-continue, where Node uses a regex.

Fixes #43297
@coderabbitai

coderabbitai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Essentials

Run ID: 7889adb3-3496-40f8-bf44-0d415b332229

📥 Commits

Reviewing files that changed from the base of the PR and between a04c7b6 and 00015f7.

📒 Files selected for processing (1)
  • test/js/node/http/node-http.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

The change centralizes complete Connection token matching, uses it for Node HTTP close and upgrade dispatch, requires non-empty Upgrade values, and adds regression coverage for valid and malformed header values.

Changes

Connection dispatch handling

Layer / File(s) Summary
Connection token matching
packages/bun-uws/src/HttpParser.h
HttpRequest adds hasConnectionToken for case-insensitive, comma-separated token matching. hasConnectionClose delegates to this helper.
Dispatch decisions and coverage
src/jsc/bindings/NodeHTTP.cpp, test/js/node/http/node-http.test.ts
Node HTTP derives close and upgrade dispatch bits from request-level parsing. Upgrade dispatch requires a non-empty Upgrade value. Tests cover whitespace, complete tokens, partial tokens, malformed lists, and connection reuse.

Suggested reviewers: cirospaciari

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 00015

The changed HTTP token parsing and dispatch behavior has no identified merge-blocking regression.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: deriving node:http Connection and Upgrade dispatch bits from llhttp-compatible parsing logic.
Description check ✅ Passed The description explains the problem, fix, behavior changes, affected components, and verification results. It does not use the exact template headings, but it provides the required information and is…

Comment @coderabbitai help to get the list of available commands.

Comment thread src/jsc/bindings/NodeHTTP.cpp Resolved
Comment thread src/jsc/bindings/NodeHTTP.cpp Resolved
@robobun

robobun commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 11:39 AM PT - Sep 18th, 2026

✅ @autofix-ci[bot], your commit 00015f7bcd48366eb743a51b0594c3d38e92bb35 passed in Build #117845! 🎉


🧪   To try this PR locally:

bunx bun-pr 43327

That installs a local version of the PR into your bun-43327 executable, so you can run:

bun-43327 --bun

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Additional findings (outside the current diff — GitHub can't attach inline comments there):

  • 🟣 packages/bun-uws/src/HttpParser.h — HTTP/1.0 clients that send Connection: keep-alive get their connection closed after each response on Bun, where Node keeps it open. HttpParser.h:1226 sets sawConnectionClose for every ancient request regardless of the Connection value, and _http_server.ts:726 forces kReqShouldKeepAlive to false when isAncientHTTP. llhttp_should_keep_alive keeps an HTTP/1.0 connection alive when F_CONNECTION_KEEP_ALIVE is set. Fix: for node:http, keep an HTTP/1.0 connection open when hasConnectionToken("keep-alive") is true, using the same walk this PR added, at both the parser and the JS keep-alive sites.

    Extended reasoning...

    This is pre-existing on the base (both lines untouched by the diff), but the PR's stated goal is to take the Connection verdicts from llhttp's flags and the new helper makes the fix a one-liner, so it is the same class the PR claims to have finished. Trigger: a load balancer health check, ab, or an old proxy sends GET / HTTP/1.0 with Connection: keep-alive (llhttp sets F_CONNECTION_KEEP_ALIVE via header_value_connection_2, llhttp.c:2426-2448). Bun: getHeaders marks ancientHttp, HttpParser.h:1226 sets sawConnectionClose, the response is sent and the socket closed; _http_server.ts:714-726 sets kReqShouldKeepAlive false so the response also carries Connection: close. Node: should_keep_alive returns true for 1.0 with the keep-alive flag and the socket stays open for the next request. Consequence: each such client reconnects per request (extra TCP and TLS handshakes), and tools that require keep-alive on HTTP/1.0 report the server as not supporting it. Population: HTTP/1.0 clients that opt into keep-alive, on every request. Remedy: gate the ancient close on !hasConnectionToken("keep-alive")…

    Verification: pre-existing. Triggered when an HTTP/1.0 client sends Connection: keep-alive and the node:http handler answers with a Content-Length-framed response (e.g. Express res.send, ab -k): Bun closes the socket after every response while Node keeps it open. Mechanism verified in this checkout, both lines untouched by the diff: - /home/claude/bun/packages/bun-uws/src/HttpParser.h:1226 `if…

  • 🟣 packages/bun-uws/src/HttpParser.h — Servers that opt into insecureHTTPParser get a connection closed, or a raw socket handed to 'upgrade', for Connection values llhttp never flags. The item walk at HttpParser.h:320 splits on ',' and ignores what the bytes are, so Connection: \x01, close sets the close bit and Connection: \x01, upgrade sets the upgrade bit. llhttp drops into header_value_lenient at the control byte and never returns to the Connection grammar, so neither flag is set in Node. Fix: stop the walk (no further items) once a byte outside the token/OWS set is seen, matching header_value_connection_token's lookup table, for both the close and upgrade verdicts.

    Extended reasoning...

    The dismissing finder only considered the close bit and called it one extra close. The upgrade bit is the larger consequence. A server created with insecureHTTPParser: true accepts control bytes in field values (HttpParser.h:1063-1066). A client sends Upgrade: x and Connection: \x01, upgrade. hasConnectionToken at :315-333 reads item "\x01" (no match), advances past ',', reads item "upgrade", returns true. NodeHTTP.cpp:114 sets kDispatchConnUpgrade and :152 sets kDispatchHasUpgrade; _http_server.ts:879-882 then :965-977 emits 'upgrade' and hands the socket over, so the request never reaches the 'request' handler. In llhttp.c:2339-2374 the token state's lookup table maps 0x01 to 0, which goes to header_value_otherwise (:2321) and, under lenient flags, to header_value_lenient (:2293-2310), which consumes to CR/LF and never re-enters header_value_connection; F_CONNECTION_UPGRADE stays clear and Node dispatches 'request'. Same shape for close: Bun closes after the response (kDispatchConnClose, _http_server.ts:726) while Node keeps the connection alive. Population: any node:http server…

    Verification: pre-existing — triggers only when the server opts into lenient headers (insecureHTTPParser: true or httpValidation: 'relaxed'/'insecure', mapped to LENIENT_HEADERS bit 0 in /home/claude/bun/src/js/node/_http_server.ts:1094-1097) and a client sends a control byte before the token in a Connection list item. Mechanism verified. /home/claude/bun/packages/bun-uws/src/HttpParser.h:1061-1066…

Comment thread test/js/node/http/node-http.test.ts Resolved
@robobun

robobun commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

On the two findings outside the diff: both are pre-existing and stay out of this PR.

  • HTTP/1.0 with Connection: keep-alive: the close decision for HTTP/1.0 lives in the shared parser (HttpParser.h, the isAncient() branch) and in _http_server.ts, and it also covers Bun.serve. A change there is a separate keep-alive behaviour change for a different population. It needs its own test coverage and its own PR.
  • A control byte in a Connection list item under insecureHTTPParser: the old \W scan gave the same answer for \x01, upgrade, so this PR does not change that case. Matching llhttp's lenient fallback there is a separate, narrow change.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

The keep-alive test now rejects on an early close/error (7bf845b), which resolves the earlier nit. Beyond the inline findings, I also checked two things the new bits depend on and they hold: the !value.empty() guard for kDispatchHasUpgrade sees a value the parser has already OWS-trimmed (packages/bun-uws/src/HttpParser.h:1095-1103), so Upgrade: \t correctly reads as empty; and the bf.mightHave("connection") pre-check in hasConnectionToken hashes lowercased bytes (BloomFilter.h:41-54), so wire-cased Connection is never skipped.

Extended reasoning...

This run's inline findings cover the parts of llhttp's Connection grammar the shared walk still misses (Proxy-Connection aliasing and the JS HTTP/1 fallback path), both pre-existing. Separately I verified the two assumptions the diff's new bits rely on: uWS trims SP/HTAB from both ends of each header value before storing it, so the value.empty() check matches llhttp's non-whitespace F_UPGRADE requirement for the whitespace-only case in the new test; and the bloom filter's add/mightHave lowercase the sampled bytes, so the pre-check cannot skip a Connection header in wire casing. I also confirmed the second test's waiter reassignment is safe because the error/close handlers close over the let binding, and that the prior review's nit about unwired failure paths was addressed by the latest commit.

Comment thread src/jsc/bindings/NodeHTTP.cpp Resolved
Comment thread src/jsc/bindings/NodeHTTP.cpp Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

Jarred-Sumner added a commit that referenced this pull request Sep 26, 2026
…inish, lifecycle) (#43557)

One pull request for the open `node:http` server pull requests. Each
root cause is fixed once, and each pull request's tests are carried
over. Node is the reference: every scenario was run under Node and under
Bun from one script, and the outputs were compared.

Fixes #4733
Fixes #18613
Fixes #40350
Fixes #43155
Fixes #43297
Fixes #43513
Fixes #43527
Fixes #25632
Fixes #31301
Fixes #43027
Fixes #43163
Fixes #43342
Fixes #43344
Fixes #43370
Fixes #43490
Fixes #43512
Fixes #43519

Each of these has a repro that is wrong on Bun 1.4.3, right on this
branch, and the same as Node.

| Issue | Not closed by this PR, because |
| --- | --- |
| #30501 (msal-node keeps Bun alive at exit) | Probably fixed. The repro
copies the teardown of msal-node. The package itself was not run. |
| #14430 (yarn: "does not support SSL") | Probably fixed.
`response.hasOwnProperty("socket")` is now `true`. yarn itself was not
run. |
| #39681 (`server.setTimeout` callback after destroy) | Probably fixed.
The repro is the deterministic case of #39686. The script in the issue
depends on timing and on Windows. |
| #43455 (`req.complete`, nine flows) | Partially addressed. Flows 1, 2,
3, 5 and 7 are fixed, and flow 6 was already right. Flow 8 (a socket
timeout while the body of an Upgrade request arrives) and flow 9 (a
request that `stream.pipeline()` destroyed never reports `complete`) are
not. Flow 4 differs only in `_readableState.ended`. |

### What changes for users

| Area | Before | After (same as Node) |
| --- | --- | --- |
| `req.pause()` | The socket stops at once. `req.complete` stays `false`
for a small body. | The body is received until the buffer is full. Then
the socket stops. |
| `res.end()` before the body arrives | `req` gets `'end'` and `'close'`
at once, and the body is lost | The request completes when its body
really ends |
| `res.destroy()` in the middle of a body | `'end'` with bytes missing |
`aborted`, then `ECONNRESET` |
| `socket.destroy()` inside the `'request'` listener | The body that
came with the head is dropped | That body is still delivered |
| `'finish'` and the `end()` callback | Fire when `end()` buffers the
bytes | Fire when the last bytes have left the socket |
| A response that closes the connection | The server half-closes and
waits for the peer | The socket closes right behind the FIN |
| `'drain'` after a later write flushed the backlog | Lost. `pipe(res)`
could hang. | Emitted |
| A pipelined request whose body continues after the previous response
ends | Body dropped, no response, `server.close()` hangs | Delivered |
| CONNECT and Upgrade tunnel sockets | Keep reading when paused or full
| Stop reading. `_read()` starts them again. |
| A tunnel write that waits for a drain when the client goes away | Its
callback, the callbacks of the writes behind it and the `end()` callback
never run | They run with an error before `'close'` |
| Upgrade request with a body, paused in its listener | The body flows
away | The request keeps its body |
| `ws` on a reused keep-alive socket | Writes after the Upgrade could
stall | Sent |
| A raw `socket.write()` behind a response that still drains (the 400
for a bad pipelined request, the reply of a `'clientError'` listener) |
Lands in the middle of that response | Sent after it |
| `server.close()` | Could report closed while connections were open |
Waits for every connection. An idle tunnel does not keep the process
alive. |
| `closeAllConnections()` on a listening server | Also stops the
listener and destroys tunnels and WebSockets | Destroys only the HTTP
connections |
| `Proxy-Connection: close` (node:http only) | Ignored. The connection
stays open. | Ends the connection, like `Connection: close` |
| A response larger than 16 KB, also in `Bun.serve` and over TLS | Up to
4 `send()` calls for each chunk. Slower than Node in most cases. | One
write for the writes of one tick. 1.1x to 2.7x the requests per second
of main, and faster than Node. |
| `socket.destroy()` and then `res.end()` in a listener | (this PR,
earlier) `req` ended as if it were complete | `'aborted'`, then
`ECONNRESET` |
| `emit('connection')` or http2 `allowHTTP1`: the response ends while
the listener still reads the body | The rest of the body is dropped |
The body is complete |
| `httpValidation: "relaxed"`, `Content-Length` or `Transfer-Encoding`
in trailers | Accepted | `HPE_INVALID_CONTENT_LENGTH`,
`HPE_INVALID_TRANSFER_ENCODING` |
| `req.complete` inside `'connect'`, and inside `'upgrade'` without a
body | `false` | `true` |
| `optimizeEmptyRequests`: `socket.parser.incoming` after the response |
Keeps the request alive on an idle connection | `null` |
| A HEAD or OPTIONS request with `Content-Length` | The body is dropped,
and `req.complete` is `true` before it comes | The request has its body
|
| `res.end(chunk)` after the client went away | `finished` and
`writableEnded` stay `false`, no `'prefinish'` | The response ends |
| An HTTP/1.0 request with an `Expect` header | `100 Continue`,
`'checkContinue'`, `'checkExpectation'` or a 417 | A plain `'request'` |
| The idle sweep of `close()` and `closeIdleConnections()` | Could
destroy a connection that was still receiving a request, or whose
response was still draining | Closes only idle connections |

### Design

| Piece | What it is |
| --- | --- |
| Request body state | `None / Pending / Complete / Aborted / Upgraded /
Detached`. Only the last chunk sets `Complete`. One function,
`leave_pending`, is the only other way out of `Pending`. |
| Read flow control | One path: `push()` returning false stops the
socket, `_read()` starts it. Both native pause buffers are removed: no
read is copied and replayed. |
| "This read is parsed" signal | `notifyWhenReadParsed()` sets a uws
state bit. uws delivers a `readParsed` event after the read. It replaces
a `setImmediate`. |
| Close during a parse | One uws bit defers a close to the end of the
current message. |
| Response finish | A response is finished when it has ended and the
socket has fully drained. |
| Idle connection | One rule, `HttpResponse::closeIfIdle()`. A
connection is idle when it receives no request (head or body) and no
response is in flight, queued or undrained. The sweep of `close()` and
`closeIdleConnections()` both use it. |
| Idle tunnel | A tunnel at read EOF with nothing left to send. uws
reports it to the server through the connection filter (`-3`, `+3`,
`-4`). It still counts for `'close'`, but it does not hold the event
loop, like a libuv handle in that state. |
| Server `'close'` | One native close promise per `listen()`. `close()`
records whether its sweep left nothing open. Then a `listen()` in the
same tick cannot hold `'close'` back, as in
`net.Server._emitCloseIfDrained`. |
| Raw socket writes | While uws holds response bytes (its buffer, the
zero-copy tail of a `res.write()`, the cork buffer), a raw write goes
through `AsyncSocket::write`, the path a 1xx line takes. So the order on
the wire is the order of the calls. |
| Upgrade verdict | One scanner and one verdict, shared by the parser
and the dispatcher. |
| llhttp | Updated from 9.3.0 to 9.4.2, as Node v26.5.0 vendors it, plus
one local patch (see below). Node v26.5.1 and later vendor 9.4.3. That
update is not in this PR. |

The parser changes also tighten request framing so that it agrees with
llhttp in more cases. There is no new API surface.

### A pause holds from the next read

The copy of the rest of a read (`nodeHttpPausedSpill`), its replay from
a posted task and the nested parse are removed. Like in Node, the rest
of the read that caused a pause is still parsed, and the socket stops at
the next read. usockets reads up to 512 KB in one call. libuv reads 64
KB.

| One paused, unread request (client sends 64 MB) | Bytes held |
| --- | --- |
| Node 25.6 | 131,018 |
| This pull request | 524,234 |

The price is in one case. A client sends 512 KB of small pipelined
requests (19,418 of them) and never reads. Each handler answers with its
own 64 KB body:

| Handler | Runtime | Requests dispatched | RSS |
| --- | --- | --- | --- |
| Answers at once | Node 26.3 | 2,425 | +177 MB |
| Answers at once | main | 41 | +9 MB |
| Answers at once | This PR | 2,425 | +171 MB |
| Answers one tick later | Node 26.3 | 4,850 | +336 MB |
| Answers one tick later | main | 2,426 | +181 MB |
| Answers one tick later | This PR | 4,850 | +330 MB |

Release builds on Linux x64. This PR now does what Node does. main held
fewer responses, mostly for a handler that answers at once. On macOS one
read can return all 512 KB. There, Bun 1.4.3 already reached +951 MB for
the handler that answers one tick later, and Node reached +1,294 MB.
`server.maxRequestsPerSocket` bounds it.

### Performance

#### Responses larger than 16 KB are faster, and now faster than Node

On main, a response that did not fit the 16 KB uWS cork buffer released
the cork. After that, each piece was its own `send()`: the buffered
head, the chunk-size line, the data, the `\r\n` and the last chunk. Over
TLS, each 2-byte piece was also its own record. Two changes fix that,
for `Bun.serve` and for node:http:

| Change | Effect |
| --- | --- |
| A write that does not fit goes out with the cork buffer and its
framing in one vectored write | No copy is added. Over TLS, the records
of all the pieces share the write batch that one `SSL_write` loop
already had. |
| The cork buffer holds 128 KB, up from 16 KB. Only a write of 16 KB or
less is copied into it, as before. | Several writes in one tick go out
in one write, like in Node. A longer write still goes out without a
copy. |

The bytes on the wire are the same. The vectored write uses `sendmsg()`
with the flags that `send()` uses.

Write syscalls for one response:

| Response | Node 26.3 | main | This PR |
| --- | --- | --- | --- |
| 4 x `res.write(16 KB)` | 1 | 16 | 1 |
| 40 x `res.write(2 KB)` | 1 | 16 | 1 |
| `res.end(64 KB)` | 1 | 2 | 1 |
| 256 KB file, `.pipe(res)` | 4 | 16 | 5 |

Throughput (req/s, the mean of 2 rounds). Node v26.3.0, main
`97246d044e`, this PR `fe0ed1fbea`, with the method below:

| Case | Node | main | This PR | main / Node | PR / Node | PR / main |
| --- | --- | --- | --- | --- | --- | --- |
| http, 4 x `res.write(16 KB)` | 17,735 | 6,983 | 19,160 | 0.39x | 1.08x
| 2.74x |
| https, 4 x `res.write(16 KB)` | 11,720 | 6,110 | 15,510 | 0.52x |
1.32x | 2.54x |
| http, 40 x `res.write(2 KB)` | 9,879 | 6,140 | 14,980 | 0.62x | 1.52x
| 2.44x |
| https, 40 x `res.write(2 KB)` | 6,981 | 5,541 | 11,780 | 0.79x | 1.69x
| 2.13x |
| http, `res.end(64 KB)` | 18,535 | 16,528 | 19,889 | 0.89x | 1.07x |
1.20x |
| http, 256 KB file `.pipe(res)` | 2,684 | 2,375 | 2,719 | 0.88x | 1.01x
| 1.15x |
| https, `res.end(64 KB)` | 11,894 | 14,586 | 16,426 | 1.23x | 1.38x |
1.13x |
| http, GET hello (control) | 55,994 | 70,989 | 71,958 | 1.27x | 1.29x |
1.01x |

main was slower than Node in six of these eight cases. This PR is faster
than Node in all eight.

`Bun.serve`, measured on `a771572a8d`, before the larger cork buffer
(req/s, the mean of 2 rounds):

| Case | main | PR | Change |
| --- | --- | --- | --- |
| Direct stream, 4 x 16 KB | 6,826 | 12,479 | +83% |
| 64 KB string | 16,944 | 20,145 | +19% |
| TLS, 64 KB string | 15,045 | 16,892 | +12% |
| hello (control) | 83,957 | 83,137 | -1.0% |

These runs are on loopback, where the kernel send buffer is 2.6 MB and
the work of the receiver runs inside `send()`. That is the best case for
fewer writes. A new connection over a real network takes about 46 KB in
its first write on Linux. The rest waits in the socket buffer, as it
would after separate writes.

#### Small responses are unchanged

A small response is already one `recvfrom` and one `sendto` on both
builds. `perf` puts 66% of the time of a hello-world server in the
kernel, on both builds.

CI release builds on Linux x64: main `97246d044e` (the merge base)
against this PR `8834cd0787`. Both use the same WebKit. The server runs
on one pinned core. `oha` sends 64 connections for 5 s after a 2 s
warm-up. There are 2 rounds, and the order of the builds alternates.
"Change" compares the means of the two rounds.

Framework servers from `bun-perf-tester` (req/s):

| Server | main, round 1 | main, round 2 | PR, round 1 | PR, round 2 |
Change |
| --- | --- | --- | --- | --- | --- |
| express | 49,803 | 51,103 | 49,968 | 50,263 | -0.7% |
| fastify | 61,214 | 61,105 | 60,705 | 60,668 | -0.8% |
| node:http | 70,934 | 71,405 | 73,178 | 71,053 | +1.3% |
| elysia | 84,696 | 85,096 | 85,027 | 84,882 | +0.1% |
| `Bun.serve` | 89,020 | 89,099 | 88,168 | 88,373 | -0.9% |

node:http paths that this PR changes (req/s):

| Case | main, round 1 | main, round 2 | PR, round 1 | PR, round 2 |
Change |
| --- | --- | --- | --- | --- | --- |
| GET hello | 70,226 | 70,341 | 70,151 | 72,359 | +1.4% |
| POST, 16 KB body | 47,446 | 47,789 | 48,191 | 48,785 | +1.8% |
| 64 KB response in four writes | 6,885 | 6,894 | 6,834 | 6,868 | -0.6%
|
| Pipelined keep-alive, depth 8 | 94,063 | 93,294 | 92,909 | 93,809 |
-0.3% |

p99 latency (ms), the higher of the two rounds:

| Server | main | PR |
| --- | --- | --- |
| express | 1.94 | 1.91 |
| fastify | 1.52 | 1.55 |
| node:http | 1.11 | 1.12 |
| elysia | 0.98 | 0.96 |
| `Bun.serve` | 0.82 | 0.83 |

RSS (MB), one pass of 8 s of load:

| Server | Build | Start | Under load | 5 s idle | 15 s idle |
| --- | --- | --- | --- | --- | --- |
| express | main | 39 | 94 | 61 | 57 |
| express | PR | 40 | 92 | 60 | 57 |
| fastify | main | 41 | 91 | 58 | 55 |
| fastify | PR | 41 | 91 | 58 | 55 |
| node:http | main | 20 | 64 | 43 | 40 |
| node:http | PR | 20 | 65 | 45 | 41 |
| elysia | main | 28 | 46 | 36 | 35 |
| elysia | PR | 29 | 46 | 37 | 36 |
| `Bun.serve` | main | 14 | 30 | 22 | 22 |
| `Bun.serve` | PR | 14 | 30 | 22 | 22 |

Every change is within 2%. fastify and `Bun.serve` hello are lower in
both rounds, by about 1%. `Bun.serve` hello shows the same -1.0% in the
control row above, so a small real cost there is possible. The RSS pass
ran at the same time as the throughput runs, on other cores. The commits
after `8834cd0787` change tests and add one version check to the
node:http dispatcher. They were not measured.

### Supersedes

| Theme | Pull requests |
| --- | --- |
| Request body | #43592 #43579 #38196 #43518 #43602 #43408 #43427 #43597
#43555 #43456 #43466 |
| Tunnels | #43570 #43485. #43596 is a duplicate of #43570. |
| Parser | #43182 #43161 #43326 #43327 #40505 #43363 #42532 #42194 |
| Response write | #39386 #43371 #43548 #43499 #43496 #43464 #42008
#43549 |
| Response finish | #40351 #43021 #41822 #43473 #42068 #35207 #43425
#43503 |
| Lifecycle | #43413 #39686 #43028 #42727 #42622 #42610 #35837 #35839
#37825 #37749 #43376 #35268 |
| JS API | #41691 #41738 #38036 #42462 #36527 #39718 #37964. #42947
merged on its own. |

The close drain, `resetAndDestroy()`, the pending write callback
handling and the response `'close'` ordering come from #42622 and #42727
by @steipete. The diagnosis and the tests for the stalled `ws` writes
come from his #42610.

Not included:

| Pull request | Reason |
| --- | --- |
| #33061 | main already enforces `headersTimeout` and `requestTimeout` |
| #41672 | It makes `http.createServer({ key, cert })` stop serving TLS.
That needs a product decision. |
| #37543 | A type refactor with no tests and no user-visible change |
| #35465 | It makes `http.Server` extend `net.Server`. Only the
prototype chains were joined. The `net.Server` constructor never ran, so
`_handle` and `_connections` were `undefined`, and
`_emitCloseIfDrained()` emitted `'close'` on a listening server. The
server is backed by uWS, not `node:net`. |
| The `AutoFlusher` removal in #42622 | It makes `flushHeaders()` flush
at once. That is a performance change with no relation to the rest. |

### Tests

| Check | Result on a debug build (macOS arm64) | Head |
| --- | --- | --- |
| Every test file that this PR touches (28 files) | 1,866 pass, 2 fail.
The 2 failures are `serve.test.ts` "bounds memory when proxying ... to a
stalled client". They fail the same way on a debug build of main. |
`83af4da4a3`, run before the last commit of main came in |
| `test/js/third_party/express` (9 files) and the `body-parser` test |
299 pass, 0 fail | `83af4da4a3`, run before the last commit of main came
in |
| Node 25.6 against Bun, 32 scenarios from two scripts (event order,
framing, lifecycle) | No regression against Bun 1.4.3 | `0ff1a23f61` |
| Every vendored Node `test-http-*` and `test-https-*` file, plus the
`test-net-*` and `test-tls-*` files for pause, write, end and close |
535 of 537 exit 0. `test-http-agent-keepalive.js` and
`test-https-timeout.js` fail on that debug build. Both pass on every CI
lane. | `daee05fcfd` (before the rebase) |
| The tests that depend on what the kernel takes in one send, on Windows
Server 2019 x64 and Windows 11 arm64 | pass | `3eef223328` (x64),
`a29289bcc1` (arm64) |
| CI build 120191 (Linux, macOS and Windows, release and ASAN) | every
lane passed | `daee05fcfd` (before the rebase) |

Each new test fails on Bun 1.4.3, or on the commit before its fix for a
fault that this branch introduced.

The two tests over the limit are `node-http-connect.test.ts` ("tests
should run on bun") and `node-http-syscall-fault.test.ts` ("racing a
queued drain"). Each starts a debug subprocess that needs more than 5 s
on this machine. Both pass on CI.

### Changes in the last push

The branch is rebased on main (`daee05fcfd` was the head before). It is
now linear.

Four regressions against main, each with a test that fails without its
fix:

| Case | main | Before this push | Now (same as Node) |
| --- | --- | --- | --- |
| `emit('connection')` or http2 `allowHTTP1`: `res.end()` on a request
that nobody reads | `'end'`, `'close'` | No events | `'end'`, `'close'`
|
| The same server, an unread 32 MB body | 0 bytes held | 32 MB held | 0
bytes held |
| A NUL in a header value with `httpValidation: "relaxed"` (client,
`HTTPParser`, `emit('connection')` server) | Accepted | The process
spins forever | `HPE_INVALID_HEADER_TOKEN` |
| `Connection: close`, body in the same read as the head, a 20 KB
response before the body is read | `'end'` with an empty body | No
events on `req` | `'end'` with the body, `'close'` |
| An empty line on an idle keep-alive connection, then `server.close()`
| 0 s | About 6 s | 0 s |

| Fix | Where |
| --- | --- |
| The finish listener of a fallback connection dumps an unread request,
like Node's `resOnFinish` | `http1_server_fallback.ts` |
| llhttp patch: `llhttp__internal__c_test_lenient_flags_20` is false for
a NUL. The relaxed state does not consume a NUL, and the next state sent
it back there. 9.4.3 has the same loop. | `llhttp.c`, noted in its
`README.md` |
| A node:http socket that `onData` is parsing gets the close gate of
`onData`, also when a large write released the cork | `HttpResponse.h`
`uncorkCompletedResponse()` |
| A read that starts no message leaves an idle connection idle |
`HttpContext.h` `onData` |

The open review threads are fixed in `8834cd0787`:
`closeAllConnections()`, `Proxy-Connection: close`, five comments cut to
one line, and the test of two overlapping listeners, which now waits on
events. With the generation gate in `emitCloseServer` removed, that test
fails in both cases. `AsyncSocketData` keeps its bools together, which
takes it from 56 to 48 bytes per socket.

`http.Server` no longer extends `net.Server` (see "Not included"). The
special case for it in `Ipc.ts` is gone too. `child.send(msg,
httpServer)` still throws `ERR_INVALID_HANDLE_TYPE`, and its test stays.

<details><summary>Changes since the first revision (2988a61)</summary>

Merged with main at `c8e1f6fa5b`. The one conflict was #43708
(`req.socket` emits `'end'` and `'error'`). Its state bit
`HTTP_NODE_PEER_ENDED` moved to bit 22, because bit 19 is
`HTTP_NODE_NOTIFY_READ_PARSED` here. Its 15 tests run in
`node-http-server-abort-events.test.ts` next to the tests of this branch
(103 pass).

CI on `2988a610c` had ten red tests from four causes. They are fixed:
- `ed882e5e99`: `write()` to a response without a body (HEAD, 204) does
not wait for unsent bytes.
- `811f817704`: an idle tunnel does not hold the event loop after
`server.close()`. Four vendored Node tests timed out on every platform.
- `0697deec11`, `d428824c08`, `7aec062d14`: the write callback tests use
a body that backs up a loopback socket, and accept what Winsock does.
- `c7af1c1615`: two tests from main asserted the old `close()` contract.

Review findings, each reproduced against Node v26.3.0 and fixed with a
test that fails without the fix:
- `d4d2b783ea`, `2cc79939bb`, `45141abca9`, `9a63dbc470`, `80a23a1822`:
the idle rule. A keep-alive connection is idle again when its body ends
after its response. A connection that owes a queued pipelined response,
that still receives a request head or body, or whose response still
drains is not idle.
- `87d8904aa3`, `7eca4f7806`: `close(cb)` followed by `listen()` in the
same tick reports `'close'`, also for an https server whose only
connection was idle.
- `3fd7b25382`: a paused pipelined request behind a response that still
drains stops the connection. The first revision read 512 MiB of 512 MiB
into memory.
- `2d1a5e2d8d`, `33e4683a8a`, `539cb41eb9`, `197c7dfc29`, `0490e3540b`:
raw socket writes stay behind every unsent response byte. The cases were
a CONNECT pipelined behind a response that still drains (its `200`
landed at offset 2.6 MB of a 64 MiB body), a zero-length tunnel write
(it hung the tunnel), the 400 replies above, the zero-copy tail of a
large `res.write()`, the cork buffer, and Windows 11, where the kernel
takes the whole response and refuses the next send.
- `0abd39c133`: an upgrade from the request's `'end'` listener keeps the
body bytes out of the WebSocket. The connection closed with 1006 right
after the 101.
- `5aafc61aa6`: the callback of a small `res.write()` that the kernel
refuses at the uncork runs on the drain. Reproduced on Windows 11 only.
- `a29289bcc1`: a tunnel write that waits for a drain settles its
callbacks when the connection closes.

Known differences from Node that this PR leaves:
- A handler that calls `res.end()` and then `server.close()` closes its
keep-alive connection at once. Node waits for the `keepAliveTimeout`.
- A pipelined Upgrade behind a response that still drains is served as a
plain request.
- An `end()` on a tunnel with no write pending, while the response
before the CONNECT still drains, closes both directions after the flush.
Node half-closes.
- A raw `req.socket.write(big)` and `req.socket.end()` with no
`res.end()` sends every byte but no FIN. main loses bytes here.
- A CONNECT socket that is given back with `server.emit('connection',
socket)` answers only the first of several pipelined requests. main
answers none.
- A large write from an `'upgrade'` listener stalls while the body of
that Upgrade request is still pending. A second `listen()` on a
listening server does not throw. Both are the same on main.
- A tunnel write that fails because the client went away fails its
callbacks but emits no `'error'`. Node emits `ECONNRESET`. A new
`'error'` could end a process that has no listener for it.

</details>

<!-- robobun:evidence:begin -->

---

**no test proof** · iteration 8 · platform-specific test(s) that do not
run on this machine, deferring to CI, which covers all platforms:
test/js/web/fetch/fetch.stream.test.ts, test/js/node/url/url.test.ts,
test/js/node/tls/tls-syscall-fault.test.ts,
test/js/node/net/node-net-server.test.ts,
test/js/node/http/node-http.test.ts,
test/js/node/http/node-http-syscall-fault.test.ts,
test/js/node/http/node-http-server-close-drain.test.ts,
test/js/node/http/node-http-connect.test.ts,
test/js/node/http/node-http-backpressure.test.ts,
test/js/node/child_process/child_process_ipc_handle.test.ts,
test/js/bun/http/serve.test.ts,
test/js/bun/http/serve-syscall-fault.test.ts,
test/js/bun/http/bun-server.test.ts

<!-- robobun:evidence:end -->

---------

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

Superseded by #43557, which is merged (5d5f03f). It fixes this once for the whole node:http server and carries the tests over.

@robobun

robobun commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator Author

Confirmed: #43557 is merged at 5d5f03f and covers this. Nothing further here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants