Skip to content

node:http: do not end a request with body bytes missing after res.destroy() - #43518

Closed
robobun wants to merge 3 commits into
mainfrom
robobun/edd05b8f/http-no-end-for-truncated-body
Closed

robobun wants to merge 3 commits into
mainfrom
robobun/edd05b8f/http-no-end-for-truncated-body

Conversation

@robobun

@robobun robobun commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • After res.destroy() (in the 'request' listener, or in 'data' mid-upload), a node:http request emits 'end' with req.complete === true and body bytes missing. With 3 of 10 bytes sent, Bun emits req end, req close, res close. Node v26.3.0 emits req aborted, res close, req error (ECONNRESET), req close.
  • Cause: the teardown in native abort() sets body_read_state = Done for a Pending body (clear_on_data_callback, src/runtime/server/NodeHTTPResponse.rs). _read() (src/js/node/_http_incoming.ts:390) reads the done bit of hasBody as EOF.
  • A complete body loses a tail that was buffered during a pause: mark_request_as_done frees it on a closed connection ('end' with 2048 of 2052 bytes).

Fix

Background

  • hasBody exposes the native body_read_state (None, Pending, Done) to JS. Done means reading stopped, not a complete body.
  • Native code buffers body bytes that arrive during a pause. _read() drains them.
  • NodeHTTPServerSocket#onClose runs as a task after the close and destroys a request whose response is unfinished (Node's abortIncoming).
Notes

Repro 1, a body that is still arriving (run with node and with bun):

const http = require("node:http");
const net = require("node:net");
const events = [];
const server = http.createServer((req, res) => {
  let received = 0;
  req.on("data", chunk => (received += chunk.length));
  req.on("error", e => events.push("req error:" + e.message));
  req.on("aborted", () => events.push("req aborted"));
  req.on("end", () => events.push(`req end (received ${received} of 10, complete=${req.complete})`));
  req.on("close", () => events.push("req close"));
  res.on("close", () => events.push("res close"));
  res.destroy();
});
server.listen(0, "127.0.0.1", () => {
  const c = net.connect(server.address().port, "127.0.0.1", () =>
    c.write("POST / HTTP/1.1\r\nHost: a\r\nContent-Length: 10\r\n\r\nabc"));
  c.on("data", () => {});
  c.on("error", () => {});
  c.on("close", () => setTimeout(() => { console.log(events.join(", ")); server.close(); }, 200));
});
  • Node v26.3.0: req aborted, res close, req error:aborted, req close
  • Bun before: req end (received 0 of 10, complete=true), req close, res close
  • Bun after: req aborted, res close, req error:aborted, req close

The same happens with req.resume(), a 'readable' listener, and a for await that starts right after res.destroy() (before: the loop finishes with 0 bytes, after: it rejects with ECONNRESET).

Repro 1b, an upload that a 'data' listener cuts short. req.on("data", () => res.destroy()), the headers in one write, the first body bytes in a later write (Content-Length: 100 with 10 bytes, or a chunked body with one chunk and no terminating chunk).

  • Node v26.3.0: req data:10, req aborted, res close, req error:ECONNRESET, req close (complete=false)
  • Bun before: req data:10, req end (received 10, complete=true), req close (complete=true), res close
  • Bun after: the same as Node

Repro 2, a complete body with a buffered tail. Server with highWaterMark: 1024. One write carries a chunked POST with a 2048 byte chunk, a 4 byte chunk and the terminating chunk. The first chunk fills the request buffer, so the connection pauses and native code buffers the rest of the segment. The listener runs setImmediate(() => { req.on("data", ...); res.destroy(); }).

  • Node v26.3.0: req end (received 2052 of 2052), req close, res close
  • Bun before: req end (received 2048 of 2052, complete=true), req close, res close
  • Bun after: the same as Node

Why the other teardown orders already worked. req.socket.destroy() and a deferred res.destroy() do not call abort() before the first _read(). That _read() still sees Pending, emits no EOF, and #onClose destroys the request. Only the synchronous res.destroy() moves the state to Done before the first _read().

Why the check is native and not in _read(). handle.aborted (the SOCKET_CLOSED flag) is also true for a request that must stay readable. Example: the request is paused, its whole body arrives and is buffered, the response ends, the client closes the connection, then the listener resumes the request. Node and Bun both deliver the bytes and 'end' there. JS cannot tell that case from a truncated body with the done bit alone, in particular when the buffered tail is empty. The native side knows it at the moment the connection goes away. mark_socket_closed() is now the only place that sets SOCKET_CLOSED.

The kept tail. Before this PR mark_request_as_done kept a buffered tail only while the connection was open (#38207). The tail is a Vec that the NodeHTTPResponse owns, and drainRequestBody does not touch the socket. After this PR the tail of a closed connection is freed when _read() drains it, when the reader lets go (ondata = undefined), or when the object drops. REQUEST_BODY_TRUNCATED and IS_DATA_BUFFERED_DURING_PAUSE_LAST are never set together: the first needs a body that is still arriving, and no fin is buffered after the connection is gone.

Known step back. A chunked upload arrives in two reads: the headers, then the last data chunk together with the terminating chunk (5\r\nhello\r\n0\r\n\r\n). The 'data' listener calls res.destroy() on that chunk.

  • Node v26.3.0 and Bun before: req data:5, req end (received 5, complete=true), req close, res close
  • Bun after: req data:5, req aborted, res close, req error:ECONNRESET, req close (complete=false)

uWS dispatches a chunked body one chunk per call and stops on a closed socket, so the terminating chunk of that read is never dispatched. Native code sees the same state as in Repro 1b: abort() from inside a body dispatch with the body still Pending. Only the parser knows what is left in the read. Bun before this PR is right here only because it ends every such request, which is the false 'end' of Repro 1b. A truncated upload that ends as complete corrupts data without a signal. An abort on an exchange that the handler destroyed does not. The real fix is to keep delivering the read that uWS is parsing after a close (#43513). A Content-Length body is not affected: its last data chunk carries the fin.

Related open PR. #43466 stops the native buffering during a pause. If it lands first, Repro 2 is covered by it, and the kept tail only matters for a body that was parked before a reader was armed. #38196 keeps a body Pending after res.end(). A connection that drops in the middle of that body is then also recorded as truncated here, which matches the outcome that PR expects (nothing is emitted on the request).

Matrix. I ran body arrival (truncated, complete in the packet of the headers, chunked variants) x consumer ('data', resume(), 'readable', none) x teardown (res.destroy(), req.socket.destroy(), setImmediate, nextTick) on Node v26.3.0, on a debug build of the base commit, and on the build with the fix. The fix changes only the rows with a consumer and a synchronous res.destroy(). All other rows are identical to the base build.

Self-review. Concerns raised: (1) the freed tail (Repro 2), fixed here with a test. (2) Two comments did not say what ends a truncated request and why a buffered fin is excluded, reworded. (3) No test covered a buffered tail that is read after the connection closed, the Repro 2 test does. (4) #43512: the request of a pipelined response that was destroyed while queued is never destroyed. It exists on main for a consumer attached before the teardown. With this PR a consumer attached after the teardown also waits (before: a false 'end'). The fix belongs in advanceResponsePipeline. (5) #43513: body bytes that arrived in the packet of the headers are dropped when the listener destroys the connection synchronously, because uWS stops parsing on a closed socket (packages/bun-uws/src/HttpContext.h). With a complete body in that packet Node emits 'data' and 'end'. Bun before this PR emitted 'end' with zero bytes for res.destroy(). Bun now reports the request as aborted, the same as it already does for req.socket.destroy().

Seen on the way, not changed. NodeHTTPServerSocket#resumeSocket (src/js/node/_http_server.ts) reads hasBody from the socket handle. That handle has no such property, so the emitServerSocketEOFNT branch there never runs. It plays no part in this bug.

Review findings after the PR opened. (1) The step back above. (2) #43543: an Upgrade request whose body is cut short by a close still emits 'end'. uWS ends that body with a synthetic fin in HttpContext::onClose before SOCKET_CLOSED is set. It exists without this PR and is not changed here. (3) The kept tail lives until the handle wrapper is collected when nobody reads it. That is deliberate: hasBody reports that body as done, so a freed tail is the false 'end' of Repro 2. #38207 already keeps such tails after res.end().

Tests in this container. The debug build is slow here. node-http-server-socket-end-drain.test.ts prints the expected output in 5.2 s with and without the fix, over the 5 s default timeout. 1 to 2 tests in node-http-with-ws.test.ts and test-http-abort-queued.js (a 100 ms timer) also fail with and without the fix. node-http-uaf.test.ts times out here (its fixture needs about 250 s for 2000 requests on this machine).


[human-review] gate passed · iteration 0 · 2 files touched

fails on main (without fix)
ASAN without fix: BUILD FAILED (no junit output)
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/http/node-http-server-abort-events.test.ts
ninja: Entering directory `/workspace/bun/build/debug'
[1/168] gen ErrorCode+*.h
[2/168] gen cpp.rs (cppbind)
[3/168] gen generated_host_exports.rs
generated_host_exports.rs: 121 exports (host=5, lazy=10, generic=106, rust=0); 245 extern-C blocks audited
[4/168] gen JS modules (bundle-modules)
Preprocess modules (9551ms)
Bundle modules (204ms)
Postprocesss modules (283ms)
Bundle Functions (545ms)
Generate Code (74ms)

[10.67s] Bundled "src/js" for development
  2799 kb
  197 internal modules
  13 native modules
  50 internal functions across 16 files
[4/19] cargo bun_runtime → libbun_runtime.a
[14/19] cxx obj/src/jsc/bindings/ZigGlobalObject.cpp.o
FAILED: obj/src/jsc/bindings/ZigGlobalObject.cpp.o /workspace/bun/build/debug/obj/src/jsc/bindings/ZigGlobalObject.cpp.o 
/usr/bin/ccache /usr/lib/llvm-23/bin/clang++ -march=nehalem -O0 -glldb -g3 -gz=zstd -fno-standalone-debug -fsanitize=address -fsanitize-address-use-after-return=never -fno-exceptions -fno-c++-static-destructors -fno-
... (truncated)

release without fix: 7 FAILED
bun test v1.4.3-canary.1 (367d939d9)

test/js/node/http/node-http-server-abort-events.test.ts:
(pass) aborted request body emits 'error' ECONNRESET and res 'close' before req 'close' [157.93ms]
(pass) res.destroy() defers 'close' > on a response served over server.emit('connection') (ended first: false) [12.23ms]
(pass) res.destroy() defers 'close' > on a response served over server.emit('connection') (ended first: true) [1.61ms]
118 |   test.concurrent.each(Object.keys(consumers))("truncated body read with %s: aborted, no 'end'", async consumer => {
119 |     const events = await recordRequest(truncatedPost, (req, res) => {
120 |       consumers[consumer](req);
121 |       res.destroy();
122 |     });
123 |     expect(events).toEqual(aborted);
                         ^
error: expect(received).toEqual(expected)

  [
-   "req.aborted",
+   "req.end",
+   "req.close (complete: true)",
    "res.close",
-   "req.error:ECONNRESET",
-   "req.close (complete: false)",
  ]

- Expected  - 3
+ Received  + 2

      at <anonymous> (/workspace/bun/test/js/node/http/node-http-server-abort-events.test.ts:123:20)
118 |   test.concurrent.each(Object.keys(consumers))("truncated body
... (truncated)
passes on PR (with fix)
ASAN with fix: all passed
$ BUN_DEBUG_QUIET_LOGS=1 bun scripts/build.ts --profile=debug --quiet test "--reporter=junit" "--reporter-outfile=/tmp/pr_gate.xml" test/js/node/http/node-http-server-abort-events.test.ts
bun test v1.4.3 (367d939d9)

test/js/node/http/node-http-server-abort-events.test.ts:
(pass) aborted request body emits 'error' ECONNRESET and res 'close' before req 'close' [848.78ms]
(pass) res.destroy() while the request is being read > truncated body read with a 'data' listener: aborted, no 'end' [905.58ms]
(pass) res.destroy() while the request is being read > truncated body read with resume(): aborted, no 'end' [875.77ms]
(pass) res.destroy() while the request is being read > truncated body read with a 'readable' listener: aborted, no 'end' [910.41ms]
(pass) res.destroy() while the request is being read > truncated body: for await rejects instead of finishing with an empty body [955.31ms]
(pass) res.destroy() while the request is being read > upload (Content-Length) cut short from inside a 'data' listener: aborted, no 'end' [1039.79ms]
(pass) res.destroy() defers 'close' > inside a 'finish' listener [530.74ms]
(pass) res.destroy() defers 'close' > inside the end() callback [6
... (truncated)

release with fix: all passed
$ bun scripts/build.ts --profile=release
[configured] bun-profile → bun (stripped) in 2590ms (unchanged)
ninja: Entering directory `/workspace/bun/build/release'
[1/128] gen ErrorCode+*.h
[2/128] gen generated_host_exports.rs
generated_host_exports.rs: 121 exports (host=5, lazy=10, generic=106, rust=0); 245 extern-C blocks audited
[3/128] gen cpp.rs (cppbind)
[4/128] gen JS modules (bundle-modules)
Preprocess modules (13269ms)
Bundle modules (205ms)
Postprocesss modules (300ms)
Bundle Functions (784ms)
Generate Code (75ms)

[14.65s] Bundled "src/js" for production
  2607 kb
  197 internal modules
  13 native modules
  50 internal functions across 16 files
[4/16] cargo bun_runtime → libbun_runtime.a
�[1m�[33mwarning�[0m�[1m: binary `bun_shim_impl` should have a kebab-case name�[0m
   �[1m�[94m|�[0m
�[1m�[94m 1�[0m �[1m�[94m|�[0m /workspace/bun/build/release/rust-target/.../bun_shim_impl
   �[1m�[94m|�[0m                                              �[1m�[33m^^^^^^^^^^^^^�[0m
   �[1m�[94m|�[0m
   �[1m�[94m= �[0m�[1mnote�[0m: `cargo::non_kebab_case_bins` is set to `warn` by default
�[1m�[96mhelp�[0m: to change the binary name to `bun-shim-impl`, convert `bin.name`

... (truncated)
diff hotspot
src/runtime/server/NodeHTTPResponse.rs             |  39 +++++--
 .../http/node-http-server-abort-events.test.ts     | 130 +++++++++++++++++++++
 2 files changed, 159 insertions(+), 10 deletions(-)

gate history · 1 passed · 0 rejected · iteration 0

evidence per changed file
file                                                     reads  edits  tests
src/runtime/server/NodeHTTPResponse.rs                       9      6     27
test/js/node/http/node-http-server-abort-events.test.ts      3      1     27

…troy()

res.destroy() aborts the native handle, and the teardown moves
body_read_state to Done. The request's next _read() reads the done bit
of hasBody as EOF and emits 'end' with complete = true, although body
bytes never reached it:

- A body that was still arriving ends as a complete, empty body. Record
  the truncation when the connection goes away and keep reporting that
  body as pending. The socket close path then destroys the request with
  ECONNRESET, like Node.js.
- A complete body whose tail was buffered while the request was paused
  loses that tail, because a closed connection freed it. Keep the tail
  until the reader drains it or lets go, as an open connection does.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review paused — included plan limit reached

Keep your review moving with free on-demand reviews.

  • Run this review for free

On-demand reviews are free for one more day.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Promotion and pricing details

On-demand reviews are free for one more day. After that, they cost $0.25 per reviewed file.

Review limit details

Or wait 3 minutes for your next included review.

Check out review usage here.

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: oven-sh/bun/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Essentials

Run ID: 4f8e27c3-ad73-4382-a860-7408e45c9fe1

📥 Commits

Reviewing files that changed from the base of the PR and between 26e7a4b and 26878e6.

📒 Files selected for processing (2)
  • src/runtime/server/NodeHTTPResponse.rs
  • test/js/node/http/node-http-server-abort-events.test.ts

Comment @coderabbitai help to get the list of available commands.

@robobun

robobun commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 3:23 PM PT - Sep 19th, 2026

✅ @robobun, your commit 26878e6e78f9d24206308a60f42dd126264b2cdc passed in Build #118510! 🎉


🧪   To try this PR locally:

bunx bun-pr 43518

That installs a local version of the PR into your bun-43518 executable, so you can run:

bun-43518 --bun

@robobun

robobun commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

Status

Superseded by #43557 (merged as 5d5f03f), which fixes this for the whole node:http server and carries the tests of this PR over.

Checked on a debug build of main at 5d5f03f:

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline findings, I also checked that the new REQUEST_BODY_TRUNCATED bit (1 << 9) not being mirrored in NodeHTTPResponseFlags in src/js/internal/http.ts is harmless: every JS consumer of handle.flags masks bits 0-3 with bitwise-AND, and _read()'s === none check still sees the pending bit for a truncated body, so no JS path misreads the widened value.

Extended reasoning...

The inline findings cover the behavioral regressions in mark_socket_closed / get_has_body / the kept tail. Separately, I traced the raw flags getter into src/js/node/_http_server.ts (lines ~3191, 3239, 3360) and NodeHTTPResponseFlags in src/js/internal/http.ts: all uses are flags & <bit> on bits 0-3, never equality on the whole integer, so the un-mirrored bit 9 cannot flip any JS decision. The hasBody layout (NodeHTTPBodyReadState pending=1<<1, done=1<<2, buffered=1<<3) still matches get_has_body, and the bodyReadState === none equality in _http_incoming.ts:394 is unaffected because a truncated body reports the pending bit rather than 0.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved
Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved
Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved
Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved
…destroy()

The same false 'end' fires when res.destroy() runs inside a 'data'
listener while more of the body is still to come (Content-Length and
chunked). Cover both.

The doc comment of mark_socket_closed now names the two paths it does
not cover: the rest of the read that uws is parsing, and the synthetic
fin that ends an Upgrade request body on close.
Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved
Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved
Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved
Comment thread src/runtime/server/NodeHTTPResponse.rs Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

Still open from earlier reviews (3):

  • 🔴 src/runtime/server/NodeHTTPResponse.rs:1576 — After merging, a node:http handler that calls res.destroy() inside a 'data' listener on the final chunk of a chunked up…
  • Also unresolved: 2 minor or pre-existing.

If you have decided not to act on one of these findings, resolve its thread (a reply alone leaves it open) and the next review stops counting it. To review this commit again now, use Re-run on its "Claude Code Review" check.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review found no issues

No high-confidence issues detected in this change.

@robobun

robobun commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

FYI: #43602 fixes #43513 (the deferred close during a parse). It merges cleanly with this branch. On the merged tree the 27 tests of node-http-server-abort-events.test.ts pass, and the known step back noted here (chunked last chunk plus terminator in one read, res.destroy() from 'data') gives the Node output.

Jarred-Sumner added a commit that referenced this pull request Sep 26, 2026
…inish, lifecycle) (#43557)

One pull request for the open `node:http` server pull requests. Each
root cause is fixed once, and each pull request's tests are carried
over. Node is the reference: every scenario was run under Node and under
Bun from one script, and the outputs were compared.

Fixes #4733
Fixes #18613
Fixes #40350
Fixes #43155
Fixes #43297
Fixes #43513
Fixes #43527
Fixes #25632
Fixes #31301
Fixes #43027
Fixes #43163
Fixes #43342
Fixes #43344
Fixes #43370
Fixes #43490
Fixes #43512
Fixes #43519

Each of these has a repro that is wrong on Bun 1.4.3, right on this
branch, and the same as Node.

| Issue | Not closed by this PR, because |
| --- | --- |
| #30501 (msal-node keeps Bun alive at exit) | Probably fixed. The repro
copies the teardown of msal-node. The package itself was not run. |
| #14430 (yarn: "does not support SSL") | Probably fixed.
`response.hasOwnProperty("socket")` is now `true`. yarn itself was not
run. |
| #39681 (`server.setTimeout` callback after destroy) | Probably fixed.
The repro is the deterministic case of #39686. The script in the issue
depends on timing and on Windows. |
| #43455 (`req.complete`, nine flows) | Partially addressed. Flows 1, 2,
3, 5 and 7 are fixed, and flow 6 was already right. Flow 8 (a socket
timeout while the body of an Upgrade request arrives) and flow 9 (a
request that `stream.pipeline()` destroyed never reports `complete`) are
not. Flow 4 differs only in `_readableState.ended`. |

### What changes for users

| Area | Before | After (same as Node) |
| --- | --- | --- |
| `req.pause()` | The socket stops at once. `req.complete` stays `false`
for a small body. | The body is received until the buffer is full. Then
the socket stops. |
| `res.end()` before the body arrives | `req` gets `'end'` and `'close'`
at once, and the body is lost | The request completes when its body
really ends |
| `res.destroy()` in the middle of a body | `'end'` with bytes missing |
`aborted`, then `ECONNRESET` |
| `socket.destroy()` inside the `'request'` listener | The body that
came with the head is dropped | That body is still delivered |
| `'finish'` and the `end()` callback | Fire when `end()` buffers the
bytes | Fire when the last bytes have left the socket |
| A response that closes the connection | The server half-closes and
waits for the peer | The socket closes right behind the FIN |
| `'drain'` after a later write flushed the backlog | Lost. `pipe(res)`
could hang. | Emitted |
| A pipelined request whose body continues after the previous response
ends | Body dropped, no response, `server.close()` hangs | Delivered |
| CONNECT and Upgrade tunnel sockets | Keep reading when paused or full
| Stop reading. `_read()` starts them again. |
| A tunnel write that waits for a drain when the client goes away | Its
callback, the callbacks of the writes behind it and the `end()` callback
never run | They run with an error before `'close'` |
| Upgrade request with a body, paused in its listener | The body flows
away | The request keeps its body |
| `ws` on a reused keep-alive socket | Writes after the Upgrade could
stall | Sent |
| A raw `socket.write()` behind a response that still drains (the 400
for a bad pipelined request, the reply of a `'clientError'` listener) |
Lands in the middle of that response | Sent after it |
| `server.close()` | Could report closed while connections were open |
Waits for every connection. An idle tunnel does not keep the process
alive. |
| `closeAllConnections()` on a listening server | Also stops the
listener and destroys tunnels and WebSockets | Destroys only the HTTP
connections |
| `Proxy-Connection: close` (node:http only) | Ignored. The connection
stays open. | Ends the connection, like `Connection: close` |
| A response larger than 16 KB, also in `Bun.serve` and over TLS | Up to
4 `send()` calls for each chunk. Slower than Node in most cases. | One
write for the writes of one tick. 1.1x to 2.7x the requests per second
of main, and faster than Node. |
| `socket.destroy()` and then `res.end()` in a listener | (this PR,
earlier) `req` ended as if it were complete | `'aborted'`, then
`ECONNRESET` |
| `emit('connection')` or http2 `allowHTTP1`: the response ends while
the listener still reads the body | The rest of the body is dropped |
The body is complete |
| `httpValidation: "relaxed"`, `Content-Length` or `Transfer-Encoding`
in trailers | Accepted | `HPE_INVALID_CONTENT_LENGTH`,
`HPE_INVALID_TRANSFER_ENCODING` |
| `req.complete` inside `'connect'`, and inside `'upgrade'` without a
body | `false` | `true` |
| `optimizeEmptyRequests`: `socket.parser.incoming` after the response |
Keeps the request alive on an idle connection | `null` |
| A HEAD or OPTIONS request with `Content-Length` | The body is dropped,
and `req.complete` is `true` before it comes | The request has its body
|
| `res.end(chunk)` after the client went away | `finished` and
`writableEnded` stay `false`, no `'prefinish'` | The response ends |
| An HTTP/1.0 request with an `Expect` header | `100 Continue`,
`'checkContinue'`, `'checkExpectation'` or a 417 | A plain `'request'` |
| The idle sweep of `close()` and `closeIdleConnections()` | Could
destroy a connection that was still receiving a request, or whose
response was still draining | Closes only idle connections |

### Design

| Piece | What it is |
| --- | --- |
| Request body state | `None / Pending / Complete / Aborted / Upgraded /
Detached`. Only the last chunk sets `Complete`. One function,
`leave_pending`, is the only other way out of `Pending`. |
| Read flow control | One path: `push()` returning false stops the
socket, `_read()` starts it. Both native pause buffers are removed: no
read is copied and replayed. |
| "This read is parsed" signal | `notifyWhenReadParsed()` sets a uws
state bit. uws delivers a `readParsed` event after the read. It replaces
a `setImmediate`. |
| Close during a parse | One uws bit defers a close to the end of the
current message. |
| Response finish | A response is finished when it has ended and the
socket has fully drained. |
| Idle connection | One rule, `HttpResponse::closeIfIdle()`. A
connection is idle when it receives no request (head or body) and no
response is in flight, queued or undrained. The sweep of `close()` and
`closeIdleConnections()` both use it. |
| Idle tunnel | A tunnel at read EOF with nothing left to send. uws
reports it to the server through the connection filter (`-3`, `+3`,
`-4`). It still counts for `'close'`, but it does not hold the event
loop, like a libuv handle in that state. |
| Server `'close'` | One native close promise per `listen()`. `close()`
records whether its sweep left nothing open. Then a `listen()` in the
same tick cannot hold `'close'` back, as in
`net.Server._emitCloseIfDrained`. |
| Raw socket writes | While uws holds response bytes (its buffer, the
zero-copy tail of a `res.write()`, the cork buffer), a raw write goes
through `AsyncSocket::write`, the path a 1xx line takes. So the order on
the wire is the order of the calls. |
| Upgrade verdict | One scanner and one verdict, shared by the parser
and the dispatcher. |
| llhttp | Updated from 9.3.0 to 9.4.2, as Node v26.5.0 vendors it, plus
one local patch (see below). Node v26.5.1 and later vendor 9.4.3. That
update is not in this PR. |

The parser changes also tighten request framing so that it agrees with
llhttp in more cases. There is no new API surface.

### A pause holds from the next read

The copy of the rest of a read (`nodeHttpPausedSpill`), its replay from
a posted task and the nested parse are removed. Like in Node, the rest
of the read that caused a pause is still parsed, and the socket stops at
the next read. usockets reads up to 512 KB in one call. libuv reads 64
KB.

| One paused, unread request (client sends 64 MB) | Bytes held |
| --- | --- |
| Node 25.6 | 131,018 |
| This pull request | 524,234 |

The price is in one case. A client sends 512 KB of small pipelined
requests (19,418 of them) and never reads. Each handler answers with its
own 64 KB body:

| Handler | Runtime | Requests dispatched | RSS |
| --- | --- | --- | --- |
| Answers at once | Node 26.3 | 2,425 | +177 MB |
| Answers at once | main | 41 | +9 MB |
| Answers at once | This PR | 2,425 | +171 MB |
| Answers one tick later | Node 26.3 | 4,850 | +336 MB |
| Answers one tick later | main | 2,426 | +181 MB |
| Answers one tick later | This PR | 4,850 | +330 MB |

Release builds on Linux x64. This PR now does what Node does. main held
fewer responses, mostly for a handler that answers at once. On macOS one
read can return all 512 KB. There, Bun 1.4.3 already reached +951 MB for
the handler that answers one tick later, and Node reached +1,294 MB.
`server.maxRequestsPerSocket` bounds it.

### Performance

#### Responses larger than 16 KB are faster, and now faster than Node

On main, a response that did not fit the 16 KB uWS cork buffer released
the cork. After that, each piece was its own `send()`: the buffered
head, the chunk-size line, the data, the `\r\n` and the last chunk. Over
TLS, each 2-byte piece was also its own record. Two changes fix that,
for `Bun.serve` and for node:http:

| Change | Effect |
| --- | --- |
| A write that does not fit goes out with the cork buffer and its
framing in one vectored write | No copy is added. Over TLS, the records
of all the pieces share the write batch that one `SSL_write` loop
already had. |
| The cork buffer holds 128 KB, up from 16 KB. Only a write of 16 KB or
less is copied into it, as before. | Several writes in one tick go out
in one write, like in Node. A longer write still goes out without a
copy. |

The bytes on the wire are the same. The vectored write uses `sendmsg()`
with the flags that `send()` uses.

Write syscalls for one response:

| Response | Node 26.3 | main | This PR |
| --- | --- | --- | --- |
| 4 x `res.write(16 KB)` | 1 | 16 | 1 |
| 40 x `res.write(2 KB)` | 1 | 16 | 1 |
| `res.end(64 KB)` | 1 | 2 | 1 |
| 256 KB file, `.pipe(res)` | 4 | 16 | 5 |

Throughput (req/s, the mean of 2 rounds). Node v26.3.0, main
`97246d044e`, this PR `fe0ed1fbea`, with the method below:

| Case | Node | main | This PR | main / Node | PR / Node | PR / main |
| --- | --- | --- | --- | --- | --- | --- |
| http, 4 x `res.write(16 KB)` | 17,735 | 6,983 | 19,160 | 0.39x | 1.08x
| 2.74x |
| https, 4 x `res.write(16 KB)` | 11,720 | 6,110 | 15,510 | 0.52x |
1.32x | 2.54x |
| http, 40 x `res.write(2 KB)` | 9,879 | 6,140 | 14,980 | 0.62x | 1.52x
| 2.44x |
| https, 40 x `res.write(2 KB)` | 6,981 | 5,541 | 11,780 | 0.79x | 1.69x
| 2.13x |
| http, `res.end(64 KB)` | 18,535 | 16,528 | 19,889 | 0.89x | 1.07x |
1.20x |
| http, 256 KB file `.pipe(res)` | 2,684 | 2,375 | 2,719 | 0.88x | 1.01x
| 1.15x |
| https, `res.end(64 KB)` | 11,894 | 14,586 | 16,426 | 1.23x | 1.38x |
1.13x |
| http, GET hello (control) | 55,994 | 70,989 | 71,958 | 1.27x | 1.29x |
1.01x |

main was slower than Node in six of these eight cases. This PR is faster
than Node in all eight.

`Bun.serve`, measured on `a771572a8d`, before the larger cork buffer
(req/s, the mean of 2 rounds):

| Case | main | PR | Change |
| --- | --- | --- | --- |
| Direct stream, 4 x 16 KB | 6,826 | 12,479 | +83% |
| 64 KB string | 16,944 | 20,145 | +19% |
| TLS, 64 KB string | 15,045 | 16,892 | +12% |
| hello (control) | 83,957 | 83,137 | -1.0% |

These runs are on loopback, where the kernel send buffer is 2.6 MB and
the work of the receiver runs inside `send()`. That is the best case for
fewer writes. A new connection over a real network takes about 46 KB in
its first write on Linux. The rest waits in the socket buffer, as it
would after separate writes.

#### Small responses are unchanged

A small response is already one `recvfrom` and one `sendto` on both
builds. `perf` puts 66% of the time of a hello-world server in the
kernel, on both builds.

CI release builds on Linux x64: main `97246d044e` (the merge base)
against this PR `8834cd0787`. Both use the same WebKit. The server runs
on one pinned core. `oha` sends 64 connections for 5 s after a 2 s
warm-up. There are 2 rounds, and the order of the builds alternates.
"Change" compares the means of the two rounds.

Framework servers from `bun-perf-tester` (req/s):

| Server | main, round 1 | main, round 2 | PR, round 1 | PR, round 2 |
Change |
| --- | --- | --- | --- | --- | --- |
| express | 49,803 | 51,103 | 49,968 | 50,263 | -0.7% |
| fastify | 61,214 | 61,105 | 60,705 | 60,668 | -0.8% |
| node:http | 70,934 | 71,405 | 73,178 | 71,053 | +1.3% |
| elysia | 84,696 | 85,096 | 85,027 | 84,882 | +0.1% |
| `Bun.serve` | 89,020 | 89,099 | 88,168 | 88,373 | -0.9% |

node:http paths that this PR changes (req/s):

| Case | main, round 1 | main, round 2 | PR, round 1 | PR, round 2 |
Change |
| --- | --- | --- | --- | --- | --- |
| GET hello | 70,226 | 70,341 | 70,151 | 72,359 | +1.4% |
| POST, 16 KB body | 47,446 | 47,789 | 48,191 | 48,785 | +1.8% |
| 64 KB response in four writes | 6,885 | 6,894 | 6,834 | 6,868 | -0.6%
|
| Pipelined keep-alive, depth 8 | 94,063 | 93,294 | 92,909 | 93,809 |
-0.3% |

p99 latency (ms), the higher of the two rounds:

| Server | main | PR |
| --- | --- | --- |
| express | 1.94 | 1.91 |
| fastify | 1.52 | 1.55 |
| node:http | 1.11 | 1.12 |
| elysia | 0.98 | 0.96 |
| `Bun.serve` | 0.82 | 0.83 |

RSS (MB), one pass of 8 s of load:

| Server | Build | Start | Under load | 5 s idle | 15 s idle |
| --- | --- | --- | --- | --- | --- |
| express | main | 39 | 94 | 61 | 57 |
| express | PR | 40 | 92 | 60 | 57 |
| fastify | main | 41 | 91 | 58 | 55 |
| fastify | PR | 41 | 91 | 58 | 55 |
| node:http | main | 20 | 64 | 43 | 40 |
| node:http | PR | 20 | 65 | 45 | 41 |
| elysia | main | 28 | 46 | 36 | 35 |
| elysia | PR | 29 | 46 | 37 | 36 |
| `Bun.serve` | main | 14 | 30 | 22 | 22 |
| `Bun.serve` | PR | 14 | 30 | 22 | 22 |

Every change is within 2%. fastify and `Bun.serve` hello are lower in
both rounds, by about 1%. `Bun.serve` hello shows the same -1.0% in the
control row above, so a small real cost there is possible. The RSS pass
ran at the same time as the throughput runs, on other cores. The commits
after `8834cd0787` change tests and add one version check to the
node:http dispatcher. They were not measured.

### Supersedes

| Theme | Pull requests |
| --- | --- |
| Request body | #43592 #43579 #38196 #43518 #43602 #43408 #43427 #43597
#43555 #43456 #43466 |
| Tunnels | #43570 #43485. #43596 is a duplicate of #43570. |
| Parser | #43182 #43161 #43326 #43327 #40505 #43363 #42532 #42194 |
| Response write | #39386 #43371 #43548 #43499 #43496 #43464 #42008
#43549 |
| Response finish | #40351 #43021 #41822 #43473 #42068 #35207 #43425
#43503 |
| Lifecycle | #43413 #39686 #43028 #42727 #42622 #42610 #35837 #35839
#37825 #37749 #43376 #35268 |
| JS API | #41691 #41738 #38036 #42462 #36527 #39718 #37964. #42947
merged on its own. |

The close drain, `resetAndDestroy()`, the pending write callback
handling and the response `'close'` ordering come from #42622 and #42727
by @steipete. The diagnosis and the tests for the stalled `ws` writes
come from his #42610.

Not included:

| Pull request | Reason |
| --- | --- |
| #33061 | main already enforces `headersTimeout` and `requestTimeout` |
| #41672 | It makes `http.createServer({ key, cert })` stop serving TLS.
That needs a product decision. |
| #37543 | A type refactor with no tests and no user-visible change |
| #35465 | It makes `http.Server` extend `net.Server`. Only the
prototype chains were joined. The `net.Server` constructor never ran, so
`_handle` and `_connections` were `undefined`, and
`_emitCloseIfDrained()` emitted `'close'` on a listening server. The
server is backed by uWS, not `node:net`. |
| The `AutoFlusher` removal in #42622 | It makes `flushHeaders()` flush
at once. That is a performance change with no relation to the rest. |

### Tests

| Check | Result on a debug build (macOS arm64) | Head |
| --- | --- | --- |
| Every test file that this PR touches (28 files) | 1,866 pass, 2 fail.
The 2 failures are `serve.test.ts` "bounds memory when proxying ... to a
stalled client". They fail the same way on a debug build of main. |
`83af4da4a3`, run before the last commit of main came in |
| `test/js/third_party/express` (9 files) and the `body-parser` test |
299 pass, 0 fail | `83af4da4a3`, run before the last commit of main came
in |
| Node 25.6 against Bun, 32 scenarios from two scripts (event order,
framing, lifecycle) | No regression against Bun 1.4.3 | `0ff1a23f61` |
| Every vendored Node `test-http-*` and `test-https-*` file, plus the
`test-net-*` and `test-tls-*` files for pause, write, end and close |
535 of 537 exit 0. `test-http-agent-keepalive.js` and
`test-https-timeout.js` fail on that debug build. Both pass on every CI
lane. | `daee05fcfd` (before the rebase) |
| The tests that depend on what the kernel takes in one send, on Windows
Server 2019 x64 and Windows 11 arm64 | pass | `3eef223328` (x64),
`a29289bcc1` (arm64) |
| CI build 120191 (Linux, macOS and Windows, release and ASAN) | every
lane passed | `daee05fcfd` (before the rebase) |

Each new test fails on Bun 1.4.3, or on the commit before its fix for a
fault that this branch introduced.

The two tests over the limit are `node-http-connect.test.ts` ("tests
should run on bun") and `node-http-syscall-fault.test.ts` ("racing a
queued drain"). Each starts a debug subprocess that needs more than 5 s
on this machine. Both pass on CI.

### Changes in the last push

The branch is rebased on main (`daee05fcfd` was the head before). It is
now linear.

Four regressions against main, each with a test that fails without its
fix:

| Case | main | Before this push | Now (same as Node) |
| --- | --- | --- | --- |
| `emit('connection')` or http2 `allowHTTP1`: `res.end()` on a request
that nobody reads | `'end'`, `'close'` | No events | `'end'`, `'close'`
|
| The same server, an unread 32 MB body | 0 bytes held | 32 MB held | 0
bytes held |
| A NUL in a header value with `httpValidation: "relaxed"` (client,
`HTTPParser`, `emit('connection')` server) | Accepted | The process
spins forever | `HPE_INVALID_HEADER_TOKEN` |
| `Connection: close`, body in the same read as the head, a 20 KB
response before the body is read | `'end'` with an empty body | No
events on `req` | `'end'` with the body, `'close'` |
| An empty line on an idle keep-alive connection, then `server.close()`
| 0 s | About 6 s | 0 s |

| Fix | Where |
| --- | --- |
| The finish listener of a fallback connection dumps an unread request,
like Node's `resOnFinish` | `http1_server_fallback.ts` |
| llhttp patch: `llhttp__internal__c_test_lenient_flags_20` is false for
a NUL. The relaxed state does not consume a NUL, and the next state sent
it back there. 9.4.3 has the same loop. | `llhttp.c`, noted in its
`README.md` |
| A node:http socket that `onData` is parsing gets the close gate of
`onData`, also when a large write released the cork | `HttpResponse.h`
`uncorkCompletedResponse()` |
| A read that starts no message leaves an idle connection idle |
`HttpContext.h` `onData` |

The open review threads are fixed in `8834cd0787`:
`closeAllConnections()`, `Proxy-Connection: close`, five comments cut to
one line, and the test of two overlapping listeners, which now waits on
events. With the generation gate in `emitCloseServer` removed, that test
fails in both cases. `AsyncSocketData` keeps its bools together, which
takes it from 56 to 48 bytes per socket.

`http.Server` no longer extends `net.Server` (see "Not included"). The
special case for it in `Ipc.ts` is gone too. `child.send(msg,
httpServer)` still throws `ERR_INVALID_HANDLE_TYPE`, and its test stays.

<details><summary>Changes since the first revision (2988a61)</summary>

Merged with main at `c8e1f6fa5b`. The one conflict was #43708
(`req.socket` emits `'end'` and `'error'`). Its state bit
`HTTP_NODE_PEER_ENDED` moved to bit 22, because bit 19 is
`HTTP_NODE_NOTIFY_READ_PARSED` here. Its 15 tests run in
`node-http-server-abort-events.test.ts` next to the tests of this branch
(103 pass).

CI on `2988a610c` had ten red tests from four causes. They are fixed:
- `ed882e5e99`: `write()` to a response without a body (HEAD, 204) does
not wait for unsent bytes.
- `811f817704`: an idle tunnel does not hold the event loop after
`server.close()`. Four vendored Node tests timed out on every platform.
- `0697deec11`, `d428824c08`, `7aec062d14`: the write callback tests use
a body that backs up a loopback socket, and accept what Winsock does.
- `c7af1c1615`: two tests from main asserted the old `close()` contract.

Review findings, each reproduced against Node v26.3.0 and fixed with a
test that fails without the fix:
- `d4d2b783ea`, `2cc79939bb`, `45141abca9`, `9a63dbc470`, `80a23a1822`:
the idle rule. A keep-alive connection is idle again when its body ends
after its response. A connection that owes a queued pipelined response,
that still receives a request head or body, or whose response still
drains is not idle.
- `87d8904aa3`, `7eca4f7806`: `close(cb)` followed by `listen()` in the
same tick reports `'close'`, also for an https server whose only
connection was idle.
- `3fd7b25382`: a paused pipelined request behind a response that still
drains stops the connection. The first revision read 512 MiB of 512 MiB
into memory.
- `2d1a5e2d8d`, `33e4683a8a`, `539cb41eb9`, `197c7dfc29`, `0490e3540b`:
raw socket writes stay behind every unsent response byte. The cases were
a CONNECT pipelined behind a response that still drains (its `200`
landed at offset 2.6 MB of a 64 MiB body), a zero-length tunnel write
(it hung the tunnel), the 400 replies above, the zero-copy tail of a
large `res.write()`, the cork buffer, and Windows 11, where the kernel
takes the whole response and refuses the next send.
- `0abd39c133`: an upgrade from the request's `'end'` listener keeps the
body bytes out of the WebSocket. The connection closed with 1006 right
after the 101.
- `5aafc61aa6`: the callback of a small `res.write()` that the kernel
refuses at the uncork runs on the drain. Reproduced on Windows 11 only.
- `a29289bcc1`: a tunnel write that waits for a drain settles its
callbacks when the connection closes.

Known differences from Node that this PR leaves:
- A handler that calls `res.end()` and then `server.close()` closes its
keep-alive connection at once. Node waits for the `keepAliveTimeout`.
- A pipelined Upgrade behind a response that still drains is served as a
plain request.
- An `end()` on a tunnel with no write pending, while the response
before the CONNECT still drains, closes both directions after the flush.
Node half-closes.
- A raw `req.socket.write(big)` and `req.socket.end()` with no
`res.end()` sends every byte but no FIN. main loses bytes here.
- A CONNECT socket that is given back with `server.emit('connection',
socket)` answers only the first of several pipelined requests. main
answers none.
- A large write from an `'upgrade'` listener stalls while the body of
that Upgrade request is still pending. A second `listen()` on a
listening server does not throw. Both are the same on main.
- A tunnel write that fails because the client went away fails its
callbacks but emits no `'error'`. Node emits `ECONNRESET`. A new
`'error'` could end a process that has no listener for it.

</details>

<!-- robobun:evidence:begin -->

---

**no test proof** · iteration 8 · platform-specific test(s) that do not
run on this machine, deferring to CI, which covers all platforms:
test/js/web/fetch/fetch.stream.test.ts, test/js/node/url/url.test.ts,
test/js/node/tls/tls-syscall-fault.test.ts,
test/js/node/net/node-net-server.test.ts,
test/js/node/http/node-http.test.ts,
test/js/node/http/node-http-syscall-fault.test.ts,
test/js/node/http/node-http-server-close-drain.test.ts,
test/js/node/http/node-http-connect.test.ts,
test/js/node/http/node-http-backpressure.test.ts,
test/js/node/child_process/child_process_ipc_handle.test.ts,
test/js/bun/http/serve.test.ts,
test/js/bun/http/serve-syscall-fault.test.ts,
test/js/bun/http/bun-server.test.ts

<!-- robobun:evidence:end -->

---------

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

Superseded by #43557, which is merged (5d5f03f). It fixes this once for the whole node:http server and carries the tests over.

@robobun

robobun commented Sep 26, 2026

Copy link
Copy Markdown
Collaborator Author

Confirmed on main at 5d5f03f with a debug build of that commit.

#43543 (an Upgrade request whose body a close cuts short) still reproduces on that commit. It stays open, with the current output in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants