Skip to content

node:http: emit 'end' and 'error' on req.socket when the client closes the connection - #43708

Merged
Jarred-Sumner merged 3 commits into
mainfrom
robobun/eb612b4a/http-server-socket-fidelity
Sep 22, 2026
Merged

Jarred-Sumner merged 3 commits into
mainfrom
robobun/eb612b4a/http-server-socket-fidelity

Conversation

@robobun

@robobun robobun commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

  • req.socket of a node:http server never emits 'end' for a client FIN or 'error' for a client RST, only 'close'. Node.js v26.3.0 emits end, close for a FIN. A RST gives 'clientError' (ECONNRESET), error (read ECONNRESET), close. Cleanup on socket.once('end' | 'error') never runs.
  • Cause: HttpContext::onClose (packages/bun-uws/src/HttpContext.h:241) dropped the close code, and nothing recorded the FIN that onEnd sees. The JS socket could not tell a FIN, a RST and a local close apart.

Fix

  • onEnd records a FIN that the peer sends first in a new connection-scoped bit, HTTP_NODE_PEER_ENDED. onClose passes the read error and that bit to onSocketClosed. The native handle exposes them as closeError and peerEnded.
  • #onClose ends the readable side for a FIN, so 'end' comes before 'close'. For a read error it destroys the socket with Node's read ECONNRESET error, and socketOnError emits 'clientError'.
  • Unchanged on purpose: a close that the server starts, CONNECT and Upgrade tunnels, WebSocket connections, and a socket with no 'error' listener. No process gets a new unhandled 'error'.
  • Verified: test/js/node/http/node-http-server-abort-events.test.ts, 15 new cases. Bun 1.4.3 fails 13 of them. Other suites and Windows: Notes.

Background

  • uSockets calls on_end for a peer FIN and on_close(code) for each close. code is 0 to 2 when this side closed, else the errno of the failed read.
  • NodeHTTPServerSocket is the net.Socket subclass that handlers get. uWS parses HTTP natively, so it sees the connection only through callbacks on its native handle (JSNodeHTTPServerSocket).
  • Node's net.Socket ends the readable side on EOF. A read error destroys it with the errno exception. The http server turns that 'error' into 'clientError'.
Notes

Socket events (end, error, close on req.socket). http and https give the same result.

Client sends Connection state Node v26.3.0 and this branch Bun 1.4.3
FIN idle keep-alive, unanswered request, mid-body end, close close
RST the same three error (read ECONNRESET), close close

'clientError' gets ECONNRESET for each RST. The mid-body FIN gets HPE_INVALID_EOF_STATE, as on main.

Remaining differences from Node

  • 'end' is emitted when the connection closes, not when the FIN arrives. The two moments differ only when uWS defers the close: response bytes are still queued, or httpAllowHalfOpen is set and a response is in flight. A FIN-time 'end' would let autoDestroy close the handle after the next socket.end() while uWS still holds response bytes.
  • With a request in flight, 'error' comes after req 'aborted' and res 'close'. Node emits it before them. 'error' is still before 'close', and the req and res events keep the order they have on main.
  • 'close' has no hadError argument. It has none on main.
  • A CONNECT or Upgrade tunnel that the client resets still emits end, close. Node emits error, close.
  • After the server's own socket.end(), the FIN from the peer gives close only, over http and https, as on main. Node emits end, close. uSockets closes a socket that this side already shut down without an on_end dispatch, so this needs a change in loop.c.
  • If an error comes with the FIN, the socket emits error, close without end. That is the default 'clientError' handling of a mid-body FIN, and a FIN followed by a RST. Node emits end first, because it emits end when the FIN arrives.

Error object. The closeError getter uses read_error_from_close_code (src/runtime/socket/socket_body.rs), the mapping node:net uses, through the new export Bun__socketReadErrorFromCloseCode. Windows reports WSA codes, and this mapping turns them into the same code and errno. #onClose then builds ErrnoException(errno, "read"). For a reset on Linux, message (read ECONNRESET), code, errno, syscall and the own keys are equal to Node's.

A close that the server starts. Over TLS, uSockets defers a close(0) until the peer answers the close_notify, and that answer reaches onEnd as an EOF. The first revision of this PR recorded it as a FIN, so closeIdleConnections() and server.close() gave end, close on an https socket. The review found it. onEnd now records the FIN only while this side has not shut down. Node, Bun 1.4.3 and this branch give close only, over http and https. The two closeIdleConnections() cases in the test cover it. They pass on Bun 1.4.3 by design.

Probes (Node / Bun 1.4.3 / this branch)

  • The client half-closes right after the request and reads an 8 MB response. All three deliver all 8,388,736 bytes. Events: end close / close / end close. The same with httpAllowHalfOpen.
  • Two pipelined requests, then FIN. Both responses arrive. Events: end close / close / end close.
  • server.closeIdleConnections() and req.socket.destroy(): close only, in all three.
  • An 'upgrade' listener attaches no 'error' listener and the client resets. Node dies with an uncaught ECONNRESET. Bun 1.4.3 and this branch emit end, close.
  • Closes that are not a peer FIN or RST give the same events on Bun 1.4.3 and on this branch, over http and https: keepAliveTimeout and a socket timeout on an unanswered request (timeout, close), plaintext sent to an https server, a reset during the TLS handshake, and garbage after the handshake (close). None of them emits end or error.

Suites run with the debug build on Linux (first revision, then node-http.test.ts, node-http-with-ws, node-http-connect, node-http-server-socket-end-drain and node-http-server-timeouts again on the last revision): node-http.test.ts (163 pass), node-http-server-abort-events, node-http-with-ws, node-http-connect, node-http-req-socket-pause, node-http-backpressure, node-http-server-socket-end-drain, node-http-transfer-encoding, node-http-server-timeouts, node-http-uaf, node-http-pinned-write, node-http-maxHeaderSize, regression 32734 and 40380, the source lints, and 453 vendored test-http-* and test-https-* files. Two results are not from this change, a build of main without it gives the same: node-http-syscall-fault.test.ts ("racing a queued drain") passes the 5 s limit, and test-https-timeout.js hangs.

A second run of the vendored files on the last revision had a host load average of about 60. Besides test-https-timeout.js, five files failed in the parallel run. Three pass alone. test-http-agent-keepalive.js and test-http-client-timeout-option.js pass and fail in turn when run alone. Their failing assertions are client-side timers of 1 ms and 100 ms. Both passed in the first run.

Windows x64, debug build (first revision): the test file passes 25 of 25. The released canary fails the 13 new cases. node-http-with-ws, node-http-connect and node-http-req-socket-pause pass.

History. #32897 (June 2026, not merged) passed the close code the same way and had green CI. It emitted 'end' for each clean close, also for a close that the server started. #35025 replaced it, and that PR restored only the order of req 'error'. The socket events did not land.

…t closes the connection

uWS dropped the close code and did not record the peer's FIN, so the JS
socket could not tell a FIN, a RST and a local close apart. It emitted
only 'close'.

HttpContext now latches the FIN (HTTP_NODE_PEER_ENDED) and passes the
read error and the latch to onSocketClosed. JSNodeHTTPServerSocket keeps
both and exposes them as closeError and peerEnded. NodeHTTPServerSocket
ends its readable side for a FIN and is destroyed with the read error
for a RST, so socketOnError routes it to 'clientError' like Node.js.

CONNECT and Upgrade tunnels and WebSocket connections keep their
behavior.
@robobun

robobun commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

Status: fix pushed in #43708.

How I reproduced it (Bun 1.4.3-canary.1+367d939d9 and main, Node.js v26.3.0 for comparison):

const http = require("node:http"), net = require("node:net");
const how = process.argv[2]; // "fin" or "rst"
const seen = [];
const srv = http.createServer((req, res) => {
  for (const ev of ["end", "error", "close"]) req.socket.on(ev, e => seen.push(ev + (e?.code ? ":" + e.code : "")));
  req.resume();
  res.end("ok"); // keep-alive: the connection stays open
});
srv.on("clientError", (e, s) => { seen.push("clientError:" + e.code); s.destroy(); });
srv.listen(0, "127.0.0.1", () => {
  const c = net.connect(srv.address().port, "127.0.0.1", () => c.write("GET / HTTP/1.1\r\nHost: x\r\n\r\n"));
  c.on("error", () => {});
  c.on("data", () => (how === "rst" ? c.resetAndDestroy() : c.end()));
  setTimeout(() => { console.log(how, JSON.stringify(seen)); srv.close(); srv.closeAllConnections(); }, 400);
});
fin rst
Node v26.3.0 ["end","close"] ["clientError:ECONNRESET","error:ECONNRESET","close"]
Bun 1.4.3 ["close"] ["close"]
this branch ["end","close"] ["clientError:ECONNRESET","error:ECONNRESET","close"]

The new cases in test/js/node/http/node-http-server-abort-events.test.ts cover the same thing over http and https, for an idle connection, an unanswered request and a request with half of its body sent.

CI at ef5000d (build 119364): 180 of 181 jobs passed. The red job is test/js/bun/spawn/spawn.test.ts on debian 13 x64-asan. The child's stderr there has LeakSanitizer output (ptrace appears to be blocked). The same test is red on that lane in at least 8 other PR builds from the same hours (for example 119365, 119366, 119346), and this PR does not touch spawn. No lane reported a failure or a retry for node-http-server-abort-events.test.ts.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: oven-sh/bun/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Essentials

Run ID: c0a80102-c4e8-41af-943e-856879fe8ef5

📥 Commits

Reviewing files that changed from the base of the PR and between 49fb41c and 53c7c1c.

📒 Files selected for processing (3)
  • packages/bun-uws/src/HttpContext.h
  • src/js/node/_http_server.ts
  • test/js/node/http/node-http-server-abort-events.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


Walkthrough

Changes

The change propagates socket close errors and peer FIN state from uWS to Node HTTP sockets. Node HTTP preserves this state during deferred destruction, exposes closeError and peerEnded, and tests FIN and RST behavior for HTTP and HTTPS connections.

HTTP socket close handling

Layer / File(s) Summary
Close metadata propagation
packages/bun-uws/src/HttpContext.h, packages/bun-uws/src/HttpContextData.h, packages/bun-uws/src/HttpResponseData.h, packages/bun-uws/src/WebSocketContext.h, packages/bun-uws/src/WebSocketData.h
Socket-close callbacks now receive read-error and peer-ended values. Node HTTP records peer FIN state. Tunnels and WebSockets pass neutral values.
Native socket state and properties
src/jsc/bindings/NodeHTTP.cpp, src/jsc/bindings/node/JSNodeHTTPServerSocket.*, src/jsc/bindings/node/JSNodeHTTPServerSocketPrototype.cpp, src/runtime/socket/socket_body.rs
Native bindings store close metadata. The socket prototype exposes read-only closeError and peerEnded properties.
Stream closure and validation
src/js/node/_http_server.ts, test/js/node/http/node-http-server-abort-events.test.ts
Deferred close handling preserves the native handle and close error. Peer FIN emits readable EOF. Tests cover HTTP and HTTPS FIN and RST behavior across connection states.

Suggested reviewers: jarred-sumner, cirospaciari

Priority: ⬇️ Low

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the primary change: emitting 'end' and 'error' events on node:http request sockets when the client closes the connection.
Description check ✅ Passed The description clearly explains the problem, implementation, intended behavior, unchanged cases, and verification results. It does not use the exact template headings, but it provides the required co…

Comment @coderabbitai help to get the list of available commands.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread packages/bun-uws/src/HttpContext.h Resolved
Comment thread src/runtime/socket/socket_body.rs Resolved
Comment thread src/js/node/_http_server.ts Resolved
Comment thread src/js/node/_http_server.ts Resolved
Comment thread packages/bun-uws/src/HttpContext.h Resolved
…ape the close error like Node

TLS defers a close(0) until the peer answers the close_notify. That
answer reaches HttpContext::onEnd as an EOF, so closeIdleConnections()
and server.close() emitted 'end' before 'close' on an https socket.
onEnd now records the FIN only while this side has not shut down.

The error for a reset is built with ErrnoException, so its message is
'read ECONNRESET' like Node's errnoException, not the UVException text.
Comment thread src/js/node/_http_server.ts Resolved
Comment thread src/js/node/_http_server.ts Resolved
Comment thread src/runtime/socket/socket_body.rs Resolved

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after 53c7c1c and ef5000d: no new bugs found, but this still spans uWS, the C++ socket binding, a new Rust export and the node:http JS layer, so a human look is worthwhile.

What was reviewed:

  • The new !us_socket_is_shut_down(s) guard in HttpContext::onEnd: us_socket_is_shut_down dispatches to us_internal_ssl_is_shut_down, which checks SSL_SENT_SHUTDOWN, so the peer's close_notify reply to a server-started TLS close no longer latches HTTP_NODE_PEER_ENDED (matches the added https closeIdleConnections test).
  • The ErrnoException(errno, "read") reshape in #onClose, with the fallback to the raw sys error when the code mapping differs (Windows WSA codes).
  • OnSocketClosedCallback signature: NodeHTTP.cpp and WebSocketContext.h are the only setters/callers and both were updated; HTTP_NODE_PEER_ENDED is in HTTP_CONNECTION_SCOPED so it survives resetResponseState, and is only read once in onClose.
  • 'end'/'close' ordering: read(0) schedules endReadableNT before destroy() schedules emitCloseNT, both on nextTick, so no synchronous user code runs inside #onClose before kHandle is nulled.

The destroy()-during-the-close-window thread from the earlier review is not changed by these commits.

Extended reasoning...

The change adds a peer-FIN bit and a read-error code to uWS's HttpContext close path, threads them through JSNodeHTTPServerSocket into two new getters (one backed by a new Rust extern "C" that builds a sys::Error JS value), and has _http_server.ts emit 'end' or an errnoException-shaped 'error' before 'close'. It touches no auth, crypto or input-parsing surface; the TLS-relevant part is only the SSL_SENT_SHUTDOWN check used to distinguish a server-started close. The two follow-up commits address two of the earlier inline findings and I verified the shut-down check's SSL dispatch and the error shape; the change remains a multi-layer native+JS behavioral change with one earlier inline thread still open, which is why it is a defer rather than an approve.

@robobun

robobun commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator Author
Updated 2:26 PM PT - Sep 21st, 2026

❌ @robobun, your commit ef5000d has 1 failures in Build #119364 (All Failures):


🧪   To try this PR locally:

bunx bun-pr 43708

That installs a local version of the PR into your bun-43708 executable, so you can run:

bun-43708 --bun

@Jarred-Sumner
Jarred-Sumner merged commit 6d99e4b into main Sep 22, 2026
10 of 11 checks passed
@Jarred-Sumner
Jarred-Sumner deleted the robobun/eb612b4a/http-server-socket-fidelity branch September 22, 2026 04:07
robobun added a commit that referenced this pull request Sep 22, 2026
…-response

Conflict: HttpResponseData.h. Main (#43708) took state bit 19 for
HTTP_NODE_PEER_ENDED, which this branch used for HTTP_LINGERING_CLOSE. Keep
both: HTTP_LINGERING_CLOSE moves to bit 20.
robobun added a commit that referenced this pull request Sep 24, 2026
…complete-while-paused

Conflicts with #43708 (req.socket emits 'end' and 'error' when the client
closes the connection):

- HttpResponseData.h: HTTP_NODE_PEER_ENDED moves to bit 22. Bit 19 is
  HTTP_NODE_NOTIFY_READ_PARSED on this branch.
- HttpContext.h onEnd: the FIN is recorded first, then the fin of a request
  body with no framing is delivered, then onClientError runs.
- _http_server.ts: #closeHandle keeps resetAndClosing and passes the handle
  to #onCloseForDestroy. #onClose keeps its run-once guard and the tracked
  connection bookkeeping of this branch, and takes the peer FIN and read
  error handling from main.
- JSNodeHTTPServerSocket.h and the prototype: both sets of members and
  declarations stay.
- node-http-server-abort-events.test.ts: the file of this branch, plus the
  describe block that main added, with the import names of this branch.
Jarred-Sumner added a commit that referenced this pull request Sep 26, 2026
…inish, lifecycle) (#43557)

One pull request for the open `node:http` server pull requests. Each
root cause is fixed once, and each pull request's tests are carried
over. Node is the reference: every scenario was run under Node and under
Bun from one script, and the outputs were compared.

Fixes #4733
Fixes #18613
Fixes #40350
Fixes #43155
Fixes #43297
Fixes #43513
Fixes #43527
Fixes #25632
Fixes #31301
Fixes #43027
Fixes #43163
Fixes #43342
Fixes #43344
Fixes #43370
Fixes #43490
Fixes #43512
Fixes #43519

Each of these has a repro that is wrong on Bun 1.4.3, right on this
branch, and the same as Node.

| Issue | Not closed by this PR, because |
| --- | --- |
| #30501 (msal-node keeps Bun alive at exit) | Probably fixed. The repro
copies the teardown of msal-node. The package itself was not run. |
| #14430 (yarn: "does not support SSL") | Probably fixed.
`response.hasOwnProperty("socket")` is now `true`. yarn itself was not
run. |
| #39681 (`server.setTimeout` callback after destroy) | Probably fixed.
The repro is the deterministic case of #39686. The script in the issue
depends on timing and on Windows. |
| #43455 (`req.complete`, nine flows) | Partially addressed. Flows 1, 2,
3, 5 and 7 are fixed, and flow 6 was already right. Flow 8 (a socket
timeout while the body of an Upgrade request arrives) and flow 9 (a
request that `stream.pipeline()` destroyed never reports `complete`) are
not. Flow 4 differs only in `_readableState.ended`. |

### What changes for users

| Area | Before | After (same as Node) |
| --- | --- | --- |
| `req.pause()` | The socket stops at once. `req.complete` stays `false`
for a small body. | The body is received until the buffer is full. Then
the socket stops. |
| `res.end()` before the body arrives | `req` gets `'end'` and `'close'`
at once, and the body is lost | The request completes when its body
really ends |
| `res.destroy()` in the middle of a body | `'end'` with bytes missing |
`aborted`, then `ECONNRESET` |
| `socket.destroy()` inside the `'request'` listener | The body that
came with the head is dropped | That body is still delivered |
| `'finish'` and the `end()` callback | Fire when `end()` buffers the
bytes | Fire when the last bytes have left the socket |
| A response that closes the connection | The server half-closes and
waits for the peer | The socket closes right behind the FIN |
| `'drain'` after a later write flushed the backlog | Lost. `pipe(res)`
could hang. | Emitted |
| A pipelined request whose body continues after the previous response
ends | Body dropped, no response, `server.close()` hangs | Delivered |
| CONNECT and Upgrade tunnel sockets | Keep reading when paused or full
| Stop reading. `_read()` starts them again. |
| A tunnel write that waits for a drain when the client goes away | Its
callback, the callbacks of the writes behind it and the `end()` callback
never run | They run with an error before `'close'` |
| Upgrade request with a body, paused in its listener | The body flows
away | The request keeps its body |
| `ws` on a reused keep-alive socket | Writes after the Upgrade could
stall | Sent |
| A raw `socket.write()` behind a response that still drains (the 400
for a bad pipelined request, the reply of a `'clientError'` listener) |
Lands in the middle of that response | Sent after it |
| `server.close()` | Could report closed while connections were open |
Waits for every connection. An idle tunnel does not keep the process
alive. |
| `closeAllConnections()` on a listening server | Also stops the
listener and destroys tunnels and WebSockets | Destroys only the HTTP
connections |
| `Proxy-Connection: close` (node:http only) | Ignored. The connection
stays open. | Ends the connection, like `Connection: close` |
| A response larger than 16 KB, also in `Bun.serve` and over TLS | Up to
4 `send()` calls for each chunk. Slower than Node in most cases. | One
write for the writes of one tick. 1.1x to 2.7x the requests per second
of main, and faster than Node. |
| `socket.destroy()` and then `res.end()` in a listener | (this PR,
earlier) `req` ended as if it were complete | `'aborted'`, then
`ECONNRESET` |
| `emit('connection')` or http2 `allowHTTP1`: the response ends while
the listener still reads the body | The rest of the body is dropped |
The body is complete |
| `httpValidation: "relaxed"`, `Content-Length` or `Transfer-Encoding`
in trailers | Accepted | `HPE_INVALID_CONTENT_LENGTH`,
`HPE_INVALID_TRANSFER_ENCODING` |
| `req.complete` inside `'connect'`, and inside `'upgrade'` without a
body | `false` | `true` |
| `optimizeEmptyRequests`: `socket.parser.incoming` after the response |
Keeps the request alive on an idle connection | `null` |
| A HEAD or OPTIONS request with `Content-Length` | The body is dropped,
and `req.complete` is `true` before it comes | The request has its body
|
| `res.end(chunk)` after the client went away | `finished` and
`writableEnded` stay `false`, no `'prefinish'` | The response ends |
| An HTTP/1.0 request with an `Expect` header | `100 Continue`,
`'checkContinue'`, `'checkExpectation'` or a 417 | A plain `'request'` |
| The idle sweep of `close()` and `closeIdleConnections()` | Could
destroy a connection that was still receiving a request, or whose
response was still draining | Closes only idle connections |

### Design

| Piece | What it is |
| --- | --- |
| Request body state | `None / Pending / Complete / Aborted / Upgraded /
Detached`. Only the last chunk sets `Complete`. One function,
`leave_pending`, is the only other way out of `Pending`. |
| Read flow control | One path: `push()` returning false stops the
socket, `_read()` starts it. Both native pause buffers are removed: no
read is copied and replayed. |
| "This read is parsed" signal | `notifyWhenReadParsed()` sets a uws
state bit. uws delivers a `readParsed` event after the read. It replaces
a `setImmediate`. |
| Close during a parse | One uws bit defers a close to the end of the
current message. |
| Response finish | A response is finished when it has ended and the
socket has fully drained. |
| Idle connection | One rule, `HttpResponse::closeIfIdle()`. A
connection is idle when it receives no request (head or body) and no
response is in flight, queued or undrained. The sweep of `close()` and
`closeIdleConnections()` both use it. |
| Idle tunnel | A tunnel at read EOF with nothing left to send. uws
reports it to the server through the connection filter (`-3`, `+3`,
`-4`). It still counts for `'close'`, but it does not hold the event
loop, like a libuv handle in that state. |
| Server `'close'` | One native close promise per `listen()`. `close()`
records whether its sweep left nothing open. Then a `listen()` in the
same tick cannot hold `'close'` back, as in
`net.Server._emitCloseIfDrained`. |
| Raw socket writes | While uws holds response bytes (its buffer, the
zero-copy tail of a `res.write()`, the cork buffer), a raw write goes
through `AsyncSocket::write`, the path a 1xx line takes. So the order on
the wire is the order of the calls. |
| Upgrade verdict | One scanner and one verdict, shared by the parser
and the dispatcher. |
| llhttp | Updated from 9.3.0 to 9.4.2, as Node v26.5.0 vendors it, plus
one local patch (see below). Node v26.5.1 and later vendor 9.4.3. That
update is not in this PR. |

The parser changes also tighten request framing so that it agrees with
llhttp in more cases. There is no new API surface.

### A pause holds from the next read

The copy of the rest of a read (`nodeHttpPausedSpill`), its replay from
a posted task and the nested parse are removed. Like in Node, the rest
of the read that caused a pause is still parsed, and the socket stops at
the next read. usockets reads up to 512 KB in one call. libuv reads 64
KB.

| One paused, unread request (client sends 64 MB) | Bytes held |
| --- | --- |
| Node 25.6 | 131,018 |
| This pull request | 524,234 |

The price is in one case. A client sends 512 KB of small pipelined
requests (19,418 of them) and never reads. Each handler answers with its
own 64 KB body:

| Handler | Runtime | Requests dispatched | RSS |
| --- | --- | --- | --- |
| Answers at once | Node 26.3 | 2,425 | +177 MB |
| Answers at once | main | 41 | +9 MB |
| Answers at once | This PR | 2,425 | +171 MB |
| Answers one tick later | Node 26.3 | 4,850 | +336 MB |
| Answers one tick later | main | 2,426 | +181 MB |
| Answers one tick later | This PR | 4,850 | +330 MB |

Release builds on Linux x64. This PR now does what Node does. main held
fewer responses, mostly for a handler that answers at once. On macOS one
read can return all 512 KB. There, Bun 1.4.3 already reached +951 MB for
the handler that answers one tick later, and Node reached +1,294 MB.
`server.maxRequestsPerSocket` bounds it.

### Performance

#### Responses larger than 16 KB are faster, and now faster than Node

On main, a response that did not fit the 16 KB uWS cork buffer released
the cork. After that, each piece was its own `send()`: the buffered
head, the chunk-size line, the data, the `\r\n` and the last chunk. Over
TLS, each 2-byte piece was also its own record. Two changes fix that,
for `Bun.serve` and for node:http:

| Change | Effect |
| --- | --- |
| A write that does not fit goes out with the cork buffer and its
framing in one vectored write | No copy is added. Over TLS, the records
of all the pieces share the write batch that one `SSL_write` loop
already had. |
| The cork buffer holds 128 KB, up from 16 KB. Only a write of 16 KB or
less is copied into it, as before. | Several writes in one tick go out
in one write, like in Node. A longer write still goes out without a
copy. |

The bytes on the wire are the same. The vectored write uses `sendmsg()`
with the flags that `send()` uses.

Write syscalls for one response:

| Response | Node 26.3 | main | This PR |
| --- | --- | --- | --- |
| 4 x `res.write(16 KB)` | 1 | 16 | 1 |
| 40 x `res.write(2 KB)` | 1 | 16 | 1 |
| `res.end(64 KB)` | 1 | 2 | 1 |
| 256 KB file, `.pipe(res)` | 4 | 16 | 5 |

Throughput (req/s, the mean of 2 rounds). Node v26.3.0, main
`97246d044e`, this PR `fe0ed1fbea`, with the method below:

| Case | Node | main | This PR | main / Node | PR / Node | PR / main |
| --- | --- | --- | --- | --- | --- | --- |
| http, 4 x `res.write(16 KB)` | 17,735 | 6,983 | 19,160 | 0.39x | 1.08x
| 2.74x |
| https, 4 x `res.write(16 KB)` | 11,720 | 6,110 | 15,510 | 0.52x |
1.32x | 2.54x |
| http, 40 x `res.write(2 KB)` | 9,879 | 6,140 | 14,980 | 0.62x | 1.52x
| 2.44x |
| https, 40 x `res.write(2 KB)` | 6,981 | 5,541 | 11,780 | 0.79x | 1.69x
| 2.13x |
| http, `res.end(64 KB)` | 18,535 | 16,528 | 19,889 | 0.89x | 1.07x |
1.20x |
| http, 256 KB file `.pipe(res)` | 2,684 | 2,375 | 2,719 | 0.88x | 1.01x
| 1.15x |
| https, `res.end(64 KB)` | 11,894 | 14,586 | 16,426 | 1.23x | 1.38x |
1.13x |
| http, GET hello (control) | 55,994 | 70,989 | 71,958 | 1.27x | 1.29x |
1.01x |

main was slower than Node in six of these eight cases. This PR is faster
than Node in all eight.

`Bun.serve`, measured on `a771572a8d`, before the larger cork buffer
(req/s, the mean of 2 rounds):

| Case | main | PR | Change |
| --- | --- | --- | --- |
| Direct stream, 4 x 16 KB | 6,826 | 12,479 | +83% |
| 64 KB string | 16,944 | 20,145 | +19% |
| TLS, 64 KB string | 15,045 | 16,892 | +12% |
| hello (control) | 83,957 | 83,137 | -1.0% |

These runs are on loopback, where the kernel send buffer is 2.6 MB and
the work of the receiver runs inside `send()`. That is the best case for
fewer writes. A new connection over a real network takes about 46 KB in
its first write on Linux. The rest waits in the socket buffer, as it
would after separate writes.

#### Small responses are unchanged

A small response is already one `recvfrom` and one `sendto` on both
builds. `perf` puts 66% of the time of a hello-world server in the
kernel, on both builds.

CI release builds on Linux x64: main `97246d044e` (the merge base)
against this PR `8834cd0787`. Both use the same WebKit. The server runs
on one pinned core. `oha` sends 64 connections for 5 s after a 2 s
warm-up. There are 2 rounds, and the order of the builds alternates.
"Change" compares the means of the two rounds.

Framework servers from `bun-perf-tester` (req/s):

| Server | main, round 1 | main, round 2 | PR, round 1 | PR, round 2 |
Change |
| --- | --- | --- | --- | --- | --- |
| express | 49,803 | 51,103 | 49,968 | 50,263 | -0.7% |
| fastify | 61,214 | 61,105 | 60,705 | 60,668 | -0.8% |
| node:http | 70,934 | 71,405 | 73,178 | 71,053 | +1.3% |
| elysia | 84,696 | 85,096 | 85,027 | 84,882 | +0.1% |
| `Bun.serve` | 89,020 | 89,099 | 88,168 | 88,373 | -0.9% |

node:http paths that this PR changes (req/s):

| Case | main, round 1 | main, round 2 | PR, round 1 | PR, round 2 |
Change |
| --- | --- | --- | --- | --- | --- |
| GET hello | 70,226 | 70,341 | 70,151 | 72,359 | +1.4% |
| POST, 16 KB body | 47,446 | 47,789 | 48,191 | 48,785 | +1.8% |
| 64 KB response in four writes | 6,885 | 6,894 | 6,834 | 6,868 | -0.6%
|
| Pipelined keep-alive, depth 8 | 94,063 | 93,294 | 92,909 | 93,809 |
-0.3% |

p99 latency (ms), the higher of the two rounds:

| Server | main | PR |
| --- | --- | --- |
| express | 1.94 | 1.91 |
| fastify | 1.52 | 1.55 |
| node:http | 1.11 | 1.12 |
| elysia | 0.98 | 0.96 |
| `Bun.serve` | 0.82 | 0.83 |

RSS (MB), one pass of 8 s of load:

| Server | Build | Start | Under load | 5 s idle | 15 s idle |
| --- | --- | --- | --- | --- | --- |
| express | main | 39 | 94 | 61 | 57 |
| express | PR | 40 | 92 | 60 | 57 |
| fastify | main | 41 | 91 | 58 | 55 |
| fastify | PR | 41 | 91 | 58 | 55 |
| node:http | main | 20 | 64 | 43 | 40 |
| node:http | PR | 20 | 65 | 45 | 41 |
| elysia | main | 28 | 46 | 36 | 35 |
| elysia | PR | 29 | 46 | 37 | 36 |
| `Bun.serve` | main | 14 | 30 | 22 | 22 |
| `Bun.serve` | PR | 14 | 30 | 22 | 22 |

Every change is within 2%. fastify and `Bun.serve` hello are lower in
both rounds, by about 1%. `Bun.serve` hello shows the same -1.0% in the
control row above, so a small real cost there is possible. The RSS pass
ran at the same time as the throughput runs, on other cores. The commits
after `8834cd0787` change tests and add one version check to the
node:http dispatcher. They were not measured.

### Supersedes

| Theme | Pull requests |
| --- | --- |
| Request body | #43592 #43579 #38196 #43518 #43602 #43408 #43427 #43597
#43555 #43456 #43466 |
| Tunnels | #43570 #43485. #43596 is a duplicate of #43570. |
| Parser | #43182 #43161 #43326 #43327 #40505 #43363 #42532 #42194 |
| Response write | #39386 #43371 #43548 #43499 #43496 #43464 #42008
#43549 |
| Response finish | #40351 #43021 #41822 #43473 #42068 #35207 #43425
#43503 |
| Lifecycle | #43413 #39686 #43028 #42727 #42622 #42610 #35837 #35839
#37825 #37749 #43376 #35268 |
| JS API | #41691 #41738 #38036 #42462 #36527 #39718 #37964. #42947
merged on its own. |

The close drain, `resetAndDestroy()`, the pending write callback
handling and the response `'close'` ordering come from #42622 and #42727
by @steipete. The diagnosis and the tests for the stalled `ws` writes
come from his #42610.

Not included:

| Pull request | Reason |
| --- | --- |
| #33061 | main already enforces `headersTimeout` and `requestTimeout` |
| #41672 | It makes `http.createServer({ key, cert })` stop serving TLS.
That needs a product decision. |
| #37543 | A type refactor with no tests and no user-visible change |
| #35465 | It makes `http.Server` extend `net.Server`. Only the
prototype chains were joined. The `net.Server` constructor never ran, so
`_handle` and `_connections` were `undefined`, and
`_emitCloseIfDrained()` emitted `'close'` on a listening server. The
server is backed by uWS, not `node:net`. |
| The `AutoFlusher` removal in #42622 | It makes `flushHeaders()` flush
at once. That is a performance change with no relation to the rest. |

### Tests

| Check | Result on a debug build (macOS arm64) | Head |
| --- | --- | --- |
| Every test file that this PR touches (28 files) | 1,866 pass, 2 fail.
The 2 failures are `serve.test.ts` "bounds memory when proxying ... to a
stalled client". They fail the same way on a debug build of main. |
`83af4da4a3`, run before the last commit of main came in |
| `test/js/third_party/express` (9 files) and the `body-parser` test |
299 pass, 0 fail | `83af4da4a3`, run before the last commit of main came
in |
| Node 25.6 against Bun, 32 scenarios from two scripts (event order,
framing, lifecycle) | No regression against Bun 1.4.3 | `0ff1a23f61` |
| Every vendored Node `test-http-*` and `test-https-*` file, plus the
`test-net-*` and `test-tls-*` files for pause, write, end and close |
535 of 537 exit 0. `test-http-agent-keepalive.js` and
`test-https-timeout.js` fail on that debug build. Both pass on every CI
lane. | `daee05fcfd` (before the rebase) |
| The tests that depend on what the kernel takes in one send, on Windows
Server 2019 x64 and Windows 11 arm64 | pass | `3eef223328` (x64),
`a29289bcc1` (arm64) |
| CI build 120191 (Linux, macOS and Windows, release and ASAN) | every
lane passed | `daee05fcfd` (before the rebase) |

Each new test fails on Bun 1.4.3, or on the commit before its fix for a
fault that this branch introduced.

The two tests over the limit are `node-http-connect.test.ts` ("tests
should run on bun") and `node-http-syscall-fault.test.ts` ("racing a
queued drain"). Each starts a debug subprocess that needs more than 5 s
on this machine. Both pass on CI.

### Changes in the last push

The branch is rebased on main (`daee05fcfd` was the head before). It is
now linear.

Four regressions against main, each with a test that fails without its
fix:

| Case | main | Before this push | Now (same as Node) |
| --- | --- | --- | --- |
| `emit('connection')` or http2 `allowHTTP1`: `res.end()` on a request
that nobody reads | `'end'`, `'close'` | No events | `'end'`, `'close'`
|
| The same server, an unread 32 MB body | 0 bytes held | 32 MB held | 0
bytes held |
| A NUL in a header value with `httpValidation: "relaxed"` (client,
`HTTPParser`, `emit('connection')` server) | Accepted | The process
spins forever | `HPE_INVALID_HEADER_TOKEN` |
| `Connection: close`, body in the same read as the head, a 20 KB
response before the body is read | `'end'` with an empty body | No
events on `req` | `'end'` with the body, `'close'` |
| An empty line on an idle keep-alive connection, then `server.close()`
| 0 s | About 6 s | 0 s |

| Fix | Where |
| --- | --- |
| The finish listener of a fallback connection dumps an unread request,
like Node's `resOnFinish` | `http1_server_fallback.ts` |
| llhttp patch: `llhttp__internal__c_test_lenient_flags_20` is false for
a NUL. The relaxed state does not consume a NUL, and the next state sent
it back there. 9.4.3 has the same loop. | `llhttp.c`, noted in its
`README.md` |
| A node:http socket that `onData` is parsing gets the close gate of
`onData`, also when a large write released the cork | `HttpResponse.h`
`uncorkCompletedResponse()` |
| A read that starts no message leaves an idle connection idle |
`HttpContext.h` `onData` |

The open review threads are fixed in `8834cd0787`:
`closeAllConnections()`, `Proxy-Connection: close`, five comments cut to
one line, and the test of two overlapping listeners, which now waits on
events. With the generation gate in `emitCloseServer` removed, that test
fails in both cases. `AsyncSocketData` keeps its bools together, which
takes it from 56 to 48 bytes per socket.

`http.Server` no longer extends `net.Server` (see "Not included"). The
special case for it in `Ipc.ts` is gone too. `child.send(msg,
httpServer)` still throws `ERR_INVALID_HANDLE_TYPE`, and its test stays.

<details><summary>Changes since the first revision (2988a61)</summary>

Merged with main at `c8e1f6fa5b`. The one conflict was #43708
(`req.socket` emits `'end'` and `'error'`). Its state bit
`HTTP_NODE_PEER_ENDED` moved to bit 22, because bit 19 is
`HTTP_NODE_NOTIFY_READ_PARSED` here. Its 15 tests run in
`node-http-server-abort-events.test.ts` next to the tests of this branch
(103 pass).

CI on `2988a610c` had ten red tests from four causes. They are fixed:
- `ed882e5e99`: `write()` to a response without a body (HEAD, 204) does
not wait for unsent bytes.
- `811f817704`: an idle tunnel does not hold the event loop after
`server.close()`. Four vendored Node tests timed out on every platform.
- `0697deec11`, `d428824c08`, `7aec062d14`: the write callback tests use
a body that backs up a loopback socket, and accept what Winsock does.
- `c7af1c1615`: two tests from main asserted the old `close()` contract.

Review findings, each reproduced against Node v26.3.0 and fixed with a
test that fails without the fix:
- `d4d2b783ea`, `2cc79939bb`, `45141abca9`, `9a63dbc470`, `80a23a1822`:
the idle rule. A keep-alive connection is idle again when its body ends
after its response. A connection that owes a queued pipelined response,
that still receives a request head or body, or whose response still
drains is not idle.
- `87d8904aa3`, `7eca4f7806`: `close(cb)` followed by `listen()` in the
same tick reports `'close'`, also for an https server whose only
connection was idle.
- `3fd7b25382`: a paused pipelined request behind a response that still
drains stops the connection. The first revision read 512 MiB of 512 MiB
into memory.
- `2d1a5e2d8d`, `33e4683a8a`, `539cb41eb9`, `197c7dfc29`, `0490e3540b`:
raw socket writes stay behind every unsent response byte. The cases were
a CONNECT pipelined behind a response that still drains (its `200`
landed at offset 2.6 MB of a 64 MiB body), a zero-length tunnel write
(it hung the tunnel), the 400 replies above, the zero-copy tail of a
large `res.write()`, the cork buffer, and Windows 11, where the kernel
takes the whole response and refuses the next send.
- `0abd39c133`: an upgrade from the request's `'end'` listener keeps the
body bytes out of the WebSocket. The connection closed with 1006 right
after the 101.
- `5aafc61aa6`: the callback of a small `res.write()` that the kernel
refuses at the uncork runs on the drain. Reproduced on Windows 11 only.
- `a29289bcc1`: a tunnel write that waits for a drain settles its
callbacks when the connection closes.

Known differences from Node that this PR leaves:
- A handler that calls `res.end()` and then `server.close()` closes its
keep-alive connection at once. Node waits for the `keepAliveTimeout`.
- A pipelined Upgrade behind a response that still drains is served as a
plain request.
- An `end()` on a tunnel with no write pending, while the response
before the CONNECT still drains, closes both directions after the flush.
Node half-closes.
- A raw `req.socket.write(big)` and `req.socket.end()` with no
`res.end()` sends every byte but no FIN. main loses bytes here.
- A CONNECT socket that is given back with `server.emit('connection',
socket)` answers only the first of several pipelined requests. main
answers none.
- A large write from an `'upgrade'` listener stalls while the body of
that Upgrade request is still pending. A second `listen()` on a
listening server does not throw. Both are the same on main.
- A tunnel write that fails because the client went away fails its
callbacks but emits no `'error'`. Node emits `ECONNRESET`. A new
`'error'` could end a process that has no listener for it.

</details>

<!-- robobun:evidence:begin -->

---

**no test proof** · iteration 8 · platform-specific test(s) that do not
run on this machine, deferring to CI, which covers all platforms:
test/js/web/fetch/fetch.stream.test.ts, test/js/node/url/url.test.ts,
test/js/node/tls/tls-syscall-fault.test.ts,
test/js/node/net/node-net-server.test.ts,
test/js/node/http/node-http.test.ts,
test/js/node/http/node-http-syscall-fault.test.ts,
test/js/node/http/node-http-server-close-drain.test.ts,
test/js/node/http/node-http-connect.test.ts,
test/js/node/http/node-http-backpressure.test.ts,
test/js/node/child_process/child_process_ipc_handle.test.ts,
test/js/bun/http/serve.test.ts,
test/js/bun/http/serve-syscall-fault.test.ts,
test/js/bun/http/bun-server.test.ts

<!-- robobun:evidence:end -->

---------

Co-authored-by: Jarred Sumner <jarred@jarredsumner.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants