Skip to content

STYLE: dont use pd api types in tests #39293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
Jan 21, 2021
Merged

STYLE: dont use pd api types in tests #39293

merged 81 commits into from
Jan 21, 2021

Conversation

nofarm3
Copy link
Contributor

@nofarm3 nofarm3 commented Jan 20, 2021 •
edited
Loading

I didn't add a whatsnew entry since it's only style fixes.
I'll open a new issue regarding @jreback suggestion to ban this with a precommit style rule.
I prefer it to be done in a different PR.

@nofarmish
STYLE: remove use in pd.api.dtype in test_ufunc.py (pandas-dev#39203)
05d984d
@nofarmish
STYLE: remove use in pd.api.dtype in test_integer.py (pandas-dev#39203)
2cf8a03
@nofarmish
STYLE: remove use in pd.api.dtype in doc-string in inference.py (pand…
3df6018 
…as-dev#39203)
@nofarmish
STYLE: remove use in pd.api.dtype in json/array.py (pandas-dev#39203)
258e70c
@nofarmish
STYLE: remove use in pd.api.dtype in test_floating.py (pandas-dev#39203)
644c9fb
@nofarmish
STYLE: remove use in pd.api.dtype in list/array.py (pandas-dev#39203)
a48fb73
@nofarmish
STYLE: remove use in pd.api.dtype in dtype.py (pandas-dev#39203)
8aa77e6
@nofarmish
STYLE: remove use in pd.api.dtype in test_bool.py (pandas-dev#39203)
3e03fd5
@nofarmish
STYLE: remove use in pd.api.dtype in reshape.py (pandas-dev#39203)
91467ad
@nofarmish
STYLE: remove use in pd.api.dtype in arrow/arrays.py (pandas-dev#39203)
acea340
@nofarmish
STYLE: remove use in pd.api.dtype from doc-string and add import in g…
058e1ae 
…eneric.py (pandas-dev#39203)
@nofarmish
STYLE: remove use in pd.api.dtype in decimal/array.py (pandas-dev#39203)
544d6f8
@nofarmish
STYLE: remove extra line (pandas-dev#39203)
5fed74f
@nofarmish
STYLE: run precommit hook to fix import locations (pandas-dev#39203)
5caa14c
@jreback jreback changed the title Issue 39203 dont use pd api types in tests STYLE: dont use pd api types in tests Jan 20, 2021
@jreback jreback added the Code Style Code style, linting, code_checks label Jan 20, 2021
jreback
jreback requested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. one comment. ping on green. you can add a precommit rule in this PR or as a followup.

@simonjayhawkins simonjayhawkins added this to the 1.3 milestone Jan 20, 2021
@MarcoGorelli
Copy link
Member

Thanks @nofarm3

I'll open a new issue regarding @jreback suggestion to ban this with a precommit style rule.
I prefer it to be done in a different PR.

Any chance this could be done in the same PR, so that it can be seen to be fixed? This is analogous to adding tests in the same PR in which one fixes a bug

@nofarm3
Copy link
Contributor Author

nofarm3 commented Jan 20, 2021

@MarcoGorelli
Yes it make sense. no problem I'll add this to this PR.

@MarcoGorelli
Copy link
Member

sure - do ask if it's not something you're familiar with, I think it should be enough to just add a line to the non-standard-imports-in-tests hook

@nofarm3
Copy link
Contributor Author

nofarm3 commented Jan 20, 2021

@MarcoGorelli
I added a hook that validates there is no usage in pd.api.types under pandas/tests/.
Do you think it's good enough for now?

MarcoGorelli
MarcoGorelli suggested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @nofarm3 ! Just one small comment, then I think it's good to go

jreback
jreback reviewed Jan 20, 2021
View reviewed changes
jorisvandenbossche and others added 25 commits January 21, 2021 11:29
@jorisvandenbossche @nofarmish
REGR: fix numpy accumulate ufuncs for DataFrame (pandas-dev#39260)
4d50974
@jbrockmendel @nofarmish
CI: skip checking freq on flaky pytables test (pandas-dev#39262)
8fb52ae
@ivanovmg @nofarmish
CLN: remove pd import in pandas/core/computation (pandas-dev#39268)
be6c41c 
* CLN: avoid pd import in computation/expr.py

* CLN: avoid pd import in computation/pytables
@jbrockmendel @nofarmish
REF: roll IntBlock, BoolBlock, ComplexBlock into NumericBlock (pandas…
fb3d431 
…-dev#39236)
@jbrockmendel @nofarmish
CLN: remove unused axis kwarg from Block.putmask (pandas-dev#39238)
4aff972
@twoertwein @nofarmish
CLN: use getvalue instead of seek(0)+read() (pandas-dev#39213)
77b3950
@ivanovmg @nofarmish
REF: extract classes in pandas/core/describe.py (pandas-dev#39186)
5dc9e15
@rhshadrach @nofarmish
BUG: DataFrame.apply axis=1 for str ops with no axis argument (pandas…
ad32e00 
…-dev#39212)
@moink @nofarmish
TST GH26807 Break up test_strings (pandas-dev#39215)
171112e
@jbrockmendel @nofarmish
BUG: GroupBy.idxmax/idxmin with EA dtypes (pandas-dev#38733)
594724a
@jbrockmendel @nofarmish
API/BUG: treat different UTC tzinfos as equal (pandas-dev#39216)
0ec3ccc
@MarcoGorelli @nofarmish
CLN refactor rest of core (pandas-dev#37586)
de3ca00
@tushushu @nofarmish
fix series.isin slow issue with Dtype IntegerArray (pandas-dev#38379)
85e4004
@jorisvandenbossche @nofarmish
DEPR: raise deprecation warning in numpy ufuncs on DataFrames if not …
05d82ac 
…aligned + fallback to <1.2.0 behaviour (pandas-dev#39239)
@simonjayhawkins @nofarmish
DOC: Start v1.2.2 release notes (pandas-dev#39234)
f9c6977
@jbrockmendel @nofarmish
ENH: cast instead of raise for IntervalIndex setops with differnet cl…
b8105bc 
…osed (pandas-dev#39267)
@ivanovmg @nofarmish
REF: split describe categorical function (pandas-dev#39287)
ad4dfff
@luckyvs1 @nofarmish
TST: Add test to ensure DF describe does not throw an error (pandas-d…
62e499b 
…ev#32409) (pandas-dev#38403)
@jbrockmendel @nofarmish
REF: share PeriodArray.asfreq with Period.asfreq (pandas-dev#39277)
6abf551
@jbrockmendel @nofarmish
ENH: Period comparisons with mismatched freq use py3 behavior (pandas…
75a485c 
…-dev#39274)
@lithomas1 @nofarmish
PERF: cythonize kendall correlation (pandas-dev#39132)
d61a518
@jbrockmendel @nofarmish
ENH: Make Timestamp implementation bounds match DatetimeArray/Datetim…
794e32b 
…eIndex/Series (pandas-dev#39245)
@gustavocmaciel @nofarmish
CLN: consistently put '|' at start of line in pygrep hooks pandas-dev…
a926d4b 
…#39301 (pandas-dev#39304)
@jbrockmendel @nofarmish
BUG: date_range hitting iNaT (pandas-dev#39308)
9b150ed
@nofarmish
Merge remote-tracking branch 'origin/issue-39203-dont-use-pd-api-type…
f53eab8 
…s-in-tests' into issue-39203-dont-use-pd-api-types-in-tests

# Conflicts:
#	.pre-commit-config.yaml
@jreback jreback merged commit cb0d339 into pandas-dev:master Jan 21, 2021
@jreback
Copy link
Contributor

jreback commented Jan 21, 2021

thanks @nofarm3

@nofarm3 nofarm3 deleted the issue-39203-dont-use-pd-api-types-in-tests branch January 21, 2021 17:30
@MarcoGorelli MarcoGorelli mentioned this pull request Jan 16, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli requested changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

STYLE: dont' use pd.api.types anywhere in tests