Skip to content

Missing f prefix on f-strings fix #5726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

code-review-doctor
Copy link
Contributor

Fixes #5725

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #5726 (30e2d92) into main (162ad6c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5726   +/-   ##
=======================================
  Coverage   88.90%   88.90%           
=======================================
  Files          75       75           
  Lines       13738    13738           
=======================================
  Hits        12214    12214           
  Misses       1524     1524           
Impacted Files Coverage Δ
pymc/data.py 83.61% <0.00%> (ø)

@canyon289 canyon289 merged commit e4ec363 into pymc-devs:main Apr 24, 2022
fonnesbeck added a commit that referenced this pull request May 6, 2022
* Refactor get_tau_sigma to handle lists

* Fixed syntax error

* Black formatted

* Change assertions to ValueError raises

* Prior predictions constant data (#5723)

* support return constant_data with prior pred

* pre-commit format

* added test

* code review

* Fix issue probably-meant-fstring found at https://codereview.doctor (#5726)

* Add coords argument to pymc.set_data (#5588)


Co-authored-by: Oriol (ZBook) <[email protected]>

* remove MultinomialRV override

* ⬆️ UPGRADE: Autoupdate pre-commit config

* Group GaussianRandomWalk tests in single class

* Infer steps from shape in GaussianRandomWalk

* Unpin upper limit on numpydoc

Closes #5401

* ⬆️ UPGRADE: Autoupdate pre-commit config

* Standardize docstrings of input dists arguments and add warning about cloning

* Remove unnecessary tag in Simulator logp

* Replace deprecated tag.ignore_logprob

* Group compile_pymc tests in own class

* Remove remaining uses of default_updates in codebase

* Remove redundant/wrong docstrings from GaussianRandomWalk logp

* Add moment to GaussianRandomWalk and fix mu/sigma broadcasting bug

* Do not create temporary SymbolicDistribution just to retrieve number of RNGs needed

Reordered methods for consistency

* Move SymbolicDistribution docstring to body of class

* Refactor AR distribution

* Deprecates AR1 distribution
* Implements random and moment methods
* Batching works on the left as with other distributions

* Rename `pandas_to_array` to `convert_observed_data`

* Obtain step information from dims and observed

* Make AR steps extend shape beyond initial_dist

This is consistent with the meaning of steps in the GaussianRandomWalk and translates directly to the number of scan steps taken

Co-authored-by: TimOliverMaier <[email protected]>
Co-authored-by: code-review-doctor <[email protected]>
Co-authored-by: Somasree Majumder <[email protected]>
Co-authored-by: Oriol (ZBook) <[email protected]>
Co-authored-by: danhphan <[email protected]>
Co-authored-by: twiecki <[email protected]>
Co-authored-by: Ricardo <[email protected]>
Co-authored-by: Ravin Kumar <[email protected]>
Co-authored-by: Michael Osthege <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing f prefix on f-strings
2 participants