Refactor get_tau_sigma to handle lists #5747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5747 +/- ##
==========================================
- Coverage 89.22% 89.21% -0.02%
==========================================
Files 75 75
Lines 13844 13846 +2
==========================================
Hits 12353 12353
- Misses 1491 1493 +2
|
ricardoV94
reviewed
May 6, 2022
pymc/distributions/continuous.py
Outdated
| tau_ = tau | ||
|
|
||
| tau_ = np.asarray(tau) | ||
| assert np.all(tau_ > 0), "tau must be positive" |
There was a problem hiding this comment.
While we are here, we should replace the asserts by a ValueError
ricardoV94
approved these changes
May 6, 2022
|
Stochastic test failure? |
* support return constant_data with prior pred * pre-commit format * added test * code review
Co-authored-by: Oriol (ZBook) <[email protected]>
…of RNGs needed Reordered methods for consistency
* Deprecates AR1 distribution * Implements random and moment methods * Batching works on the left as with other distributions
This is consistent with the meaning of steps in the GaussianRandomWalk and translates directly to the number of scan steps taken
|
Hmm, bad rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-
Variablearguments converted to arrays before bounds checking. Added simple test.Closes #5745