bpo-29847: Path subclasses raise TypeError given kwargs #13399

jsaporta · 2019-05-18T00:26:02Z

TypeError raised in the subclasses as per the discussion on bugs.python.org.

https://bugs.python.org/issue29847

the-knights-who-say-ni · 2019-05-18T00:26:05Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

eamanu · 2019-05-18T00:54:39Z

Lib/pathlib.py

@@ -1512,13 +1512,23 @@ class PosixPath(Path, PurePosixPath):
    """
    __slots__ = ()

+    def __new__(cls, *args, **kwargs):
+        if kwargs:
+            raise TypeError("keyword arguments provided but ignored")


What about start the raise with uppercase?

Other errors I've seen start with lowercase letters.

>>> 3 + 'string' Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: unsupported operand type(s) for +: 'int' and 'str'

eamanu · 2019-05-18T01:02:59Z

Lib/pathlib.py

 class WindowsPath(Path, PureWindowsPath):
    """Path subclass for Windows systems.

    On a Windows system, instantiating a Path should return this object.
    """
    __slots__ = ()

+    def __new__(cls, *args, **kwargs):
+        if kwargs:


This weird for me because if you don't have kwargs on __new__(cls, *args, **kwargs)
because this will raise a exception, what are you sending on super().__new__(cls, *args, **kwargs)

Not sure I understand you clearly, but if kwargs is an empty dictionary, then it will act as a falsy value in the if statement, and the exception will not be raised.

tirkarthi · 2019-05-18T12:08:26Z

I would suggest adding a NEWS entry and perhaps a versionchanged section to doc since someone could have been passing kwargs though it was silently ignored and undocumented in the past that now raises a TypeError.

EpicWink · 2019-05-20T08:25:01Z

What about a test to see if a new subclass of pathlib.Path (or pathlib.PosixPath or pathlib.WindowsPath) can still use keyword-only parameters in the initialiser?

import pathlib
class MyPath(type(pathlib.Path())):
    def __init__(self, *args, foo):
        self.foo = foo
path = MyPath('bar', foo=42)
assert path.foo == 42

…H-8096) There is no need to clear these immutable objects during shutdown.

Fix DeprecationWarning introduced in aee19f5 https://bugs.python.org/issue37099

This reverts commit 71dc7c5. Turns out you must have write access for CODEOWNERS to work.

https://bugs.python.org/issue36999

@zooba

As per the PEP and the [audit event raised](https://github.com/python/cpython/blob/13d4e6a4a090031f8214e058ed3c8fd47767e05f/Lib/urllib/request.py#L524) in urllib.request this should be `urllib.Request` cc: @zooba

https://bugs.python.org/issue5028

…H-2761)

when platform lacks a functioning sem_open implementation https://bugs.python.org/issue36342

Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953

…H-13686) https://bugs.python.org/issue5028

…yping (GH-13685) This is an old feature request that appears from time to time. After a year of experimenting with various introspection capabilities in `typing_inspect` on PyPI, I propose to add these two most commonly used functions: `get_origin()` and `get_args()`. These are essentially thin public wrappers around private APIs: `__origin__` and `__args__`. As discussed in the issue and on the typing tracker, exposing some public helpers instead of `__origin__` and `__args__` directly will give us more flexibility if we will decide to update the internal representation, while still maintaining backwards compatibility. The implementation is very simple an is essentially a copy from `typing_inspect` with one exception: `ClassVar` was special-cased in `typing_inspect`, but I think this special-casing doesn't really help and only makes things more complicated.

…async (GH-13464) Automatically replace tp_print -> tp_vectorcall_offset tp_compare -> tp_as_async tp_reserved -> tp_as_async

It seems to be the only widget label not capitalized.

… 2. (GH-11859) Escape ``\r``, ``\0`` and ``\x1a`` (end-of-file on Windows) in Unicode strings.

…anup. (GH-10320) TemporaryDirectory.cleanup() failed when non-writeable or non-searchable files or directories were created inside a temporary directory.

The ssl module now can dump key material to a keylog file and trace TLS protocol messages with a tracing callback. The default and stdlib contexts also support SSLKEYLOGFILE env var. The msg_callback and related enums are private members. The feature is designed for internal debugging and not for end users. Signed-off-by: Christian Heimes <[email protected]>

If a type's __ipow__ method was implemented in C, attempting to use the *modulo* parameter would cause crashes. https://bugs.python.org/issue36379

gvanrossum · 2019-06-17T03:27:24Z

It's not cool to spam the entire team with code review requests.

jsaporta · 2019-06-17T03:27:27Z

I synced my fork with master then rebased the issue branch on top of it before updating it. Looks like that may have been a mistake?

methane · 2019-06-17T03:45:41Z

Please use merge instead of rebase next time.
ref: python/devguide#496

brettcannon · 2019-06-18T00:44:03Z

I'm closing this as it has 893 changed files so there's no chance to easily view what the PR is actually targeting.

the-knights-who-say-ni added the CLA not signed label May 18, 2019

bedevere-bot added the awaiting review label May 18, 2019

jsaporta changed the title ~~bpo-29847: Path subclasses raise TypeError wit kwargs~~ bpo-29847: Path subclasses raise TypeError given kwargs May 18, 2019

eamanu reviewed May 18, 2019

View reviewed changes

csabella requested a review from pitrou May 18, 2019 11:34

jdemeyer and others added 22 commits May 30, 2019 12:43

bpo-36974: inherit the vectorcall protocol (GH-13498)

735e8af

bpo-36974: remove _PyObject_HasFastCall (GH-13460)

c145f3b

bpo-20602: Do not clear sys.flags and sys.float_info during shutdown (G…

249b7d5

…H-8096) There is no need to clear these immutable objects during shutdown.

bpo-37099: Silence DeprecationWarning in test_inspect (GH-13679)

6d0b747

Fix DeprecationWarning introduced in aee19f5 https://bugs.python.org/issue37099

bpo-36974: rename _FastCallKeywords -> _Vectorcall (GH-13653)

37788bc

Revert adding @maxking to CODEOWNERS file (GH-13660)

25ee0c3

This reverts commit 71dc7c5. Turns out you must have write access for CODEOWNERS to work.

bpo-36999: Add asyncio.Task.get_coro() (GH-13680)

98ef920

https://bugs.python.org/issue36999

bpo-5028: fix doc bug for tokenize (GH-11683)

1e36f75

https://bugs.python.org/issue5028

bpo-30969: Fix docs about the comparison in absence of __contains__ (G…

2f5b9dc

…H-2761)

bpo-36342: Fix test_multiprocessing in test_venv (GH-12513)

5437ccc

when platform lacks a functioning sem_open implementation https://bugs.python.org/issue36342

bpo-36953: Delay removal of ABCs from collections. (GH-13409)

eea47e0

Bump the removal to 3.9, indicate collections.abc available since 3.3, replace version-changed directive to deprecated-removed. https://bugs.python.org/issue36953

bpo-5028: Fix up rest of documentation for tokenize documenting line (G…

2a58b06

…H-13686) https://bugs.python.org/issue5028

bpo-36974: tp_print -> tp_vectorcall_offset and tp_reserved -> tp_as_…

530f506

…async (GH-13464) Automatically replace tp_print -> tp_vectorcall_offset tp_compare -> tp_as_async tp_reserved -> tp_as_async

bpo-339827: Do not swallow exceptions in the _ssl module. (GH-12756)

65fb2c0

bpo-36548: Improve the repr of re flags. (GH-12715)

14a0e16

IDLE - Capitalize search dialogs' 'Close' button label. (#13691)

ba04302

It seems to be the only widget label not capitalized.

bpo-31829: Make protocol 0 pickles be loadable in text mode in Python…

38ab7d4

… 2. (GH-11859) Escape ``\r``, ``\0`` and ``\x1a`` (end-of-file on Windows) in Unicode strings.

bpo-26660, bpo-35144: Fix permission errors in TemporaryDirectory cle…

e9b51c0

…anup. (GH-10320) TemporaryDirectory.cleanup() failed when non-writeable or non-searchable files or directories were created inside a temporary directory.

bpo-36379: __ipow__ must be a ternaryfunc, not a binaryfunc (GH-13546)

c7f803b

If a type's __ipow__ method was implemented in C, attempting to use the *modulo* parameter would cause crashes. https://bugs.python.org/issue36379

jsaporta requested review from berkerpeksag, brettcannon, encukou, ericsnowcurrently, ericvsmith, gpshead, gvanrossum, ilevkivskyi, methane, ncoghlan, rhettinger, skrah, terryjreedy, tiran, warsaw and a team as code owners June 17, 2019 03:25

gvanrossum removed request for gvanrossum, tiran, warsaw and a team June 17, 2019 03:26

brettcannon closed this Jun 18, 2019

JelleZijlstra mentioned this pull request Oct 10, 2022

Path takes and ignores **kwargs #74033

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-29847: Path subclasses raise TypeError given kwargs #13399

bpo-29847: Path subclasses raise TypeError given kwargs #13399

jsaporta commented May 18, 2019 •

edited by bedevere-bot

Loading

the-knights-who-say-ni commented May 18, 2019

eamanu May 18, 2019

jsaporta May 18, 2019

eamanu May 18, 2019

jsaporta May 18, 2019 •

edited

Loading

tirkarthi commented May 18, 2019

EpicWink commented May 20, 2019 •

edited

Loading

gvanrossum commented Jun 17, 2019

jsaporta commented Jun 17, 2019

methane commented Jun 17, 2019

brettcannon commented Jun 18, 2019

bpo-29847: Path subclasses raise TypeError given kwargs #13399

bpo-29847: Path subclasses raise TypeError given kwargs #13399

Conversation

jsaporta commented May 18, 2019 • edited by bedevere-bot Loading

the-knights-who-say-ni commented May 18, 2019

eamanu May 18, 2019

Choose a reason for hiding this comment

jsaporta May 18, 2019

Choose a reason for hiding this comment

eamanu May 18, 2019

Choose a reason for hiding this comment

jsaporta May 18, 2019 • edited Loading

Choose a reason for hiding this comment

tirkarthi commented May 18, 2019

EpicWink commented May 20, 2019 • edited Loading

gvanrossum commented Jun 17, 2019

jsaporta commented Jun 17, 2019

methane commented Jun 17, 2019

brettcannon commented Jun 18, 2019

jsaporta commented May 18, 2019 •

edited by bedevere-bot

Loading

jsaporta May 18, 2019 •

edited

Loading

EpicWink commented May 20, 2019 •

edited

Loading