Skip to content

Communication #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2017
Merged

Communication #165

merged 2 commits into from
Aug 28, 2017

Conversation

lorenzwalthert
Copy link
Collaborator

Add informative messages along the way.

style_pkg("tests/testthat/public-api/xyzpackage/")
# styling file R/hello-2.R.                       [DONE]
# styling file R/hello-3.R.                       [DONE]
# styling file R/hello-world.R.                   [DONE]
# styling file tests/testthat/test-package-xyz.R. [DONE]
# No files changed.

@lorenzwalthert
Copy link
Collaborator Author

@krlmlr I used an unexported function from utf8 to generate the messages about the number of files changed ellipsis(). Maybe we should just copy over the code from there?

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Aug 28, 2017

Maybe we can even use * next to "[DONE]" to indicate which ones were changed?

style_pkg("tests/testthat/public-api/xyzpackage/")
# styling file R/hello-2.R.                       [DONE] *
# styling file R/hello-3.R.                       [DONE]
# styling file R/hello-world.R.                   [DONE] *
# styling file tests/testthat/test-package-xyz.R. [DONE]
# *File changed.

@krlmlr
Copy link
Member

krlmlr commented Aug 28, 2017

Fine with copying ellipsis() over here, the star looks good as well.

@lorenzwalthert
Copy link
Collaborator Author

lorenzwalthert commented Aug 28, 2017

Changed the layout slightly.

style_dir("tests/testthat/public-api/xyzpackage//")
# Styling files:
# ./R/hello-2.R.                       [DONE] *
# ./R/hello-3.R.                       [DONE]
# ./R/hello-world.R.                   [DONE]
# ./tests/testthat.R.                  [DONE]
# ./tests/testthat/test-package-xyz.R. [DONE]
# * File changed
# Please review the changes carefully!

@lorenzwalthert
Copy link
Collaborator Author

Closes #163.

@codecov
Copy link

codecov bot commented Aug 28, 2017

Codecov Report

Merging #165 into master will increase coverage by 0.04%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   93.79%   93.83%   +0.04%     
==========================================
  Files          19       19              
  Lines         725      746      +21     
==========================================
+ Hits          680      700      +20     
- Misses         45       46       +1
Impacted Files Coverage Δ
R/rules-other.R 100% <100%> (ø) ⬆️
R/transform.R 96.49% <95.23%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38af3b1...5f7f3bf. Read the comment docs.

@lorenzwalthert lorenzwalthert merged commit 88639c1 into r-lib:master Aug 28, 2017
krlmlr added a commit that referenced this pull request Oct 23, 2017
- Hotfix: utf8 should not be verbose (#245).
- Allow styling of Rmd files(#233).
- Remove duplicate @family (#244).
- Fixing token insertion (#242).
- Capitalize Addin titles (#241).
- Explicit `NULL` creation to make styler compatible with R3.2.0 (#237).
- Improve vignettes (#232).
- Allow exclusion of files with `style_pkg()` and `style_dir()`.
- Correct styling with long strings (#230).
- Add tools for re-indenting tokens (#217).
- Math token spacing (#221).
- Remove outdated line and col information (#218).
- Empty input for styling does not cause an error (#227, #228).
- Tools to insert tokens + application on `if`-`else` clauses (#212).
- Improve example in documentation (#222).
- Fix spacing around in (#214).
- Maintenance: renaming functions / files, extend helper, documentation, if_else etc. (#204).
- Disallow line break after ( for function calls (#210).
- Preserve space between `!` and bang (#209).
- Simplify RStudio Addin (#208, #211).
- Indention based on square brackets (#207).
- Add vignette on introducing styler (#203).
- Indent function declaration without curly braces correctly (#202).
- Fix indention in if-else statement (#200).
- Sorting key (#196).
- Use safe sequences (#197).
- Fix space between two commas (#195).
- Keep single-line pipes on one line (#74).
- Remove tidyr and dplyr dependency (#182, #183, @jimhester).
- Fix parsing inconsistency (#188).
- Substitute create filler (#190).
- Introducing class vertical (#189).
- Adapt line break rules (#172).
- Fix `R CMD check` (#185).
- Force argument evaluation for proper error handling (#179).
- Add nonstrict version of set_space_before_comment (#174).
- Add installation instructions to README (#175).
- Addin to style highlighted region (#143).
- Improve spelling (#168).
- Add coverage badge
- Change badge from WIP to active
- Add the number of files to message (#166).
- Improve documentation (#164).
- Add informative messages while styling files (#165).
- More examples in help file (#161).
- No line breaks after pipe if comment is next token (#160).
- Fixing spacing around `!` (non-bang-bang) (#157).
- Finalize function documentation (#154).
- Review vignette (#158).
- Update bang-bang rule (#156).
@olivroy olivroy mentioned this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants