Sorting key #196
Merged
Sorting key #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzwalthert
force-pushed
the
sorting_key
branch
5 times, most recently
from
665e0cf to
ed2c421
Compare
lorenzwalthert
force-pushed
the
sorting_key
branch
from
ed2c421 to
cb5154b
Compare
krlmlr
approved these changes
Sep 17, 2017
R/nested.R
Outdated
| tokenize <- function(text) { | ||
| # avoid https://bugs.r-project.org/bugzilla3/show_bug.cgi?id=16041 | ||
| parse(text = text, keep.source = TRUE) | ||
| parsed <- parse(text = text, keep.source = TRUE) | ||
| parse_data <- as_tibble(utils::getParseData(parsed, includeText = NA)) %>% | ||
| enhance_mapping_special() | ||
| parse_data$pos_id <- seq2(1, nrow(parse_data)) |
There was a problem hiding this comment.
Using 1L instead of 1 might just keep the data in the integer domain. I see that we later use numeric sometimes (+0.3 and +0.6), but this doesn't need to be the default.
There was a problem hiding this comment.
Ok, thanks. I think seq2() creates intervals of integers anyways,
class(rlang::seq2(1, 3))
#> [1] "integer"but we can be a bit more explicit if you like.
|
This property of |
krlmlr
added a commit
that referenced
this pull request
Oct 23, 2017
- Hotfix: utf8 should not be verbose (#245). - Allow styling of Rmd files(#233). - Remove duplicate @family (#244). - Fixing token insertion (#242). - Capitalize Addin titles (#241). - Explicit `NULL` creation to make styler compatible with R3.2.0 (#237). - Improve vignettes (#232). - Allow exclusion of files with `style_pkg()` and `style_dir()`. - Correct styling with long strings (#230). - Add tools for re-indenting tokens (#217). - Math token spacing (#221). - Remove outdated line and col information (#218). - Empty input for styling does not cause an error (#227, #228). - Tools to insert tokens + application on `if`-`else` clauses (#212). - Improve example in documentation (#222). - Fix spacing around in (#214). - Maintenance: renaming functions / files, extend helper, documentation, if_else etc. (#204). - Disallow line break after ( for function calls (#210). - Preserve space between `!` and bang (#209). - Simplify RStudio Addin (#208, #211). - Indention based on square brackets (#207). - Add vignette on introducing styler (#203). - Indent function declaration without curly braces correctly (#202). - Fix indention in if-else statement (#200). - Sorting key (#196). - Use safe sequences (#197). - Fix space between two commas (#195). - Keep single-line pipes on one line (#74). - Remove tidyr and dplyr dependency (#182, #183, @jimhester). - Fix parsing inconsistency (#188). - Substitute create filler (#190). - Introducing class vertical (#189). - Adapt line break rules (#172). - Fix `R CMD check` (#185). - Force argument evaluation for proper error handling (#179). - Add nonstrict version of set_space_before_comment (#174). - Add installation instructions to README (#175). - Addin to style highlighted region (#143). - Improve spelling (#168). - Add coverage badge - Change badge from WIP to active - Add the number of files to message (#166). - Improve documentation (#164). - Add informative messages while styling files (#165). - More examples in help file (#161). - No line breaks after pipe if comment is next token (#160). - Fixing spacing around `!` (non-bang-bang) (#157). - Finalize function documentation (#154). - Review vignette (#158). - Update bang-bang rule (#156).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new attributes
pos_idthat gives the number of the token (as long as no tokens are inserted). Simply using the columnidfor sorting did not work. Closes #112.